Skip to content

[Payment due 2026-03-06] [$250] Reports - CSV card in the saved search shows ID as card name #80896

Closed

Description

@nlemma

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.11-1
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #80556
Email or phone of affected tester (no customers): sjdoinjsdonsjoisj@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.1 / Chrome
App Component: Search

Action Performed:

Precondition:

  • User has imported card transactions from CSV files on OD.
  1. Go to staging.new.expensify.com
  2. Go to Account > Wallet.
  3. Click on the CSV card.
  4. Click View transactions.
  5. Click Filters > Save search.
  6. Click 3-dot menu on the saved search > Rename.

Expected Result:

CSV card in the saved search will show the card name.

Actual Result:

CSV card in the saved search shows ID as card name.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Bug7061245_1769700701231.12.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~022018785979747985673
  • Upwork Job ID: 2018785979747985673
  • Last Price Increase: 2026-02-10
Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jan 29, 2026
  2. melvin-bot commented on Jan 29, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #80556

  3. melvin-bot commented on Jan 29, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  4. melvin-bot commented on Jan 29, 2026

    @melvin-bot

    Triggered auto assignment to @heyjennahay (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. github-actions commented on Jan 29, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. OSBotify commented on Jan 29, 2026

    @OSBotify
    Contributor

    Investigation Summary

    Classification: Frontend bug
    Causing PR: #80556 - [Sprint] [CSV Card Import] Properly display CSV cards in Newdot by @Gonals (High confidence)
    Related Issues: None

    Recommendation: ROLL FORWARD

    PR #80556 added support for displaying CSV-imported cards in NewDot, but it only updated the display logic in specific UI components (PaymentMethodList, maskCardNumber). The getCardDescription() function in CardUtils.ts was not updated to handle CSV cards, causing saved searches to display the card ID instead of the user-provided card name.

    A roll forward fix is simpler and less risky than reverting, as the PR introduced a new feature rather than breaking existing functionality. The fix requires adding CSV card handling to getCardDescription() similar to what was done in maskCardNumber().

    Labels: No label changes needed - keeping DeployBlockerCash as this is a frontend bug that blocks the App deploy.

  7. OSBotify commented on Jan 29, 2026

    @OSBotify
    Contributor

    Detailed Analysis

    Evidence:
    PR #80556 introduced CSV card import functionality to NewDot. The issue report shows that when users:

    1. Import card transactions from CSV in OldDot
    2. View the card in NewDot wallet
    3. Create a saved search with transactions from that card
    4. The saved search displays the card ID (e.g., "12345") instead of the card name (e.g., "Business Card")

    This only affects CSV imported cards and is reproducible 100% on staging across all platforms.

    Verification:
    The PR modified these files related to card display:

    • src/libs/CardUtils.ts - Added special handling in maskCardNumber() to return CSV card names as-is
    • src/pages/settings/Wallet/PaymentMethodList.tsx - Added logic to show "CSV Import" as description
    • But did NOT update getCardDescription() function

    Saved searches use getCardDescription() via SearchQueryUtils.ts (lines 1076, 1160) to display card names in search results.

  8. 34 remaining items

  9. marufsharifi commented on Mar 5, 2026

    @marufsharifi
    Contributor

    @heyjennahay, could you please process the payment for this issue since the PR was deployed to production last week? thanks.

  10. heyjennahay commented on Mar 6, 2026

    @heyjennahay
    Contributor

    Hi @marufsharifi just confirming that you didn't apply for the Upwork job as requested here? I don't want to accidentally create any duplicates 😅

  11. melvin-bot commented on Mar 6, 2026

    @melvin-bot

    Current assignee @heyjennahay is eligible for the Awaiting Payment assigner, not assigning anyone new.

  12. changed the title [-][$250] Reports - CSV card in the saved search shows ID as card name[/-] [+][Payment due 2026-03-06] [$250] Reports - CSV card in the saved search shows ID as card name[/+] on Mar 6, 2026
  13. marufsharifi commented on Mar 6, 2026

    @marufsharifi
    Contributor

    @heyjennahay, let me check.

  14. marufsharifi commented on Mar 6, 2026

    @marufsharifi
    Contributor

    Hi @marufsharifi just confirming that you didn't apply for the Upwork job as requested here? I don't want to accidentally create any duplicates 😅

    @heyjennahay, right, I didn't apply, since the task wasn't available once assigned. thanks.

  15. heyjennahay commented on Mar 6, 2026

    @heyjennahay
    Contributor

    @marufsharifi can you please accept this offer in Upwork? https://www.upwork.com/nx/wm/offer/110683814

  16. marufsharifi commented on Mar 6, 2026

    @marufsharifi
    Contributor

    @heyjennahay, I've accepted the offer. thanks.

  17. heyjennahay commented on Mar 6, 2026

    @heyjennahay
    Contributor

    Thanks!

    Payment summary:

    • @eh2077 please request $250 payment via NewDot
    • @marufsharifi I have paid you $250 via Upwork and closed your contract. Also confirming the Upwork job is closed.

    Thanks for your work!

  18. JmillsExpensify commented on Mar 13, 2026

    @JmillsExpensify
    Contributor

    $250 approved for @eh2077

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions