You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-07-03] Video - Video is not playing in full screen, no controls, app is unresponsive #80943
Version Number: 9.3.11-1 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from BrowserStack:https://test-management.browserstack.com/projects/2219752/folder/13176710/test-cases/41236938 Email or phone of affected tester (no customers): N/A Issue reported by: Applause Internal Team Bug source: Regression TC Execution Device used: iPhone 15 iOS 26.3 App Component: Other
Action Performed:
Sign in to ND
Open 1:1 chat, send a video
Tap the video, while playing, pause it
Tap the Fullscreen button
Try to play the video or exit the fullscreen view
Expected Result:
Video is controllable and can be played in fullscreen mode. User is able to exit the video
Actual Result:
When pausing the video and opening it in full screen, it is displayed as an image, does not have any control buttons, and cannot be exited other than relaunching the app. The same issue happens, while sending the video
🚨 Edited by proposal-police: This proposal was edited at 2026-02-10 12:07:35 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
When a user opens a video in a 1:1 chat, pauses it, and taps the Fullscreen button, the video enters fullscreen but:
It is displayed as a static image (no playback controls).
There are no control buttons (play/pause, seek, or exit).
The user cannot exit fullscreen except by relaunching the app.
The same behavior occurs when sending a video. The expected behavior is that the video is controllable in fullscreen (play/pause, seek, exit).
What is the root cause of that problem?
The fullscreen flag is stored only in a ref (isFullScreenRef from FullScreenContext). The VideoView (expo-video) is passed nativeControls={isFullScreenRef.current}.
Refs do not trigger re-renders. So when the user taps Fullscreen:
The native layer enters fullscreen and fires onFullscreenEnter, which sets isFullScreenRef.current = true (BaseVideoPlayer).
Because this is a ref update, the component does not re-render. The VideoView was rendered with nativeControls={false} and never receives nativeControls={true}.
In fullscreen, the native player therefore keeps the “no native controls” configuration. The custom React controls (play, fullscreen, etc.) are not part of the fullscreen native layer, so the user sees only the video (or a frozen frame when paused) with no way to play, seek, or exit.
Relevant code:
<VideoView// has to be switched to fullscreenOptions={{enable: true}} when mobile Safari gets fixedallowsFullscreenplayer={videoPlayerRef.current}style={[styles.w100,styles.h100,videoPlayerStyle,hasErrorIconVisible&&{opacity: 0}]}nativeControls={isFullScreenRef.current}
When fullscreen is entered, onFullscreenEnter only updates the ref, so nativeControls never becomes true for the native layer.
What changes do you think we should make in order to solve the problem?
Track fullscreen with state as well as the existing ref in BaseVideoPlayer, so that when we enter or exit fullscreen the component re-renders and VideoView receives nativeControls={true} while in fullscreen. The ref must continue to be updated so existing logic that reads isFullScreenRef.current (e.g. shareVideoPlayerElements, AttachmentCarouselView, useWindowDimensions) still works.
// Only isFullScreenRef from context; no state. VideoView receives:nativeControls={isFullScreenRef.current}// ...onFullscreenEnter={()=>{isFullScreenRef.current=true;if(!(videoPlayerElementParentRef.current&&'addEventListener'invideoPlayerElementParentRef.current)){return;}videoPlayerElementParentRef.current.addEventListener('wheel',stopWheelPropagation);}}onFullscreenExit={()=>{isFullScreenRef.current=false;if(videoPlayerElementParentRef.current&&'removeEventListener'invideoPlayerElementParentRef.current){videoPlayerElementParentRef.current.removeEventListener('wheel',stopWheelPropagation);}updateVolume(videoPlayerRef.current.muted ? 0 : videoPlayerRef.current.volume||1);}}
With this, entering fullscreen causes a re-render and the native fullscreen UI can show system controls (play/pause, seek, exit). The ref stays in sync for all other consumers.
What alternative solutions did you explore? (Optional)
Always pass nativeControls={true}: Would show native controls in inline mode as well and could conflict with the custom controls (two sets of controls, layout issues). Rejected.
Rely on expo-video to enable native controls when entering fullscreen: The library does not appear to switch to native controls automatically when enterFullscreen() is used with nativeControls={false}; the current behavior (no controls in fullscreen) is consistent with that. So we need to change the prop when entering fullscreen via state-driven re-render.
Move fullscreen state into FullScreenContext: Possible, but would force every context consumer to re-render on fullscreen toggle. Keeping state local to BaseVideoPlayer is sufficient and avoids unnecessary re-renders.
Restate the problem this issue is trying to solve.
On iOS, when a video is paused and then opened in fullscreen, the fullscreen view shows a frozen frame. There are no playback controls and no close button. The user cannot exit fullscreen and the app looks stuck.
What is the root cause of that problem?
The earliest wrong assumption is that custom React controls will also work in fullscreen. In src/components/VideoPlayer.tsx, inside the fullscreen handler that uses presentFullscreenPlayer, native controls are always disabled. This is wrong because the custom controls only render in the inline view. When fullscreen opens, there are no controls at all. This directly causes the stuck fullscreen state.
What changes do you think we should make in order to solve the problem?
Add fullscreen state in src/components/VideoPlayer.tsx.
⚠️@yatin-italy Your proposal is a duplicate of an already existing proposal and has been automatically withdrawn to prevent spam. Please review the existing proposals before submitting a new one.
@rojiphil@joekaufmanexpensify My Proposal is not a duplicate. Although the root cause is the same, my proposal fixes it by enabling native controls before entering fullscreen and reverting them on exit, which prevents the no-controls timing issue that causes the stuck state.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: Not Required
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Contributor: @annaweber830 paid $250 via Upwork
Contributor+: @rojiphil due $250 via NewDot
@annaweber830 can you please accept the job below? Please reply here and tag me once you have.
If you're not sent an offer in Upwork when you're assigned to an issue, please tag me. If an Upwork job exists, please submit a proposal. https://www.upwork.com/jobs/~022074245619027698736
Activity
melvin-bot commentedon Jan 29, 2026
Triggered auto assignment to Contributor-plus team member for initial proposal review - @rojiphil (
External)melvin-bot commentedon Jan 29, 2026
Triggered auto assignment to @joekaufmanexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.annaweber830 commentedon Jan 29, 2026
🚨 Edited by proposal-police: This proposal was edited at 2026-02-10 12:07:35 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
When a user opens a video in a 1:1 chat, pauses it, and taps the Fullscreen button, the video enters fullscreen but:
The same behavior occurs when sending a video. The expected behavior is that the video is controllable in fullscreen (play/pause, seek, exit).
What is the root cause of that problem?
The fullscreen flag is stored only in a ref (
isFullScreenReffromFullScreenContext). TheVideoView(expo-video) is passednativeControls={isFullScreenRef.current}.Refs do not trigger re-renders. So when the user taps Fullscreen:
enterFullScreenMode()callsvideoViewRef.current?.enterFullscreen()(VideoPlayerControls).onFullscreenEnter, which setsisFullScreenRef.current = true(BaseVideoPlayer).VideoViewwas rendered withnativeControls={false}and never receivesnativeControls={true}.Relevant code:
When fullscreen is entered,
onFullscreenEnteronly updates the ref, sonativeControlsnever becomestruefor the native layer.What changes do you think we should make in order to solve the problem?
Track fullscreen with state as well as the existing ref in
BaseVideoPlayer, so that when we enter or exit fullscreen the component re-renders andVideoViewreceivesnativeControls={true}while in fullscreen. The ref must continue to be updated so existing logic that readsisFullScreenRef.current(e.g.shareVideoPlayerElements,AttachmentCarouselView,useWindowDimensions) still works.File to change: BaseVideoPlayer.tsx.
Current code:
Updated code:
With this, entering fullscreen causes a re-render and the native fullscreen UI can show system controls (play/pause, seek, exit). The ref stays in sync for all other consumers.
What alternative solutions did you explore? (Optional)
nativeControls={true}: Would show native controls in inline mode as well and could conflict with the custom controls (two sets of controls, layout issues). Rejected.enterFullscreen()is used withnativeControls={false}; the current behavior (no controls in fullscreen) is consistent with that. So we need to change the prop when entering fullscreen via state-driven re-render.FullScreenContext: Possible, but would force every context consumer to re-render on fullscreen toggle. Keeping state local toBaseVideoPlayeris sufficient and avoids unnecessary re-renders.yatin-italy commentedon Jan 30, 2026
Proposal
Restate the problem this issue is trying to solve.
On iOS, when a video is paused and then opened in fullscreen, the fullscreen view shows a frozen frame. There are no playback controls and no close button. The user cannot exit fullscreen and the app looks stuck.
What is the root cause of that problem?
The earliest wrong assumption is that custom React controls will also work in fullscreen. In
src/components/VideoPlayer.tsx, inside the fullscreen handler that usespresentFullscreenPlayer, native controls are always disabled. This is wrong because the custom controls only render in the inline view. When fullscreen opens, there are no controls at all. This directly causes the stuck fullscreen state.What changes do you think we should make in order to solve the problem?
src/components/VideoPlayer.tsx.src/components/VideoPlayer.tsxto track fullscreen state.src/components/VideoPlayer.tsx.What alternative solutions did you explore? (Optional)
Rebuilding custom controls for fullscreen was considered, but it adds more code and risk. Using native controls in fullscreen is simpler and safer.
github-actions commentedon Jan 30, 2026
yatin-italy commentedon Jan 30, 2026
@rojiphil @joekaufmanexpensify My Proposal is not a duplicate. Although the root cause is the same, my proposal fixes it by enabling native controls before entering fullscreen and reverting them on exit, which prevents the no-controls timing issue that causes the stuck state.
joekaufmanexpensify commentedon Feb 3, 2026
@rojiphil could you help review proposals here?
46 remaining items
melvin-bot commentedon Jul 1, 2026
@rojiphil Eep! 4 days overdue now. Issues have feelings too...
melvin-bot commentedon Jul 2, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)melvin-bot commentedon Jul 2, 2026
Payment Summary
Upwork Job
BugZero Checklist (@mallenexpensify)
rojiphil commentedon Jul 3, 2026
BugZero Checklist:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: Not Required
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue: https://github.com/Expensify/Expensify/issues/656576
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
Zapier Logs
Run ID: 00040eee-81b9-a8d4-e591-cbfa62e70cd4mallenexpensify commentedon Jul 6, 2026
Payment Summary
Contributor: @annaweber830 paid $250 via Upwork
Contributor+: @rojiphil due $250 via NewDot
@annaweber830 can you please accept the job below? Please reply here and tag me once you have.
If you're not sent an offer in Upwork when you're assigned to an issue, please tag me. If an Upwork job exists, please submit a proposal.
https://www.upwork.com/jobs/~022074245619027698736
^ Test case created. Thx
annaweber830 commentedon Jul 7, 2026
Hi @mallenexpensify I accepted offer. thanks
mallenexpensify commentedon Jul 7, 2026
@annaweber830 paid, summary updated above. Thx.
quinthar commentedon Sep 2, 2026
Approved $250 to @rojiphil