Skip to content

[Due for payment 2026-07-03] Video - Video is not playing in full screen, no controls, app is unresponsive #80943

Closed

Description

@vincdargento

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.11-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/folder/13176710/test-cases/41236938
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Bug source: Regression TC Execution
Device used: iPhone 15 iOS 26.3
App Component: Other

Action Performed:

  1. Sign in to ND
  2. Open 1:1 chat, send a video
  3. Tap the video, while playing, pause it
  4. Tap the Fullscreen button
  5. Try to play the video or exit the fullscreen view

Expected Result:

Video is controllable and can be played in fullscreen mode. User is able to exit the video

Actual Result:

When pausing the video and opening it in full screen, it is displayed as an image, does not have any control buttons, and cannot be exited other than relaunching the app. The same issue happens, while sending the video

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jan 29, 2026
  2. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jan 29, 2026
  3. melvin-bot commented on Jan 29, 2026

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @rojiphil (External)

  4. melvin-bot commented on Jan 29, 2026

    @melvin-bot

    Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. annaweber830 commented on Jan 29, 2026

    @annaweber830
    Contributor

    🚨 Edited by proposal-police: This proposal was edited at 2026-02-10 12:07:35 UTC.

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    When a user opens a video in a 1:1 chat, pauses it, and taps the Fullscreen button, the video enters fullscreen but:

    • It is displayed as a static image (no playback controls).
    • There are no control buttons (play/pause, seek, or exit).
    • The user cannot exit fullscreen except by relaunching the app.

    The same behavior occurs when sending a video. The expected behavior is that the video is controllable in fullscreen (play/pause, seek, exit).

    What is the root cause of that problem?

    The fullscreen flag is stored only in a ref (isFullScreenRef from FullScreenContext). The VideoView (expo-video) is passed nativeControls={isFullScreenRef.current}.

    Refs do not trigger re-renders. So when the user taps Fullscreen:

    1. enterFullScreenMode() calls videoViewRef.current?.enterFullscreen() (VideoPlayerControls).
    2. The native layer enters fullscreen and fires onFullscreenEnter, which sets isFullScreenRef.current = true (BaseVideoPlayer).
    3. Because this is a ref update, the component does not re-render. The VideoView was rendered with nativeControls={false} and never receives nativeControls={true}.
    4. In fullscreen, the native player therefore keeps the “no native controls” configuration. The custom React controls (play, fullscreen, etc.) are not part of the fullscreen native layer, so the user sees only the video (or a frozen frame when paused) with no way to play, seek, or exit.

    Relevant code:

                                            <VideoView
                                                // has to be switched to fullscreenOptions={{enable: true}} when mobile Safari gets fixed
                                                allowsFullscreen
                                                player={videoPlayerRef.current}
                                                style={[styles.w100, styles.h100, videoPlayerStyle, hasErrorIconVisible && {opacity: 0}]}
                                                nativeControls={isFullScreenRef.current}

    When fullscreen is entered, onFullscreenEnter only updates the ref, so nativeControls never becomes true for the native layer.

    What changes do you think we should make in order to solve the problem?

    Track fullscreen with state as well as the existing ref in BaseVideoPlayer, so that when we enter or exit fullscreen the component re-renders and VideoView receives nativeControls={true} while in fullscreen. The ref must continue to be updated so existing logic that reads isFullScreenRef.current (e.g. shareVideoPlayerElements, AttachmentCarouselView, useWindowDimensions) still works.

    File to change: BaseVideoPlayer.tsx.

    Current code:

    // Only isFullScreenRef from context; no state. VideoView receives:
    nativeControls={isFullScreenRef.current}
    // ...
    onFullscreenEnter={() => {
        isFullScreenRef.current = true;
        if (!(videoPlayerElementParentRef.current && 'addEventListener' in videoPlayerElementParentRef.current)) {
            return;
        }
        videoPlayerElementParentRef.current.addEventListener('wheel', stopWheelPropagation);
    }}
    onFullscreenExit={() => {
        isFullScreenRef.current = false;
        if (videoPlayerElementParentRef.current && 'removeEventListener' in videoPlayerElementParentRef.current) {
            videoPlayerElementParentRef.current.removeEventListener('wheel', stopWheelPropagation);
        }
        updateVolume(videoPlayerRef.current.muted ? 0 : videoPlayerRef.current.volume || 1);
    }}

    Updated code:

    const [isFullScreen, setIsFullScreen] = useState(false);
    // ...
    nativeControls={isFullScreen}
    // ...
    onFullscreenEnter={() => {
        isFullScreenRef.current = true;
        setIsFullScreen(true);
        if (!(videoPlayerElementParentRef.current && 'addEventListener' in videoPlayerElementParentRef.current)) {
            return;
        }
        videoPlayerElementParentRef.current.addEventListener('wheel', stopWheelPropagation);
    }}
    onFullscreenExit={() => {
        isFullScreenRef.current = false;
        setIsFullScreen(false);
        if (videoPlayerElementParentRef.current && 'removeEventListener' in videoPlayerElementParentRef.current) {
            videoPlayerElementParentRef.current.removeEventListener('wheel', stopWheelPropagation);
        }
        updateVolume(videoPlayerRef.current.muted ? 0 : videoPlayerRef.current.volume || 1);
    }}

    With this, entering fullscreen causes a re-render and the native fullscreen UI can show system controls (play/pause, seek, exit). The ref stays in sync for all other consumers.

    What alternative solutions did you explore? (Optional)

    • Always pass nativeControls={true}: Would show native controls in inline mode as well and could conflict with the custom controls (two sets of controls, layout issues). Rejected.
    • Rely on expo-video to enable native controls when entering fullscreen: The library does not appear to switch to native controls automatically when enterFullscreen() is used with nativeControls={false}; the current behavior (no controls in fullscreen) is consistent with that. So we need to change the prop when entering fullscreen via state-driven re-render.
    • Move fullscreen state into FullScreenContext: Possible, but would force every context consumer to re-render on fullscreen toggle. Keeping state local to BaseVideoPlayer is sufficient and avoids unnecessary re-renders.
  6. yatin-italy commented on Jan 30, 2026

    @yatin-italy

    Proposal

    Restate the problem this issue is trying to solve.

    On iOS, when a video is paused and then opened in fullscreen, the fullscreen view shows a frozen frame. There are no playback controls and no close button. The user cannot exit fullscreen and the app looks stuck.

    What is the root cause of that problem?

    The earliest wrong assumption is that custom React controls will also work in fullscreen. In src/components/VideoPlayer.tsx, inside the fullscreen handler that uses presentFullscreenPlayer, native controls are always disabled. This is wrong because the custom controls only render in the inline view. When fullscreen opens, there are no controls at all. This directly causes the stuck fullscreen state.

    What changes do you think we should make in order to solve the problem?

    • Add fullscreen state in src/components/VideoPlayer.tsx.
    // src/components/VideoPlayer.tsx
    const [isFullscreen, setIsFullscreen] = useState(false);
    • Update the fullscreen event handler in src/components/VideoPlayer.tsx to track fullscreen state.
    // src/components/VideoPlayer.tsx
    if (event.fullscreenUpdate === VideoFullscreenUpdate.PLAYER_DID_PRESENT) {
        setIsFullscreen(true);
    }
    if (event.fullscreenUpdate === VideoFullscreenUpdate.PLAYER_DID_DISMISS) {
        setIsFullscreen(false);
    }
    • Enable native controls only when fullscreen is active in src/components/VideoPlayer.tsx.
    // src/components/VideoPlayer.tsx
    useNativeControls={isFullscreen}

    What alternative solutions did you explore? (Optional)

    Rebuilding custom controls for fullscreen was considered, but it adds more code and risk. Using native controls in fullscreen is simpler and safer.

  7. github-actions commented on Jan 30, 2026

    @github-actions
    Contributor

    ⚠️ @yatin-italy Your proposal is a duplicate of an already existing proposal and has been automatically withdrawn to prevent spam. Please review the existing proposals before submitting a new one.

  8. yatin-italy commented on Jan 30, 2026

    @yatin-italy

    @rojiphil @joekaufmanexpensify My Proposal is not a duplicate. Although the root cause is the same, my proposal fixes it by enabling native controls before entering fullscreen and reverting them on exit, which prevents the no-controls timing issue that causes the stuck state.

  9. joekaufmanexpensify commented on Feb 3, 2026

    @joekaufmanexpensify
    Contributor

    @rojiphil could you help review proposals here?

  10. 46 remaining items

  11. melvin-bot commented on Jul 1, 2026

    @melvin-bot

    @rojiphil Eep! 4 days overdue now. Issues have feelings too...

  12. melvin-bot commented on Jul 2, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  13. melvin-bot commented on Jul 2, 2026

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@mallenexpensify)

    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  14. rojiphil commented on Jul 3, 2026

    @rojiphil
    Contributor

    BugZero Checklist:

    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: Not Required

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal Template

    Regression Test Proposal

    Precondition:

    Test:

    1. Sign in to ND
    2. Open 1:1 chat, send a video
    3. Tap the video, while playing, pause it
    4. Tap the Fullscreen button
    5. Verify that the video can be played and paused.
    6. Verify that the fullscreen view can be exited.

    Do we agree 👍 or 👎

    Zapier Logs Run ID: 00040eee-81b9-a8d4-e591-cbfa62e70cd4
  15. mallenexpensify commented on Jul 6, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor: @annaweber830 paid $250 via Upwork
    Contributor+: @rojiphil due $250 via NewDot

    @annaweber830 can you please accept the job below? Please reply here and tag me once you have.
    If you're not sent an offer in Upwork when you're assigned to an issue, please tag me. If an Upwork job exists, please submit a proposal.
    https://www.upwork.com/jobs/~022074245619027698736

    ^ Test case created. Thx

  16. annaweber830 commented on Jul 7, 2026

    @annaweber830
    Contributor

    Hi @mallenexpensify I accepted offer. thanks

  17. mallenexpensify commented on Jul 7, 2026

    @mallenexpensify
    Contributor

    @annaweber830 paid, summary updated above. Thx.

  18. quinthar commented on Sep 2, 2026

    @quinthar
    Contributor

    Approved $250 to @rojiphil

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions