Skip to content

Web - Refreshing the page after resizing the screen opens connect to bank account page #8107

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue was found when executing PR #8041

Action Performed:

  1. Go to settings
  2. Open any workspace
  3. Go to connect bank account
  4. Go to connect manually
  5. Go to 2nd step (Company Information)
  6. Decrease the screen size
  7. Reload the page

Expected Result:

Verify incorporation date label doesn't overlap with the value. Page with incorporation date should be open.

Actual Result:

Page with incorporation date isn't opened. App reload and open 'connect bank account" page again.
Issue occurred on Desktop App as well.

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web

Version Number: v1.1.42-4

Reproducible in staging?: y

Reproducible in production?: y

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos:

Bug5487480_Bank_full.mp4

Bug5487480_Screen_Shot_2022-03-11_at_2 52 02_PM

Expensify/Expensify Issue URL:

Issue reported by: Applause

Slack conversation:

View all open jobs on GitHub
Issue was found when executing PR #8041

Activity

  1. MelvinBot commented on Mar 11, 2022

    @MelvinBot
    Contributor

    Triggered auto assignment to @neil-marcellini (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  2. neil-marcellini commented on Mar 11, 2022

    @neil-marcellini
    Contributor

    I was able to reproduce this with these steps:

    1. Load the homepage
    2. Go to Settings > Preferences and turn on Use Secure Staging Server
    3. Go to Settings > Workspace > Connect Bank Account > Connect online with Plaid and enter the test account info
    4. Select "Plaid Savings"
    5. Notice that the URL is https://staging.new.expensify.com/bank-account/BankAccountStep
    6. Refresh the page and you will be back at Conenct Bank Account
    7. Repeat steps 3 and 4
    8. Notice that the URL is now https://staging.new.expensify.com/bank-account/company
    9. Refresh the page and you will stay on the company info page.

    So it seems like for some reason the URL is not being updated correctly on the first run through of this. On step 4 you can also enter the test routing number and account number and the error also occurs. I'll start investigating how to fix this.

  3. neil-marcellini commented on Mar 15, 2022

    @neil-marcellini
    Contributor

    This was fixed by #8065, specifically with the change proposed in this comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions