Skip to content

[Due for Payment 2026-02-12] Reports - Week, Year and Quarter column can be unselected #81081

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.11-17
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #80800
Email or phone of affected tester (no customers): sidnjosdnjdosijsojns@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.1 / Chrome
App Component: Search

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to Reports > Expenses.
  3. Click Filters > Group by.
  4. Select Week > Save.
  5. Click Columns.
  6. Deselect Week > Save.
  7. Repeat Step 3 to 6 with Year and Quarter filter.

Expected Result:

Week, Year and Quarter column should be fixed and cannot be unselected.

Actual Result:

Week, Year and Quarter column can be unselected, but the table still shows the column.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Bug7062438_1769819667851.4.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @trjExpensify

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Jan 31, 2026
  2. melvin-bot commented on Jan 31, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #80800

  3. melvin-bot commented on Jan 31, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  4. melvin-bot commented on Jan 31, 2026

    @melvin-bot

    Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. github-actions commented on Jan 31, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. OSBotify commented on Jan 31, 2026

    @OSBotify
    Contributor

    Investigation Summary

    Classification: Frontend bug
    Causing PR: #80800 - "Support groupBy:year and groupBy:quarter in the App" by @cristipaval (High confidence)
    Related Issues: None

    Recommendation: ROLL FORWARD

    A simple fix is needed to add the missing columns to the required columns set. The PR author is already tagged and can quickly implement this fix. Reverting would remove the entire year/quarter grouping feature, which is more disruptive than adding 3 missing entries to a Set.

    Labels: No label changes needed - this is a Frontend bug affecting the App, so DeployBlockerCash should remain. DeployBlocker should be removed since this is not a backend issue.

    Detailed Analysis

    Evidence

    PR #80800 added support for groupBy:year and groupBy:quarter in search results. The PR correctly implemented:

    • Year and Quarter group types in CONST
    • UI rendering for year/quarter headers
    • Search query handling
    • Column configurations in SearchUIUtils.ts (lines 4160-4192)

    However, the PR missed updating the requiredColumns Set in src/pages/Search/SearchColumnsPage.tsx (lines 58-68).

    Verification

    The affected file is /home/runner/work/App/App/src/pages/Search/SearchColumnsPage.tsx:

    Current code (lines 58-68):

    const requiredColumns = new Set<SearchCustomColumnIds>([
        CONST.SEARCH.TABLE_COLUMNS.TOTAL_AMOUNT,
        CONST.SEARCH.TABLE_COLUMNS.TOTAL,
        CONST.SEARCH.TABLE_COLUMNS.GROUP_CARD,
        CONST.SEARCH.TABLE_COLUMNS.GROUP_WITHDRAWAL_ID,
        CONST.SEARCH.TABLE_COLUMNS.GROUP_FROM,
        CONST.SEARCH.TABLE_COLUMNS.GROUP_CATEGORY,
        CONST.SEARCH.TABLE_COLUMNS.GROUP_MERCHANT,
        CONST.SEARCH.TABLE_COLUMNS.GROUP_TAG,
        CONST.SEARCH.TABLE_COLUMNS.GROUP_MONTH,
    ]);

    Missing entries:

    • CONST.SEARCH.TABLE_COLUMNS.GROUP_WEEK
    • CONST.SEARCH.TABLE_COLUMNS.GROUP_YEAR
    • CONST.SEARCH.TABLE_COLUMNS.GROUP_QUARTER

    This Set controls which columns cannot be deselected in the Columns picker (line 137: if (requiredColumns.has(updatedColumnId)) return;). Without these entries, users can deselect the grouping column, but the table still displays it because the groupBy logic in SearchUIUtils.ts always includes it as a required column (lines 4160-4192).

    Root Cause

    The disconnect occurs because there are two separate places that define "required" columns:

    1. SearchUIUtils.ts - Controls what columns are actually displayed in the table (correctly includes year/quarter)
    2. SearchColumnsPage.tsx - Controls what columns can be deselected in the UI (missing year/quarter/week)

    When a user deselects the year/quarter/week column, the UI state changes but the table still shows the column due to the logic in SearchUIUtils.ts, creating the confusing UX described in the issue.

    Fix: Add the three missing columns to the requiredColumns Set in SearchColumnsPage.tsx.

  7. 7 remaining items

  8. cristipaval commented on Feb 2, 2026

    @cristipaval
    Contributor

    Demoting, it doesn't block the user.

  9. changed the title [-]Reports - Week, Year and Quarter column can be unselected[/-] [+][Due for Payment 2026-02-12] Reports - Week, Year and Quarter column can be unselected[/+] on Feb 5, 2026
  10. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed
    ReviewingHas a PR in review
    on Feb 5, 2026
  11. trjExpensify commented on Feb 12, 2026

    @trjExpensify
    Contributor

    Payment summary as follows:

    Go ahead and request, closing!

  12. garrettmknight commented on Apr 2, 2026

    @garrettmknight
    Contributor

    $250 approved for @shubham1206agra

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions