You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for Payment 2026-02-12] Reports - Week, Year and Quarter column can be unselected #81081
Version Number: 9.3.11-17 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#80800 Email or phone of affected tester (no customers):sidnjosdnjdosijsojns@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.1 / Chrome App Component: Search
Action Performed:
Go to staging.new.expensify.com
Go to Reports > Expenses.
Click Filters > Group by.
Select Week > Save.
Click Columns.
Deselect Week > Save.
Repeat Step 3 to 6 with Year and Quarter filter.
Expected Result:
Week, Year and Quarter column should be fixed and cannot be unselected.
Actual Result:
Week, Year and Quarter column can be unselected, but the table still shows the column.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #80800 - "Support groupBy:year and groupBy:quarter in the App" by @cristipaval (High confidence) Related Issues: None
Recommendation: ROLL FORWARD
A simple fix is needed to add the missing columns to the required columns set. The PR author is already tagged and can quickly implement this fix. Reverting would remove the entire year/quarter grouping feature, which is more disruptive than adding 3 missing entries to a Set.
Labels: No label changes needed - this is a Frontend bug affecting the App, so DeployBlockerCash should remain. DeployBlocker should be removed since this is not a backend issue.
Detailed Analysis
Evidence
PR #80800 added support for groupBy:year and groupBy:quarter in search results. The PR correctly implemented:
Year and Quarter group types in CONST
UI rendering for year/quarter headers
Search query handling
Column configurations in SearchUIUtils.ts (lines 4160-4192)
However, the PR missed updating the requiredColumns Set in src/pages/Search/SearchColumnsPage.tsx (lines 58-68).
Verification
The affected file is /home/runner/work/App/App/src/pages/Search/SearchColumnsPage.tsx:
This Set controls which columns cannot be deselected in the Columns picker (line 137: if (requiredColumns.has(updatedColumnId)) return;). Without these entries, users can deselect the grouping column, but the table still displays it because the groupBy logic in SearchUIUtils.ts always includes it as a required column (lines 4160-4192).
Root Cause
The disconnect occurs because there are two separate places that define "required" columns:
SearchUIUtils.ts - Controls what columns are actually displayed in the table (correctly includes year/quarter)
SearchColumnsPage.tsx - Controls what columns can be deselected in the UI (missing year/quarter/week)
When a user deselects the year/quarter/week column, the UI state changes but the table still shows the column due to the logic in SearchUIUtils.ts, creating the confusing UX described in the issue.
Fix: Add the three missing columns to the requiredColumns Set in SearchColumnsPage.tsx.
changed the title [-]Reports - Week, Year and Quarter column can be unselected[/-][+][Due for Payment 2026-02-12] Reports - Week, Year and Quarter column can be unselected[/+]on Feb 5, 2026
Activity
melvin-bot commentedon Jan 31, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #80800
melvin-bot commentedon Jan 31, 2026
💬 A slack conversation has been started in #expensify-open-source
melvin-bot commentedon Jan 31, 2026
Triggered auto assignment to @stephanieelliott (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.github-actions commentedon Jan 31, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon Jan 31, 2026
Investigation Summary
Classification: Frontend bug
Causing PR: #80800 - "Support groupBy:year and groupBy:quarter in the App" by @cristipaval (High confidence)
Related Issues: None
Recommendation: ROLL FORWARD
A simple fix is needed to add the missing columns to the required columns set. The PR author is already tagged and can quickly implement this fix. Reverting would remove the entire year/quarter grouping feature, which is more disruptive than adding 3 missing entries to a Set.
Labels: No label changes needed - this is a Frontend bug affecting the App, so
DeployBlockerCashshould remain.DeployBlockershould be removed since this is not a backend issue.Detailed Analysis
Evidence
PR #80800 added support for
groupBy:yearandgroupBy:quarterin search results. The PR correctly implemented:However, the PR missed updating the
requiredColumnsSet insrc/pages/Search/SearchColumnsPage.tsx(lines 58-68).Verification
The affected file is
/home/runner/work/App/App/src/pages/Search/SearchColumnsPage.tsx:Current code (lines 58-68):
Missing entries:
CONST.SEARCH.TABLE_COLUMNS.GROUP_WEEKCONST.SEARCH.TABLE_COLUMNS.GROUP_YEARCONST.SEARCH.TABLE_COLUMNS.GROUP_QUARTERThis Set controls which columns cannot be deselected in the Columns picker (line 137:
if (requiredColumns.has(updatedColumnId)) return;). Without these entries, users can deselect the grouping column, but the table still displays it because the groupBy logic in SearchUIUtils.ts always includes it as a required column (lines 4160-4192).Root Cause
The disconnect occurs because there are two separate places that define "required" columns:
When a user deselects the year/quarter/week column, the UI state changes but the table still shows the column due to the logic in SearchUIUtils.ts, creating the confusing UX described in the issue.
Fix: Add the three missing columns to the
requiredColumnsSet in SearchColumnsPage.tsx.7 remaining items
cristipaval commentedon Feb 2, 2026
Demoting, it doesn't block the user.
[-]Reports - Week, Year and Quarter column can be unselected[/-][+][Due for Payment 2026-02-12] Reports - Week, Year and Quarter column can be unselected[/+]trjExpensify commentedon Feb 12, 2026
Payment summary as follows:
Go ahead and request, closing!
garrettmknight commentedon Apr 2, 2026
$250 approved for @shubham1206agra