You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[due for payment] Workspaces page - Domain control banner uses wrong background color #81180
Version Number: 9.3.11-17 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from BrowserStack: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by:@shawnborton Slack conversation (hyperlinked to channel name): expensify_bugs
Please re-state the problem that we are trying to solve in this issue.
Actual Result: Domain control banner uses wrong background color.
What is the root cause of that problem?
In DomainsEmptyStateComponent.tsx, the banner is using styles.hoveredComponentBG which applies theme.hoverComponentBG color. However, it should use theme.cardBG to match the standard card background color.
🚨 Edited by proposal-police: This proposal was edited at 2026-02-02 14:41:59 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
On the Workspaces page, the domain control banner (the "Enhanced Security" empty state banner shown when no domains are configured) uses a background color that does not match the standard cardBG color. The banner appears darker than it should, creating a visual inconsistency with the rest of the page.
What is the root cause of that problem?
The DomainsEmptyStateComponent renders a BillingBanner and passes styles.hoveredComponentBG as part of the style override on line 24.
The hoveredComponentBG style sets backgroundColor to theme.hoverComponentBG, which maps to colors.productLight300 (#F2EDE7) in the light theme and colors.productDark300 (#0A2E25) in the dark theme.
However, the expected cardBG color maps to colors.productLight200 (#F8F4F0) in the light theme and colors.productDark200 (#072419) in the dark theme. The productLight300/productDark300 values are one shade darker than the correct productLight200/productDark200, which is why the banner background appears noticeably different from the standard card background.
What changes do you think we should make in order to solve the problem?
In src/components/DomainsEmptyStateComponent.tsx, we should replace styles.hoveredComponentBG with styles.highlightBG on line 24. The highlightBG style applies backgroundColor: theme.highlightBG, and theme.highlightBG maps to the same color values as theme.cardBG (productLight200 / productDark200) in both light and dark themes.
This is a single-word change on one line: styles.hoveredComponentBG becomes styles.highlightBG. The BillingBanner default background (trialBannerBackgroundColor, a green shade) is already overridden by the style prop, so this swap correctly applies the lighter cardBG-equivalent background. The borderRadiusComponentLarge style on the same line remains unchanged.
What alternative solutions did you explore? (Optional)
Please re-state the problem that we are trying to solve in this issue.
The Workspaces page “Domains” / “Enhanced security” banner renders with the wrong background color, which creates a visual mismatch compared to the standard card background used elsewhere.
What is the root cause of that problem?
In this implementation, the DomainsEmptyStateComponent uses the shared BillingBanner but assumes that styles.hoveredComponentBG is the correct background style, while the banner is expected to match the standard card background; this incorrect assumption is made in src/components/DomainsEmptyStateComponent.tsx inside the DomainsEmptyStateComponent function, and because the caller controls the style prop passed into BillingBanner, this choice directly causes the banner background to diverge from theme.cardBG.
What changes do you think we should make in order to solve the problem?
The invariant being enforced is that the Domain control banner background must equal the standard card background color, which is theme.cardBG.
Ownership stays in the domain empty-state UI, since it decides how the banner should look.
The smallest and lowest-risk change is to update the caller to explicitly request the card background using existing style utilities, without changing BillingBanner.
Function / component being modified:
DomainsEmptyStateComponent
Scope size:
One file, with a small import addition and a single style change in the component body.
Proposed change (verbatim patch for that file):
// File: src/components/DomainsEmptyStateComponent.tsx// Add the following imports near the top of the fileimportuseThemefrom'@hooks/useTheme';importuseStyleUtilsfrom'@hooks/useStyleUtils';// Inside the DomainsEmptyStateComponent function, replace the existing style usage with StyleUtils/theme:// (showing the function body with the minimal edits)functionDomainsEmptyStateComponent(){const{asset: BlueShield}=useMemoizedLazyAsset(()=>loadIllustration('BlueShield'));conststyles=useThemeStyles();const{translate}=useLocalize();// NEW: use the style utils and theme to get cardBG background styleconstStyleUtils=useStyleUtils();consttheme=useTheme();return(<Viewstyle={styles.ph5}><BillingBannericon={BlueShield}title={translate('domain.enhancedSecurity.title')}subtitle={translate('domain.enhancedSecurity.subtitle')}subtitleStyle={[styles.textLabelSupporting,styles.pt1]}// CHANGED: use cardBG explicitly instead of hoveredComponentBGstyle={[styles.borderRadiusComponentLarge,StyleUtils.getBackgroundColorStyle(theme.cardBG)]}rightComponent={<Buttontext={translate('domain.enhancedSecurity.enable')}successonPress={()=>Navigation.navigate(ROUTES.WORKSPACES_ADD_DOMAIN)}/>}/></View>);}
This change is localized to the domain empty-state UI.
BillingBanner remains unchanged, so other banners keep their current behavior.
Regression risk is minimal because only one component and one visual style are affected.
What alternative solutions did you explore? (Optional)
Modifying BillingBanner defaults or adding new variant props was explored but rejected because it would affect many other banners and increase risk.
Changing theme tokens globally was also rejected because it could cause unintended visual changes across the app.
⚠️@twinkle-react Your proposal is a duplicate of an already existing proposal and has been automatically withdrawn to prevent spam. Please review the existing proposals before submitting a new one.
Please re-state the problem that we are trying to solve in this issue.
On the Workspaces tab, the Domain control banner (the “enhanced security” / Domains empty-state banner) uses the wrong background color. It should match the standard cardBG color used elsewhere for cards and banners.
What is the root cause of that problem?
The banner is rendered by DomainsEmptyStateComponent, which uses BillingBanner with a style that includes hoveredComponentBG. That gives the banner a different background than the standard cardBG, so it does not match other cards on the page.
What changes do you think we should make in order to solve the problem?
In DomainsEmptyStateComponent, change the BillingBanner container style from hoveredComponentBG to getBackgroundColorStyle(theme.cardBG) so the Domain control banner uses the standard card background color. Keep borderRadiusComponentLarge as is.
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
⚠️@samranahm Your proposal is a duplicate of an already existing proposal and has been automatically withdrawn to prevent spam. Please review the existing proposals before submitting a new one.
changed the title [-]Workspaces page - Domain control banner uses wrong background color[/-][+][due for payment] Workspaces page - Domain control banner uses wrong background color[/+]on Feb 16, 2026
Activity
melvin-bot commentedon Feb 2, 2026
Triggered auto assignment to Contributor-plus team member for initial proposal review - @ZhenjaHorbach (
External)melvin-bot commentedon Feb 2, 2026
Triggered auto assignment to @joekaufmanexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.daledah commentedon Feb 2, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
Actual Result: Domain control banner uses wrong background color.
What is the root cause of that problem?
In
DomainsEmptyStateComponent.tsx, the banner is usingstyles.hoveredComponentBGwhich appliestheme.hoverComponentBGcolor. However, it should usetheme.cardBGto match the standard card background color.App/src/components/DomainsEmptyStateComponent.tsx
Line 24 in bfc6781
What changes do you think we should make in order to solve the problem?
Update
DomainsEmptyStateComponent.tsxto usetheme.cardBGinstead ofstyles.hoveredComponentBG:What alternative solutions did you explore? (Optional)
N/A
MobileMage commentedon Feb 2, 2026
🚨 Edited by proposal-police: This proposal was edited at 2026-02-02 14:41:59 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
On the Workspaces page, the domain control banner (the "Enhanced Security" empty state banner shown when no domains are configured) uses a background color that does not match the standard
cardBGcolor. The banner appears darker than it should, creating a visual inconsistency with the rest of the page.What is the root cause of that problem?
The
DomainsEmptyStateComponentrenders aBillingBannerand passesstyles.hoveredComponentBGas part of the style override on line 24.App/src/components/DomainsEmptyStateComponent.tsx
Lines 19 to 33 in 6c1a24c
The
hoveredComponentBGstyle setsbackgroundColortotheme.hoverComponentBG, which maps tocolors.productLight300(#F2EDE7) in the light theme andcolors.productDark300(#0A2E25) in the dark theme.App/src/styles/index.ts
Lines 942 to 944 in 6c1a24c
However, the expected
cardBGcolor maps tocolors.productLight200(#F8F4F0) in the light theme andcolors.productDark200(#072419) in the dark theme. TheproductLight300/productDark300values are one shade darker than the correctproductLight200/productDark200, which is why the banner background appears noticeably different from the standard card background.What changes do you think we should make in order to solve the problem?
In
src/components/DomainsEmptyStateComponent.tsx, we should replacestyles.hoveredComponentBGwithstyles.highlightBGon line 24. ThehighlightBGstyle appliesbackgroundColor: theme.highlightBG, andtheme.highlightBGmaps to the same color values astheme.cardBG(productLight200/productDark200) in both light and dark themes.App/src/styles/index.ts
Lines 380 to 382 in 6c1a24c
App/src/styles/theme/themes/light.ts
Line 10 in 6c1a24c
App/src/styles/theme/themes/light.ts
Line 65 in 6c1a24c
This is a single-word change on one line:
styles.hoveredComponentBGbecomesstyles.highlightBG. TheBillingBannerdefault background (trialBannerBackgroundColor, a green shade) is already overridden by the style prop, so this swap correctly applies the lightercardBG-equivalent background. TheborderRadiusComponentLargestyle on the same line remains unchanged.What alternative solutions did you explore? (Optional)
N/A
twinkle-react commentedon Feb 2, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
The Workspaces page “Domains” / “Enhanced security” banner renders with the wrong background color, which creates a visual mismatch compared to the standard card background used elsewhere.
What is the root cause of that problem?
In this implementation, the DomainsEmptyStateComponent uses the shared BillingBanner but assumes that styles.hoveredComponentBG is the correct background style, while the banner is expected to match the standard card background; this incorrect assumption is made in src/components/DomainsEmptyStateComponent.tsx inside the DomainsEmptyStateComponent function, and because the caller controls the style prop passed into BillingBanner, this choice directly causes the banner background to diverge from theme.cardBG.
What changes do you think we should make in order to solve the problem?
The invariant being enforced is that the Domain control banner background must equal the standard card background color, which is theme.cardBG.
Ownership stays in the domain empty-state UI, since it decides how the banner should look.
The smallest and lowest-risk change is to update the caller to explicitly request the card background using existing style utilities, without changing BillingBanner.
File(s) changed:
src/components/DomainsEmptyStateComponent.tsx
Function / component being modified:
DomainsEmptyStateComponent
Scope size:
One file, with a small import addition and a single style change in the component body.
Proposed change (verbatim patch for that file):
This change is localized to the domain empty-state UI.
BillingBanner remains unchanged, so other banners keep their current behavior.
Regression risk is minimal because only one component and one visual style are affected.
What alternative solutions did you explore? (Optional)
Modifying BillingBanner defaults or adding new variant props was explored but rejected because it would affect many other banners and increase risk.
Changing theme tokens globally was also rejected because it could cause unintended visual changes across the app.
github-actions commentedon Feb 2, 2026
samranahm commentedon Feb 2, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
On the Workspaces tab, the Domain control banner (the “enhanced security” / Domains empty-state banner) uses the wrong background color. It should match the standard cardBG color used elsewhere for cards and banners.
What is the root cause of that problem?
The banner is rendered by
DomainsEmptyStateComponent, which uses BillingBanner with a style that includeshoveredComponentBG. That gives the banner a different background than the standardcardBG, so it does not match other cards on the page.What changes do you think we should make in order to solve the problem?
In
DomainsEmptyStateComponent, change the BillingBanner container style fromhoveredComponentBGtogetBackgroundColorStyle(theme.cardBG)so the Domain control banner uses the standard card background color. KeepborderRadiusComponentLargeas is.here
App/src/components/DomainsEmptyStateComponent.tsx
Line 24 in cd96f78
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
Results
github-actions commentedon Feb 2, 2026
19 remaining items
joekaufmanexpensify commentedon Feb 9, 2026
@hungvu193 I'm not seeing you as a reviewer of #81189, is that the one you were referring to?
ZhenjaHorbach commentedon Feb 9, 2026
I'm a reviewer here 😅
hungvu193 commentedon Feb 9, 2026
I dont think so 😅
joekaufmanexpensify commentedon Feb 16, 2026
My bad! The color palette of your GH profile images is similar 😄
joekaufmanexpensify commentedon Feb 16, 2026
I will handle your payment for #81189 today @ZhenjaHorbach
[-]Workspaces page - Domain control banner uses wrong background color[/-][+][due for payment] Workspaces page - Domain control banner uses wrong background color[/+]joekaufmanexpensify commentedon Feb 16, 2026
Payment Summary
joekaufmanexpensify commentedon Feb 16, 2026
@ZhenjaHorbach please request payment at your earliest convenience. Closing as this is otherwise all set 👍
garrettmknight commentedon Feb 20, 2026
$250 approved for @ZhenjaHorbach