You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Version Number: 9.3.11-17 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from BrowserStack: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by:@quinthar Slack conversation (hyperlinked to channel name): #Migrate
Action Performed:
Navigate to an expense report as approver
Click More > Hold an expense
Observe the copy
Click More > Reject an expense
Observe the copy
Expected Result:
Hold copy = Explain what you need before approving this expense.
Reject copy = Explain why you will not approve this expense.
Actual Result:
Current Hold copy = Explain why you're holding this expense.
Current Reject copy = Explain why you're rejecting this expense.
Workaround:
Unknown
Platforms:
Select the officially supported platforms where the issue was reproduced:
other: "Explain why you're holding these expenses.",
}),
explainHold: () => ({
- one: "Explain why you're holding this expense.",- other: "Explain why you're holding these expenses.",+ one: 'Explain what you need before approving this expense.',+ other: 'Explain what you need before approving these expenses.',
}),
one: 'Explica la razón para retener esta solicitud.',
other: 'Explica la razón para retener estas solicitudes.',
}),
explainHold: () => ({
- one: 'Explica la razón para retener esta solicitud.',- other: 'Explica la razón para retener estas solicitudes.',+ one: 'Explica lo que necesitas antes de aprobar este gasto.',+ other: 'Explica lo que necesitas antes de aprobar estos gastos.',
}),
Please re-state the problem that we are trying to solve in this issue.
The copy shown on the Hold and Reject reason pages is wrong, because Hold and Reject both show generic explanations instead of clear action-specific guidance for what the user should write.
What is the root cause of that problem?
In this issue, the earliest wrong assumption is that the shared English localization strings already contain correct action-specific text, but in src/languages/en.ts the keys explainHold and reject.reasonPageDescription are set to generic wording, so every caller that reads these values shows the wrong copy.
What changes do you think we should make in order to solve the problem?
We should fix the shared localization strings, because this file owns the UI copy and all callers depend on it.
Current code:
// File: src/languages/en.ts// Lines 1409-1412explainHold: ()=>({one: "Explain why you're holding this expense.",other: "Explain why you're holding these expenses.",}),
// File: src/languages/en.tsexplainHold: ()=>({one: 'Explain what you need before approving this expense.',other: 'Explain what you need before approving these expenses.',}),
// File: src/languages/en.tsreasonPageTitle: 'Reject expense',reasonPageDescription: 'Explain why you will not approve this expense.',rejectReason: 'Rejection reason',
What alternative solutions did you explore? (Optional)
Overriding the text in each component was considered, but rejected because it would duplicate copy logic and break the single source of truth for localization.
This ticket will update the hold copy in the below screen based on whether the user is a submitter or an approver:
Submitter: "Explain why you're holding this expense." (unchanged — submitters hold to pause before submitting)
Approver: "Explain what you need before approving this expense." (new — guides approvers to request specific information)
Question
In Search, users can bulk hold expenses where they are both the submitter and the approver.
In this case, which text should be shown on the Hold Reason page?
P.S @shawnborton we had to take the product team off the /product-pr handle to facilitate the round-robin PR assignment, so /product is the one to tag to notify us now. (I'm still on /design so caught this one. 😅).
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
Activity
melvin-bot commentedon Feb 2, 2026
Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale (
External)melvin-bot commentedon Feb 2, 2026
Triggered auto assignment to @garrettmknight (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.TaduJR commentedon Feb 2, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
When an approver clicks "Hold an expense" or "Reject an expense" from the More menu, the current messaging is not explicit enough:
Expected messaging:
What is the root cause of that problem?
The translation strings use passive language that doesn't clearly communicate the purpose of each action to approvers.
Hold expense flow:
HoldReasonFormView.tsxrenders the description fromexplainHoldtranslation:App/src/pages/iou/HoldReasonFormView.tsx
Line 56 in b584a9d
explainHoldstring inen.ts:App/src/languages/en.ts
Lines 1409 to 1412 in b584a9d
Reject expense flow:
RejectReasonFormView.tsxrenders thereasonPageDescriptiontranslation:App/src/pages/iou/RejectReasonFormView.tsx
Line 55 in b584a9d
reasonPageDescriptionstring inen.ts:App/src/languages/en.ts
Line 1505 in b584a9d
What changes do you think we should make in order to solve the problem?
Update the translation strings in all language files.
1. src/languages/en.ts
App/src/languages/en.ts
Lines 1409 to 1412 in b584a9d
explainHold: () => ({ - one: "Explain why you're holding this expense.", - other: "Explain why you're holding these expenses.", + one: 'Explain what you need before approving this expense.', + other: 'Explain what you need before approving these expenses.', }),App/src/languages/en.ts
Line 1505 in b584a9d
2. src/languages/es.ts
App/src/languages/es.ts
Lines 1152 to 1155 in b584a9d
explainHold: () => ({ - one: 'Explica la razón para retener esta solicitud.', - other: 'Explica la razón para retener estas solicitudes.', + one: 'Explica lo que necesitas antes de aprobar este gasto.', + other: 'Explica lo que necesitas antes de aprobar estos gastos.', }),App/src/languages/es.ts
Line 1250 in b584a9d
3. Other language files - Apply equivalent translations for:
de.ts(German)fr.ts(French)it.ts(Italian)ja.ts(Japanese)nl.ts(Dutch)pl.ts(Polish)pt-BR.ts(Portuguese)zh-hans.ts(Chinese)twinkle-react commentedon Feb 3, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
The copy shown on the Hold and Reject reason pages is wrong, because Hold and Reject both show generic explanations instead of clear action-specific guidance for what the user should write.
What is the root cause of that problem?
In this issue, the earliest wrong assumption is that the shared English localization strings already contain correct action-specific text, but in
src/languages/en.tsthe keysexplainHoldandreject.reasonPageDescriptionare set to generic wording, so every caller that reads these values shows the wrong copy.What changes do you think we should make in order to solve the problem?
We should fix the shared localization strings, because this file owns the UI copy and all callers depend on it.
Current code:
Proposed replacement:
What alternative solutions did you explore? (Optional)
Overriding the text in each component was considered, but rejected because it would duplicate copy logic and break the single source of truth for localization.
akinwale commentedon Feb 3, 2026
This is a fairly straightforward copy-change, so we can go with the first proposal which belongs to @TaduJR.
🎀👀🎀 C+ reviewed.
melvin-bot commentedon Feb 3, 2026
Triggered auto assignment to @srikarparsi, see https://stackoverflow.com/c/expensify/questions/7972 for more details.
21 remaining items
TaduJR commentedon Feb 19, 2026
Hi @srikarparsi
@jamesdeanexpensify suggested this https://expensify.slack.com/archives/C01GTK53T8Q/p1771446972482209?thread_ts=1771440128.761189&cid=C01GTK53T8Q
Can you check it out?
Thanks!
truph01 commentedon Feb 24, 2026
@Expensify/design
Context
This ticket will update the hold copy in the below screen based on whether the user is a submitter or an approver:
Question
In Search, users can bulk hold expenses where they are both the submitter and the approver.
In this case, which text should be shown on the Hold Reason page?
shawnborton commentedon Feb 24, 2026
Hmm in that case, I would lean on the more generic case of "Explain why you're holding this expense." but cc @Expensify/product-pr for thoughts!
TaduJR commentedon Feb 25, 2026
Applied on the PR.
trjExpensify commentedon Feb 27, 2026
Agreed.
P.S @shawnborton we had to take the product team off the
/product-prhandle to facilitate the round-robin PR assignment, so/productis the one to tag to notify us now. (I'm still on/designso caught this one. 😅).shawnborton commentedon Feb 27, 2026
Ah good to know! I like the simplicity :)
melvin-bot commentedon Mar 9, 2026
This issue has not been updated in over 15 days. @garrettmknight, @srikarparsi, @TaduJR, @truph01 eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
mallenexpensify commentedon Mar 24, 2026
Payment Summary
Contributor: @TaduJR paid $250 via Upwork
Contributor+: @truph01 due $250 via NewDot
@TaduJR can you please accept the job below? Please reply here and tag me once you have.
https://www.upwork.com/jobs/~022036583413451383447
mallenexpensify commentedon Mar 25, 2026
@TaduJR paid, summary updated above. Thx.
JmillsExpensify commentedon Apr 5, 2026
$250 approved for @truph01