Skip to content

Make Reject / Hold Messaging More Explicit #81216

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.11-17
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from BrowserStack:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @quinthar
Slack conversation (hyperlinked to channel name): #Migrate

Action Performed:

  1. Navigate to an expense report as approver
  2. Click More > Hold an expense
  3. Observe the copy
  4. Click More > Reject an expense
  5. Observe the copy

Expected Result:

Hold copy =  Explain what you need before approving this expense.
Reject copy = Explain why you will not approve this expense.

Actual Result:

Current Hold copy = Explain why you're holding this expense.
Current Reject copy = Explain why you're rejecting this expense.

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Image Image

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @srikarparsi

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 2, 2026
  2. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 2, 2026
  3. melvin-bot commented on Feb 2, 2026

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale (External)

  4. melvin-bot commented on Feb 2, 2026

    @melvin-bot

    Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. TaduJR commented on Feb 2, 2026

    @TaduJR
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    When an approver clicks "Hold an expense" or "Reject an expense" from the More menu, the current messaging is not explicit enough:

    • Hold: "Explain why you're holding this expense."
    • Reject: "Explain why you're rejecting this expense."

    Expected messaging:

    • Hold: "Explain what you need before approving this expense."
    • Reject: "Explain why you will not approve this expense."

    What is the root cause of that problem?

    The translation strings use passive language that doesn't clearly communicate the purpose of each action to approvers.

    Hold expense flow:

    1. User navigates to expense report as approver
    2. Clicks More > Hold an expense
    3. HoldReasonFormView.tsx renders the description from explainHold translation:

    <Text style={styles.mb6}>{translate('iou.explainHold', {count: expenseCount})}</Text>

    1. Current explainHold string in en.ts:

    App/src/languages/en.ts

    Lines 1409 to 1412 in b584a9d

    explainHold: () => ({
    one: "Explain why you're holding this expense.",
    other: "Explain why you're holding these expenses.",
    }),

    Reject expense flow:

    1. User navigates to expense report as approver
    2. Clicks More > Reject an expense
    3. RejectReasonFormView.tsx renders the reasonPageDescription translation:

    <Text>{translate('iou.reject.reasonPageDescription')}</Text>

    1. Current reasonPageDescription string in en.ts:

    reasonPageDescription: "Explain why you're rejecting this expense.",

    What changes do you think we should make in order to solve the problem?

    Update the translation strings in all language files.

    1. src/languages/en.ts

    App/src/languages/en.ts

    Lines 1409 to 1412 in b584a9d

    explainHold: () => ({
    one: "Explain why you're holding this expense.",
    other: "Explain why you're holding these expenses.",
    }),

             explainHold: () => ({
    -            one: "Explain why you're holding this expense.",
    -            other: "Explain why you're holding these expenses.",
    +            one: 'Explain what you need before approving this expense.',
    +            other: 'Explain what you need before approving these expenses.',
             }),

    reasonPageDescription: "Explain why you're rejecting this expense.",

    -            reasonPageDescription: "Explain why you're rejecting this expense.",
    +            reasonPageDescription: 'Explain why you will not approve this expense.',

    2. src/languages/es.ts

    App/src/languages/es.ts

    Lines 1152 to 1155 in b584a9d

    explainHold: () => ({
    one: 'Explica la razón para retener esta solicitud.',
    other: 'Explica la razón para retener estas solicitudes.',
    }),

             explainHold: () => ({
    -            one: 'Explica la razón para retener esta solicitud.',
    -            other: 'Explica la razón para retener estas solicitudes.',
    +            one: 'Explica lo que necesitas antes de aprobar este gasto.',
    +            other: 'Explica lo que necesitas antes de aprobar estos gastos.',
             }),

    reasonPageDescription: 'Explica por qué estás rechazando este gasto.',

    -            reasonPageDescription: 'Explica por qué estás rechazando este gasto.',
    +            reasonPageDescription: 'Explica por qué no aprobarás este gasto.',

    3. Other language files - Apply equivalent translations for:

    • de.ts (German)
    • fr.ts (French)
    • it.ts (Italian)
    • ja.ts (Japanese)
    • nl.ts (Dutch)
    • pl.ts (Polish)
    • pt-BR.ts (Portuguese)
    • zh-hans.ts (Chinese)
  6. twinkle-react commented on Feb 3, 2026

    @twinkle-react

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    The copy shown on the Hold and Reject reason pages is wrong, because Hold and Reject both show generic explanations instead of clear action-specific guidance for what the user should write.

    What is the root cause of that problem?

    In this issue, the earliest wrong assumption is that the shared English localization strings already contain correct action-specific text, but in src/languages/en.ts the keys explainHold and reject.reasonPageDescription are set to generic wording, so every caller that reads these values shows the wrong copy.

    What changes do you think we should make in order to solve the problem?

    We should fix the shared localization strings, because this file owns the UI copy and all callers depend on it.

    Current code:

    // File: src/languages/en.ts
    // Lines 1409-1412
    explainHold: () => ({
        one: "Explain why you're holding this expense.",
        other: "Explain why you're holding these expenses.",
    }),
    // File: src/languages/en.ts
    // Lines 1503-1506
    reasonPageTitle: 'Reject expense',
    reasonPageDescription: "Explain why you're rejecting this expense.",
    rejectReason: 'Rejection reason',

    Proposed replacement:

    // File: src/languages/en.ts
    explainHold: () => ({
        one: 'Explain what you need before approving this expense.',
        other: 'Explain what you need before approving these expenses.',
    }),
    // File: src/languages/en.ts
    reasonPageTitle: 'Reject expense',
    reasonPageDescription: 'Explain why you will not approve this expense.',
    rejectReason: 'Rejection reason',

    What alternative solutions did you explore? (Optional)

    Overriding the text in each component was considered, but rejected because it would duplicate copy logic and break the single source of truth for localization.

  7. akinwale commented on Feb 3, 2026

    @akinwale
    Contributor

    This is a fairly straightforward copy-change, so we can go with the first proposal which belongs to @TaduJR.

    🎀👀🎀 C+ reviewed.

  8. melvin-bot commented on Feb 3, 2026

    @melvin-bot

    Triggered auto assignment to @srikarparsi, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

  9. 21 remaining items

  10. TaduJR commented on Feb 19, 2026

    @TaduJR
    Contributor
  11. truph01 commented on Feb 24, 2026

    @truph01
    Contributor

    @Expensify/design


    Context

    This ticket will update the hold copy in the below screen based on whether the user is a submitter or an approver:

    Submitter: "Explain why you're holding this expense." (unchanged — submitters hold to pause before submitting)
    Approver: "Explain what you need before approving this expense." (new — guides approvers to request specific information)

    Image

    Question

    In Search, users can bulk hold expenses where they are both the submitter and the approver.

    In this case, which text should be shown on the Hold Reason page?

  12. shawnborton commented on Feb 24, 2026

    @shawnborton
    Contributor

    Hmm in that case, I would lean on the more generic case of "Explain why you're holding this expense." but cc @Expensify/product-pr for thoughts!

  13. TaduJR commented on Feb 25, 2026

    @TaduJR
    Contributor

    Hmm in that case, I would lean on the more generic case of "Explain why you're holding this expense." but cc @Expensify/product-pr for thoughts!

    Applied on the PR.

  14. trjExpensify commented on Feb 27, 2026

    @trjExpensify
    Contributor

    Agreed.

    P.S @shawnborton we had to take the product team off the /product-pr handle to facilitate the round-robin PR assignment, so /product is the one to tag to notify us now. (I'm still on /design so caught this one. 😅).

  15. shawnborton commented on Feb 27, 2026

    @shawnborton
    Contributor

    Ah good to know! I like the simplicity :)

  16. melvin-bot commented on Mar 9, 2026

    @melvin-bot

    This issue has not been updated in over 15 days. @garrettmknight, @srikarparsi, @TaduJR, @truph01 eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

  17. mallenexpensify commented on Mar 24, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor: @TaduJR paid $250 via Upwork
    Contributor+: @truph01 due $250 via NewDot

    @TaduJR can you please accept the job below? Please reply here and tag me once you have.
    https://www.upwork.com/jobs/~022036583413451383447

  18. mallenexpensify commented on Mar 25, 2026

    @mallenexpensify
    Contributor

    @TaduJR paid, summary updated above. Thx.

  19. moved this from MEDIUM or LOW to Done in [#whatsnext] #migrateon Mar 25, 2026
  20. JmillsExpensify commented on Apr 5, 2026

    @JmillsExpensify
    Contributor

    $250 approved for @truph01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorMonthlyKSv2ReviewingHas a PR in review

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions