You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$250] Web - Onboarding modal - The modal disappears after a page reload #81249
Version Number: v9.3.11-23 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack:https://test-management.browserstack.com/projects/2219752/folder/13176677/test-cases/41237662 Email or phone of affected tester (no customers): N/A Issue reported by: Applause Internal Team Bug source: Regression TC Execution Device used: Windows 11, Chrome | iPhone SE 3rd generation, iOS 26.6.2, Chrome | Samsung A15, Android 16, Chrome App Component: Other
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #80965 - "[Home Page] Remove Beta Gate for Release 1" by @WojtekBoman (High confidence) Related Issues: None
Recommendation: REVERT
PR #80965 introduced a navigation regression that breaks onboarding modal state restoration on page refresh. The change is in a critical navigation path and reverting is the safest option.
Labels: Removing DeployBlocker label (this is a frontend issue, not a backend issue)
📋 Detailed Analysis
Evidence
The bug occurs when users refresh the page during the onboarding flow. The onboarding modal disappears instead of remaining visible on the current step. This is reproducible on staging (v9.3.11-23) but not in production, indicating it was introduced in a PR that is currently on staging.
PR #80965 made changes to src/libs/Navigation/helpers/getAdaptedStateFromPath.ts that directly affect how the navigation state is restored when opening onboarding screens after a page reload.
Verification
The specific change in PR #80965 at line 247 of getAdaptedStateFromPath.ts:
This change replaced the dynamically determined defaultFullScreenRoute with a hardcoded {name: SCREENS.HOME}. The problem is that SCREENS.HOME by itself is not a valid full-screen navigator route in the new navigation structure introduced by the Home Page changes.
Root Cause
When a user refreshes the browser during onboarding (e.g., at step "Do you use any accounting software?"), the app attempts to restore the navigation state through getAdaptedStateFromPath(). The function detects the onboarding navigator and tries to rebuild the state with a base route.
However, the hardcoded {name: SCREENS.HOME} doesn't provide the proper navigation structure needed for the onboarding modal to display. The defaultFullScreenRoute function would have returned a proper navigator (like NAVIGATORS.REPORTS_SPLIT_NAVIGATOR) with the correct nested structure, but the hardcoded value breaks this.
As a result, the navigation state becomes invalid, and the onboarding modal fails to render after the page reload, appearing as if it "disappears."
Why Revert
This affects a critical user flow (onboarding) that impacts all new users
Please re-state the problem that we are trying to solve in this issue.
On web (staging), during the onboarding flow, refreshing the page causes the onboarding modal to disappear instead of staying open on the current step. For example, at the "Do you use any accounting software?" step, after reload the user is no longer shown the onboarding modal and cannot continue.
What is the root cause of that problem?
A navigation state restoration regression was introduced by PR #80965 in src/libs/Navigation/helpers/getAdaptedStateFromPath.ts. When the user refreshes mid-onboarding, the app relies on getAdaptedStateFromPath() to rebuild a valid React Navigation state that includes the onboarding navigator. The recent change hardcoded a base route to {name: SCREENS.HOME} instead of using the existing defaultFullScreenRoute, which provided a valid full-screen navigator route. With the hardcoded leaf screen as the base, the onboarding modal route tree becomes invalid/incomplete after reload, and the modal does not render.
What changes do you think we should make in order to solve the problem?
In src/libs/Navigation/helpers/getAdaptedStateFromPath.ts, locate the block that returns the adapted state when the onboarding navigator is present. Replace the hardcoded {name: SCREENS.HOME} base route with the correct full-screen route object (revert to using defaultFullScreenRoute or construct the equivalent valid root navigator route). Ensure the returned routes are passed through getRoutesWithIndex() correctly so indices are valid. Add a regression test that feeds an onboarding path into getAdaptedStateFromPath() and asserts the resulting state includes the onboarding navigator with a valid full-screen base route.
Activity
melvin-bot commentedon Feb 3, 2026
Triggered auto assignment to @mallenexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Feb 3, 2026
Triggered auto assignment to @Gonals (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Feb 3, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Feb 3, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon Feb 3, 2026
🔍 Investigation Summary
Classification: Frontend bug
Causing PR: #80965 - "[Home Page] Remove Beta Gate for Release 1" by @WojtekBoman (High confidence)
Related Issues: None
Recommendation: REVERT
PR #80965 introduced a navigation regression that breaks onboarding modal state restoration on page refresh. The change is in a critical navigation path and reverting is the safest option.
Labels: Removing DeployBlocker label (this is a frontend issue, not a backend issue)
📋 Detailed Analysis
Evidence
The bug occurs when users refresh the page during the onboarding flow. The onboarding modal disappears instead of remaining visible on the current step. This is reproducible on staging (v9.3.11-23) but not in production, indicating it was introduced in a PR that is currently on staging.
PR #80965 made changes to
src/libs/Navigation/helpers/getAdaptedStateFromPath.tsthat directly affect how the navigation state is restored when opening onboarding screens after a page reload.Verification
The specific change in PR #80965 at line 247 of
getAdaptedStateFromPath.ts:Before:
After:
This change replaced the dynamically determined
defaultFullScreenRoutewith a hardcoded{name: SCREENS.HOME}. The problem is thatSCREENS.HOMEby itself is not a valid full-screen navigator route in the new navigation structure introduced by the Home Page changes.Root Cause
When a user refreshes the browser during onboarding (e.g., at step "Do you use any accounting software?"), the app attempts to restore the navigation state through
getAdaptedStateFromPath(). The function detects the onboarding navigator and tries to rebuild the state with a base route.However, the hardcoded
{name: SCREENS.HOME}doesn't provide the proper navigation structure needed for the onboarding modal to display. ThedefaultFullScreenRoutefunction would have returned a proper navigator (likeNAVIGATORS.REPORTS_SPLIT_NAVIGATOR) with the correct nested structure, but the hardcoded value breaks this.As a result, the navigation state becomes invalid, and the onboarding modal fails to render after the page reload, appearing as if it "disappears."
Why Revert
18 remaining items
jponikarchuk commentedon Feb 6, 2026
This issue is still reproducible for QA team in build 9.3.15-1 on Web
explorer_uDG5RBEJAO.mp4
adamgrzybowski commentedon Feb 6, 2026
This seems to be related to the #81523
The issue mentioned above is not always reproducible, so make sure to test at least a few times.
cc: @WojtekBoman
Harmatta commentedon Feb 7, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
On web (staging), during the onboarding flow, refreshing the page causes the onboarding modal to disappear instead of staying open on the current step. For example, at the "Do you use any accounting software?" step, after reload the user is no longer shown the onboarding modal and cannot continue.
What is the root cause of that problem?
A navigation state restoration regression was introduced by PR #80965 in
src/libs/Navigation/helpers/getAdaptedStateFromPath.ts. When the user refreshes mid-onboarding, the app relies ongetAdaptedStateFromPath()to rebuild a valid React Navigation state that includes the onboarding navigator. The recent change hardcoded a base route to{name: SCREENS.HOME}instead of using the existingdefaultFullScreenRoute, which provided a valid full-screen navigator route. With the hardcoded leaf screen as the base, the onboarding modal route tree becomes invalid/incomplete after reload, and the modal does not render.What changes do you think we should make in order to solve the problem?
In
src/libs/Navigation/helpers/getAdaptedStateFromPath.ts, locate the block that returns the adapted state when the onboarding navigator is present. Replace the hardcoded{name: SCREENS.HOME}base route with the correct full-screen route object (revert to usingdefaultFullScreenRouteor construct the equivalent valid root navigator route). Ensure the returned routes are passed throughgetRoutesWithIndex()correctly so indices are valid. Add a regression test that feeds an onboarding path intogetAdaptedStateFromPath()and asserts the resulting state includes the onboarding navigator with a valid full-screen base route.cc: @Harmatta (storefile996@gmail.com / https://www.upwork.com/freelancers/~01184f546f3a74ab48)
melvin-bot commentedon Feb 13, 2026
@mallenexpensify, @mountiny, @WojtekBoman, @adamgrzybowski, @DylanDylann Huh... This is 4 days overdue. Who can take care of this?
mountiny commentedon Feb 15, 2026
@adamgrzybowski @WojtekBoman Can you work on this one next please?
WojtekBoman commentedon Feb 16, 2026
We'll check it out 🕵️
WojtekBoman commentedon Feb 16, 2026
It has been fixed by this PR #81690
It's not reproducible for me:
Screen.Recording.2026-02-16.at.14.05.16.mov
@jponikarchuk Should work fine now :)
m-natarajan commentedon Feb 16, 2026
Passed, Chrome / v9.3.19-5
Screen.Recording.2026-02-16.at.16.05.44.mp4
mountiny commentedon Feb 16, 2026
Perfect thank you