Skip to content

[HOLD for payment 2022-04-27] [$500] Pdf preview is not in centered - reported by @thesahindia #8127

Closed

Description

@mvtglobally

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to Chat
  2. Try sending the pdf given in thread
  3. See if it's in center

Expected Result:

Preview should be in center.

Actual Result:

Preview is not in centered

Workaround:

unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.42-3
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Screenshot 2022-03-02 at 12.16.41 AM.pdf
Screenshot_2022_0302_001857
Screenshot_20220302_002001

Issue reported by: @thesahindia
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1646160975698469

Job Post: https://www.upwork.com/jobs/~0154111729e0a5dbd4

View all open jobs on GitHub

Activity

  1. MelvinBot commented on Mar 14, 2022

    @MelvinBot
    Contributor

    Triggered auto assignment to @kevinksullivan (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

  2. removed
    AutoAssignerTriageAuto assign issues for triage to an available triage team member
    on Mar 14, 2022
  3. MelvinBot commented on Mar 14, 2022

    @MelvinBot
    Contributor

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (Exported)

  4. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Mar 14, 2022
  5. MelvinBot commented on Mar 14, 2022

    @MelvinBot
    Contributor

    Triggered auto assignment to @luacmartins (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

  6. kevinksullivan commented on Mar 14, 2022

    @kevinksullivan
    Contributor

    @thesahindia please apply when you get a chance!

  7. changed the title [-]Pdf preview is not in centered - reported by @thesahindia[/-] [+][$500] Pdf preview is not in centered - reported by @thesahindia[/+] on Mar 22, 2022
  8. 26 remaining items

  9. Santhosh-Sellavel commented on Apr 2, 2022

    @Santhosh-Sellavel
    Collaborator

    As for @Santhosh-Sellavel suggestions, I would not add display: grid to display utilities though, since it's not supported by RN - https://github.com/Expensify/App/blob/main/src/styles/utilities/display.js#L4-L6.

    Nice catch @luacmartins , yes adding there could create some unnescessary confusion.

    But the reason behind the suggestion is to use display: gridonly for web/desktop.

    cc: @metehanozyurt

  10. luacmartins commented on Apr 11, 2022

    @luacmartins
    Contributor

    PR was merged. Not overdue.

  11. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Apr 20, 2022
  12. changed the title [-][$500] Pdf preview is not in centered - reported by @thesahindia[/-] [+][HOLD for payment 2022-04-27] [$500] Pdf preview is not in centered - reported by @thesahindia[/+] on Apr 20, 2022
  13. melvin-bot commented on Apr 20, 2022

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.55-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2022-04-27. 🎊

  14. kevinksullivan commented on Apr 28, 2022

    @kevinksullivan
    Contributor

    @Santhosh-Sellavel and @thesahindia paid.

    @metehanozyurt can you accept the offer so i can finish payment for you? Thanks!

  15. kevinksullivan commented on Apr 28, 2022

    @kevinksullivan
    Contributor

    All set, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2ReviewingHas a PR in review

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions