Skip to content

[HOLD for payment 2022-05-20] Show confirmation screen after changing password - reported by @Tushu17 #8152

Closed

Description

@mvtglobally

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to Settings > Security > Change password
  2. Fill the passwords.
  3. Save.

Expected Result:

It should show a success screen
image - 2022-03-15T004658 864

Actual Result:

No feedback displayed

Workaround:

unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.42-4
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

scrn-rec.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Tushu17
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1646069215810249

View all open jobs on GitHub

Activity

  1. MelvinBot commented on Mar 15, 2022

    @MelvinBot
    Contributor

    Triggered auto assignment to @aldo-expensify (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  2. changed the title [-]On changing password, Success growl doesn't show up - reported by @Tushu17[/-] [+]No feedback after changing password - reported by @Tushu17[/+] on Mar 17, 2022
  3. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Mar 17, 2022
  4. MelvinBot commented on Mar 17, 2022

    @MelvinBot
    Contributor

    Triggered auto assignment to @laurenreidexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

  5. removed their assignment
    on Mar 17, 2022
  6. laurenreidexpensify commented on Mar 17, 2022

    @laurenreidexpensify
    Contributor

    @Tushu17 is this happening only on web?

  7. aldo-expensify commented on Mar 17, 2022

    @aldo-expensify
    Contributor

    @laurenreidexpensify I did a quick text search in the project looking for "For additional security" and didn't find anything. I think the password change feedback screen is something that has not been implemented... so it should be missing in all platforms.

  8. laurenreidexpensify commented on Mar 17, 2022

    @laurenreidexpensify
    Contributor

    Thanks @aldo-expensify - I was just wondering where the screenshot @mvtglobally pasted above comes from - that looks like it works on mobile? I'll doublecheck in a bit on my phone with a test account and confirm.

  9. aldo-expensify commented on Mar 17, 2022

    @aldo-expensify
    Contributor
  10. 58 remaining items

  11. chiragsalian commented on Apr 12, 2022

    @chiragsalian
    Contributor

    Asked, let's keep the copy as "You’re all set, keep your new password safe." for now.
    I've made a note for our project of implementing 2FA in NewDot to update this same copy once they are done with the project.

  12. Santhosh-Sellavel commented on Apr 28, 2022

    @Santhosh-Sellavel
    Collaborator

    I see there is clearly a miscommunication that occurred here that has caused the PR delay for this issue.

    On a friendly note @thesahindia, to avoid this in the future let's keep in mind our contributing guidelines, specifically,

    1. Daily updates on weekdays are highly recommended.
    2. If you know you won’t be able to provide updates for > 1 week, please comment on the PR or issue how long you plan to be out so that we may plan accordingly.

    Additionally don't hesitate to bump the C+ or engineer in GH (and even on newDot if you prefer) if there is no update on our end in 24hrs. In most cases, we would respond straight away mostly within a day.

    Thanks!

  13. chiragsalian commented on Apr 29, 2022

    @chiragsalian
    Contributor

    @Expensify/marketing can you confirm the copy shown here is alright?
    image

    i.e., Password updated! You’re all set, keep your new password safe

  14. rosegrech commented on Apr 29, 2022

    @rosegrech

    Not correct use of comma is the only thing to fix. Otherwise it's great.

    Password updated!

    You’re all set. Keep your new password safe.

  15. Santhosh-Sellavel commented on Apr 29, 2022

    @Santhosh-Sellavel
    Collaborator

    Thanks, @rosegrech.

    @thesahindia Can you update the comma!

  16. thesahindia commented on Apr 29, 2022

    @thesahindia
    Member

    Done ✅

  17. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on May 13, 2022
  18. changed the title [-]Show confirmation screen after changing password - reported by @Tushu17[/-] [+][HOLD for payment 2022-05-20] Show confirmation screen after changing password - reported by @Tushu17[/+] on May 13, 2022
  19. melvin-bot commented on May 13, 2022

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.57-17 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2022-05-20. 🎊

  20. laurenreidexpensify commented on May 20, 2022

    @laurenreidexpensify
    Contributor

    everyone has been paid :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in review

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions