Skip to content

[Due for payment 2026-03-19] Admin seeing competing RBR paths with broken company card connection #81724

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number:
Reproducible in staging?: Needs Reproduction (Reproduction blocked)
Reproducible in production?: Needs Reproduction
If this was caught during regression testing, add the test name, ID and link from BrowserStack:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @joekaufmanexpensify
Slack conversation (hyperlinked to channel name): #Expensify Bugs

Action Performed:

  1. Connect a direct feed and assign a card to the admin
  2. Break the feed's connection

Expected Result:

Per this, the admin should see an RBR path directing them to the error on the company cards page. If they also have an assigned card, they should see an error on the card row on wallet, but not a full RBR path leading them to wallet. Only non-admin employees with an assigned card should see the RBR path leading them to the error on wallet.

Actual Result:

Workspace admin with assigned card on broken feed sees full RBR path leading them to the error on company cards AND on wallet.

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Image Image

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 6, 2026
  2. melvin-bot commented on Feb 6, 2026

    @melvin-bot

    Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Feb 6, 2026

    @melvin-bot

    📣 @scerrato88! 📣
    Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
    Please follow these steps:

    1. Make sure you've read and understood the contributing guidelines.
    2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
    3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
    4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
      Screen Shot 2022-11-16 at 4 42 54 PM
      Format:
    Contributor details
    Your Expensify account email: <REPLACE EMAIL HERE>
    Upwork Profile Link: <REPLACE LINK HERE>
    
  4. chrispader commented on Feb 7, 2026

    @chrispader
    Contributor

    @carlosmiceli i can tackle this. I should have a good idea where this needs to be fixed!

  5. carlosmiceli commented on Feb 7, 2026

    @carlosmiceli
    Contributor

    Hey Chris, no worries, I asked @hungvu193 to work on this one to tackle more issues in parallel so you and I can focus on our other existing open issues 🙏

  6. carlosmiceli commented on Feb 7, 2026

    @carlosmiceli
    Contributor

    Having said that, @hungvu193 please do ask Chris for pointers if it's hard to spot the solution 💪

  7. hungvu193 commented on Feb 8, 2026

    @hungvu193
    Contributor

    @carlosmiceli i can tackle this. I should have a good idea where this needs to be fixed!

    @chrispader Yeah I would love to hear your idea about fixing the RCA 🙏

  8. chrispader commented on Feb 9, 2026

    @chrispader
    Contributor

    @carlosmiceli i can tackle this. I should have a good idea where this needs to be fixed!

    @chrispader Yeah I would love to hear your idea about fixing the RCA 🙏

    Alright, i'll let @hungvu193 handle this. @hungvu193 the issue should be located in the error states for workspace/account indicator in useNavigationTabBarIndicatorChecks.ts.

    Currently, we show/hide the indicator based on whether the user is an admin of any workspace or not (isPolicyAdmin), but maybe we'll have to be specific with exact workspsace

  9. hungvu193 commented on Feb 10, 2026

    @hungvu193
    Contributor

    Currently, we show/hide the indicator based on whether the user is an admin of any workspace or not (isPolicyAdmin), but maybe we'll have to be specific with exact workspsace

    Oh I see. I remember I also concerned about it while reviewing the PR 😄. Let me take a look

  10. 38 remaining items

  11. jliexpensify commented on Mar 19, 2026

    @jliexpensify
    Contributor

    Any checklist required here? Payment date is tomorrow

  12. melvin-bot commented on Mar 19, 2026

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@mallenexpensify)

    • (if NewFeature) I have created a PR for any necessary HelpDot updates, or I confirmed no updates are necessary.
    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  13. jliexpensify commented on Mar 20, 2026

    @jliexpensify
    Contributor

    @hungvu193 @ShridharGoel any checklist required here?

  14. hungvu193 commented on Mar 20, 2026

    @hungvu193
    Contributor

    @hungvu193 @ShridharGoel any checklist required here?

    We do yeah. @ShridharGoel Please complete the checklist when you have a chance. Thanks

  15. twisterdotcom commented on Mar 20, 2026

    @twisterdotcom
    Contributor

    @hungvu193 has submitted payment for this report on ND here.

    SO: https://stackoverflowteams.com/c/expensify/questions/7582

    Zapier Logs Run ID: 00040eee-4110-a46c-e3c9-7e8683aa1a24
  16. ShridharGoel commented on Mar 20, 2026

    @ShridharGoel
    Contributor

    BugZero Checklist:

    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: N/A

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue: https://github.com/Expensify/Expensify/issues/614411

    Regression Test Proposal

    Precondition:

    Test:

    1. Login as User A > Create a workspace with at least one company card.
    2. Invite User B to the workspace, change User B role to admin and assign them a card.
    3. Break the card connection. (Check this slack thread for more ℹ️ ).
    4. Login with User B > go to workspace that User A has just invited > Company Card > Verify there is RBR on company card page.
    5. Go to Account > Wallet > Verify that there is no RBR display on Wallet page.
    6. Verify that there is an error under the broken company card.
    7. Login with User A again > Change the role of User B to Member.
    8. Login with User B > Go to Account > Wallet.
    9. Verify that there's RBR display on the Wallet page and Account tab.

    Do we agree 👍 or 👎

    Zapier Logs Run ID: 00040eee-3ebc-a99e-5f4b-80c949bc0e64
  17. mallenexpensify commented on Mar 20, 2026

    @mallenexpensify
    Contributor
  18. JmillsExpensify commented on Apr 6, 2026

    @JmillsExpensify
    Contributor

    $250 approved for @ShridharGoel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ReviewingHas a PR in review

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions