Skip to content

Workspace name is not shown in the modal header for connect to bank account #8175

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue was found when executing #8065

Action Performed:

  1. Go staging.new.expensify.com and login
  2. Go to workspace > bank account

Expected Result:

Verify that the workspace name is shown in the modal header.

Actual Result:

Workspace name is not shown in the modal header.

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.43-1
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature
Email or phone of affected tester (no customers): applausetester++2501mn@applause.expensifail.com / Utest123
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
Bug5492431_Screenshot__248_ (1)

Expensify/Expensify Issue URL:
Issue reported by: Applause
Slack conversation:

View all open jobs on GitHub

Activity

  1. OSBotify commented on Mar 16, 2022

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. MelvinBot commented on Mar 16, 2022

    @MelvinBot
    Contributor

    Triggered auto assignment to @tylerkaraszewski (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  3. mollfpr commented on Mar 16, 2022

    @mollfpr
    Contributor
    1. I think it makes sense because a connecting bank account is for the account not for the workspace
    2. There's no policy ID applied in the route so there's no way our hoc withFullPolicy will give the workspace data
  4. luacmartins commented on Mar 16, 2022

    @luacmartins
    Contributor

    I can take a look at this one @tylerkaraszewski!

  5. self-assigned this
    on Mar 16, 2022
  6. luacmartins commented on Mar 16, 2022

    @luacmartins
    Contributor

    Removing the deploy blocker label since this feature is still a WIP.

  7. tylerkaraszewski commented on Mar 16, 2022

    @tylerkaraszewski
    Contributor

    This is not really an issue, the test steps just include an extra line that they shouldn't. I'll remove that line from the tests steps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions