You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$250] Taxes - System-generated messages are missing in thread after updating tax settings #81791
Version Number: v9.3.15-8 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from BrowserStack:#65320 Email or phone of affected tester (no customers): n/a Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 15.4.1 Safari, Chrome, iPhone 13 iOS 26.2.1 App Component: Workspace Settings
Add new Rate >> name and add the new Value then Save it
5.Tap Settings >> select New Rate for Workspace currency default
Tap Settings >> Custom tax name >> Enter new name and sace it
Navigate to the Admins room
Open threads
Expected Result:
All changes should be dispayed in the system-generated thread
Actual Result:
Not all system-generated messages are displayed in the thread after changing tax settings. The number of thread messages does not correspond to the thread reply count. The system messages "Changed the tax code value" and "Changed the custom tax name" are missing.
but we have not implimented this in FrontEnd helpers setPolicyCustomTaxName, setWorkspaceCurrencyDefault, and setForeignCurrencyDefault so they does not render in PureReportActionItem but since Backend return the complete action to the reply count for thred in admins room update after each cgange in Tax settings
What changes do you think we should make in order to solve the problem?
We should add all three actions type in POLICY_CHANGE_LOG CONST
build Optimistic Tax value change action helpers and add them in setPolicyCustomTaxName, setWorkspaceCurrencyDefault, and setForeignCurrencyDefault
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: The localization never happened from the beginning
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Test:
Go to a workspace and navigate to More Features
Toggle a feature on or off (e.g., enable or disable Taxes)
Navigate to the Admins room in the LHN
Verify the LHN preview text for the Admins room shows the correct localized message (e.g., "enabled tax tracking" or "disabled tax tracking") instead of generic fallback text
Activity
samranahm commentedon Feb 8, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
What is the root cause of that problem?
We have defined the tax setting menu item here
App/src/pages/workspace/taxes/WorkspaceTaxesSettingsPage.tsx
Lines 31 to 53 in ea7257f
When we update the value in setings BE return action with these
actionNamebut we have not implimented this in FrontEnd helpers
setPolicyCustomTaxName,setWorkspaceCurrencyDefault, andsetForeignCurrencyDefaultso they does not render inPureReportActionItembut since Backend return the complete action to the reply count for thred in admins room update after each cgange in Tax settingsWhat changes do you think we should make in order to solve the problem?
POLICY_CHANGE_LOGCONSTPureReportActionItemand LHNContextMenuActionssetPolicyCustomTaxName,setWorkspaceCurrencyDefault, andsetForeignCurrencyDefaultWhat alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
melvin-bot commentedon Feb 13, 2026
Eep! 4 days overdue now. Issues have feelings too...
melvin-bot commentedon Feb 16, 2026
Still overdue 6 days?! Let's take care of this!
samranahm commentedon Feb 16, 2026
@jponikarchuk Can you apply the relevant labels here to assign CME.
13 remaining items
MelvinBot commentedon Mar 9, 2026
🤖 Draft PR created: #84616
Please mark it as "Ready for review" when it is ready for review.
melvin-bot commentedon Mar 9, 2026
Triggered auto assignment to @Beamanator, see https://stackoverflow.com/c/expensify/questions/7972 for more details.
mkhutornyi commentedon Apr 1, 2026
Automation failed here. PR was deployed to production on Mar 11.
cc: @jliexpensify
jliexpensify commentedon Apr 1, 2026
Thanks for the bump @mkhutornyi - any checklist needed?
jliexpensify commentedon Apr 1, 2026
Payment Summary
mkhutornyi commentedon Apr 2, 2026
BugZero Checklist:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: The localization never happened from the beginning
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Test:
Do we agree 👍 or 👎
quinthar commentedon Apr 4, 2026
Approved $250 to @mkhutornyi