You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2022-05-20]Deep Link to the Statements page from a link #8185
From an email or external source, click on the link new.expensify.com/statements/202202/
Notice on mobile devices, it opens in a webpage instead of opening in the app
Expected Result:
Similar to how you can deep link a report, we want the statement to deeplink and have it open in app
Actual Result:
Opens in a webpage
Workaround:
Not currently in use
Platform:
Where is this issue occurring?
Web
iOS x
Android x
Desktop App x
Mobile Web
Version Number: Reproducible in staging?: Yes Reproducible in production?: Yes Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation Expensify/Expensify Issue URL: Issue reported by: Slack conversation:
changed the title [-]Deep Link to the Statements page from a link[/-][+][HOLD for payment 2022-05-20]Deep Link to the Statements page from a link[/+]on May 20, 2022
@Julesssss yeah, we gotta figure out the expected result on web.
The expected result on web is just that it links to that link in the web browser. There's no additional functionality needed since only native devices need to be able to open up in the app.
Because I see this, which seems broken:
I'm not sure how this happened, but if there are reproduction steps that would be great - it seems unrelated to this PR and there are a couple of checks to make sure you can't access oldDot through the link
Activity
MelvinBot commentedon Mar 16, 2022
Triggered auto assignment to @flaviadefaria (
AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.MelvinBot commentedon Mar 16, 2022
Triggered auto assignment to @adelekennedy (
External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.47 remaining items
[-]Deep Link to the Statements page from a link[/-][+][HOLD for payment 2022-05-20]Deep Link to the Statements page from a link[/+]Julesssss commentedon May 25, 2022
Please correct me if I'm wrong, but this shouldn't be happening, right? Is this link supposed to work on web?
https://new.expensify.com/statements/20202
Because I see this, which seems broken:
rushatgabhane commentedon May 25, 2022
@Julesssss yeah, we gotta figure out the expected result on web.
Just realized that the PR for this issue only modifies native code. We gotta dig deeper ig?
rushatgabhane commentedon May 25, 2022
@Julesssss you're right!
Here's the expected result from PR #7663
Anyway, we're getting the statements from oldDot. And I don't see any frontend changes.
App/src/pages/wallet/WalletStatementPage.js
Line 103 in 8e3c67b
This makes me think that the issue is internal. Please correct me if I'm wrong :)
thienlnam commentedon May 25, 2022
The expected result on web is just that it links to that link in the web browser. There's no additional functionality needed since only native devices need to be able to open up in the app.
I'm not sure how this happened, but if there are reproduction steps that would be great - it seems unrelated to this PR and there are a couple of checks to make sure you can't access oldDot through the link
thienlnam commentedon May 27, 2022
Closing as we can't reproduce this on prod