Skip to content

[HOLD for payment 2022-05-20]Deep Link to the Statements page from a link #8185

Closed

Description

@thienlnam

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

Break down in numbered steps

  1. From an email or external source, click on the link new.expensify.com/statements/202202/
  2. Notice on mobile devices, it opens in a webpage instead of opening in the app

Expected Result:

Similar to how you can deep link a report, we want the statement to deeplink and have it open in app

Actual Result:

Opens in a webpage

Workaround:

Not currently in use

Platform:

Where is this issue occurring?

  • Web
  • iOS x
  • Android x
  • Desktop App x
  • Mobile Web

Version Number:
Reproducible in staging?: Yes
Reproducible in production?: Yes
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

View all open jobs on GitHub

Activity

  1. MelvinBot commented on Mar 16, 2022

    @MelvinBot
    Contributor

    Triggered auto assignment to @flaviadefaria (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

  2. removed
    AutoAssignerTriageAuto assign issues for triage to an available triage team member
    on Mar 16, 2022
  3. added
    ExternalAdded to denote the issue can be worked on by a contributor
    and removed on Mar 16, 2022
  4. MelvinBot commented on Mar 16, 2022

    @MelvinBot
    Contributor

    Triggered auto assignment to @adelekennedy (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

  5. 47 remaining items

  6. changed the title [-]Deep Link to the Statements page from a link[/-] [+][HOLD for payment 2022-05-20]Deep Link to the Statements page from a link[/+] on May 20, 2022
  7. Julesssss commented on May 25, 2022

    @Julesssss
    Contributor

    Please correct me if I'm wrong, but this shouldn't be happening, right? Is this link supposed to work on web?

    https://new.expensify.com/statements/20202

    Because I see this, which seems broken:

    Screenshot 2022-05-25 at 11 34 24

  8. rushatgabhane commented on May 25, 2022

    @rushatgabhane
    Member

    @Julesssss yeah, we gotta figure out the expected result on web.

    Just realized that the PR for this issue only modifies native code. We gotta dig deeper ig?

  9. rushatgabhane commented on May 25, 2022

    @rushatgabhane
    Member

    @Julesssss you're right!

    Here's the expected result from PR #7663


    Anyway, we're getting the statements from oldDot. And I don't see any frontend changes.

    const url = `${CONFIG.EXPENSIFY.EXPENSIFY_URL}statement.php?period=${this.yearMonth}`;

    This makes me think that the issue is internal. Please correct me if I'm wrong :)

  10. thienlnam commented on May 25, 2022

    @thienlnam
    ContributorAuthor

    @Julesssss yeah, we gotta figure out the expected result on web.

    The expected result on web is just that it links to that link in the web browser. There's no additional functionality needed since only native devices need to be able to open up in the app.

    Because I see this, which seems broken:

    I'm not sure how this happened, but if there are reproduction steps that would be great - it seems unrelated to this PR and there are a couple of checks to make sure you can't access oldDot through the link

  11. removed their assignment
    on May 26, 2022
  12. thienlnam commented on May 27, 2022

    @thienlnam
    ContributorAuthor

    Closing as we can't reproduce this on prod

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions