Skip to content

[Due for payment 2026-03-30] [$250] Admins unable to edit Reimbursable status for personal card in ND #81997

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.14-0
Reproducible in staging?: Needs Reproduction (Reproduction blocked)
Reproducible in production?: Needs Reproduction
If this was caught during regression testing, add the test name, ID and link from BrowserStack:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @abbagail
Slack conversation (hyperlinked to channel name): #Expensify Bugs

Action Performed:

  1. Go to Reports > Approve
  2. click on the report to open it
  3. Select a line item to open the expenses
  4. Check for Reimbursable status to edit

Expected Result:

See the "Reimbursable" option to switch it from Reimbursable > Non- reimbursable

Actual Result:

No option for Reimbursable
work around: switch back to Classic.

Workaround:

witch back to Classic.

Platforms:

Select the officially supported platforms where the issue was reproduced:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

The video for the issue is in slack thread

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @abzokhattab
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~022021237612347400388
  • Upwork Job ID: 2021237612347400388
  • Last Price Increase: 2026-03-02

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 10, 2026
  2. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 10, 2026
  3. melvin-bot commented on Feb 10, 2026

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @abzokhattab (External)

  4. melvin-bot commented on Feb 10, 2026

    @melvin-bot

    Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. changed the title [-]Admins unable to edit Reimbursable status for personal card in ND[/-] [+][$250] Admins unable to edit Reimbursable status for personal card in ND[/+] on Feb 10, 2026
  6. melvin-bot commented on Feb 10, 2026

    @melvin-bot
  7. annaweber830 commented on Feb 10, 2026

    @annaweber830
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    When an admin opens an expense from the Reports > Approve flow, the Reimbursable toggle is missing for personal card transactions in NewDot. This prevents admins from switching reimbursable/non-reimbursable status unless they use Classic.

    What is the root cause of that problem?

    The reimbursement visibility logic in MoneyRequestView uses isFromCreditCardImport (aliased as isCardTransactionTransactionUtils) to decide whether to hide the Reimbursable row. That helper explicitly returns true for both managed cards and personal card imports, so the UI incorrectly treats personal card transactions like managed/company cards and hides the toggle.

    isFromCreditCardImport as isCardTransactionTransactionUtils,

    const shouldShowReimbursable =
    (isPolicyExpenseChat || (isExpenseUnreported && !!policy)) &&
    (policy?.disabledFields?.reimbursable !== true || isCurrentTransactionReimbursableDifferentFromPolicyDefault) &&
    !isManagedCardTransaction &&
    !isInvoice;

    /**
    * Determine whether a transaction is imported from a credit card.
    * This includes managed cards (Expensify/Company cards) and personal cards imported via bank connection.
    */
    function isFromCreditCardImport(transaction: OnyxEntry<Transaction>): boolean {
    // This can be set in transactions found in the search snapshot
    if (transaction?.transactionType === CONST.SEARCH.TRANSACTION_TYPE.CARD) {
    return true;
    }
    if (transaction?.bank === CONST.COMPANY_CARDS.BANK_NAME.UPLOAD) {
    return false;
    }
    if (transaction?.cardName === CONST.EXPENSE.TYPE.CASH_CARD_NAME) {
    return false;
    }
    if (isManagedCardTransaction(transaction)) {
    return true;
    }
    if (transaction?.cardNumber) {
    return true;
    }
    if (transaction?.bank) {
    return true;
    }

    import {
        // ...
        isFromCreditCardImport as isCardTransactionTransactionUtils,
        // ...
    } from '@libs/TransactionUtils';
    
    const isManagedCardTransaction = isCardTransactionTransactionUtils(transaction);
    
    const shouldShowReimbursable =
        (isPolicyExpenseChat || (isExpenseUnreported && !!policy)) &&
        (policy?.disabledFields?.reimbursable !== true || isCurrentTransactionReimbursableDifferentFromPolicyDefault) &&
        !isManagedCardTransaction &&
        !isInvoice;
    
    // TransactionUtils
    function isFromCreditCardImport(transaction: OnyxEntry<Transaction>): boolean {
        // This includes managed cards (Expensify/Company cards) and personal cards imported via bank connection.
        // ...
        if (isManagedCardTransaction(transaction)) {
            return true;
        }
    
        if (transaction?.cardNumber) {
            return true;
        }
    
        if (transaction?.bank) {
            return true;
        }
    
        return false;
    }

    What changes do you think we should make in order to solve the problem?

    Use the managed-card-specific helper for the Reimbursable visibility gate, instead of the broader credit-card-import helper. This keeps the existing behavior for managed/company cards (toggle hidden) while allowing personal card transactions to show the toggle as expected.

    import {
    getBillable,
    getCurrency,
    getDescription,
    getDistanceInMeters,
    getFormattedCreated,
    getOriginalAmountForDisplay,
    getOriginalTransactionWithSplitInfo,
    getReimbursable,
    getTagArrayFromName,
    getTagForDisplay,
    getTaxName,
    hasMissingSmartscanFields,
    hasReservationList,
    hasRoute as hasRouteTransactionUtils,
    isFromCreditCardImport as isCardTransactionTransactionUtils,
    isCategoryBeingAnalyzed,
    isDistanceRequest as isDistanceRequestTransactionUtils,
    isExpenseUnreported as isExpenseUnreportedTransactionUtils,
    isGPSDistanceRequest as isGPSDistanceRequestTransactionUtils,
    isManualDistanceRequest as isManualDistanceRequestTransactionUtils,
    isMapDistanceRequest as isMapDistanceRequestTransactionUtils,
    isOdometerDistanceRequest as isOdometerDistanceRequestTransactionUtils,
    isPerDiemRequest as isPerDiemRequestTransactionUtils,
    isScanning,
    isTimeRequest as isTimeRequestTransactionUtils,
    shouldShowAttendees as shouldShowAttendeesTransactionUtils,
    } from '@libs/TransactionUtils';

    const isManagedCardTransaction = isCardTransactionTransactionUtils(transaction);

    Current code:

    import {
        // ...
        isFromCreditCardImport as isCardTransactionTransactionUtils,
        // ...
    } from '@libs/TransactionUtils';
    
    const isManagedCardTransaction = isCardTransactionTransactionUtils(transaction);

    Updated code:

    import {
        // ...
        isManagedCardTransaction as isManagedCardTransactionTransactionUtils,
        // ...
    } from '@libs/TransactionUtils';
    
    const isManagedCardTransaction = isManagedCardTransactionTransactionUtils(transaction);

    What alternative solutions did you explore? (Optional)

    I considered changing isFromCreditCardImport so it excludes personal cards, but that helper is intentionally broad and used for multiple flows that need to treat both managed and personal card imports as card transactions. Narrowing the check only at this UI gating point is the smallest and safest fix.

  8. abzokhattab commented on Feb 10, 2026

    @abzokhattab
    Contributor

    @annaweber830 are u able to reproduce it? I am struggling to .. will check it again later today

  9. annaweber830 commented on Feb 10, 2026

    @annaweber830
    Contributor

    Hi @abzokhattab I will check again.

  10. melvin-bot commented on Feb 13, 2026

    @melvin-bot

    @abzokhattab Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  11. 55 remaining items

  12. mallenexpensify commented on Mar 31, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @abzokhattab due $250 via NewDot

    @abzokhattab plz complete the BZ checklist and tag me in a post once you have. Thx

  13. melvin-bot commented on Apr 6, 2026

    @melvin-bot

    @mallenexpensify Eep! 4 days overdue now. Issues have feelings too...

  14. melvin-bot commented on Apr 8, 2026

    @melvin-bot

    @mallenexpensify Still overdue 6 days?! Let's take care of this!

  15. mallenexpensify commented on Apr 8, 2026

    @mallenexpensify
    Contributor

    @abzokhattab plz complete the BZ checklist and tag me in a post once you have. Thx

  16. melvin-bot commented on Apr 10, 2026

    @melvin-bot

    @abzokhattab 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

  17. abzokhattab commented on Apr 13, 2026

    @abzokhattab
    Contributor

    BugZero Checklist

    • [Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to the comment on the PR: https://github.com/Expensify/App/pull/77243/changes#r3072559796

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Precondition:

    • Log in as a workspace admin that has personal card transactions (not managed/company card)

    Test:

    1. Go to Reports > Approve
    2. Open a report containing a personal card transaction
    3. Select a line item to open the expense
    4. Verify the "Reimbursable" toggle is visible and can be switched
    5. Open a managed/company card transaction and verify the "Reimbursable" toggle is NOT shown (expected hidden for managed cards)

    Do we agree 👍 or 👎

  18. abzokhattab commented on Apr 13, 2026

    @abzokhattab
    Contributor
  19. m-natarajan commented on Apr 14, 2026

    @m-natarajan
    Author

    @abzokhattab Applause is blocked from executing the regression test proposal as this requires a personal card transactions. Do you have any workaround for this?

  20. mallenexpensify commented on Apr 14, 2026

    @mallenexpensify
    Contributor

    @m-natarajan I have this in the main C+ process doc

    Testing personal cards
    Matt A. is unsure how best to do this. Ideally there’d be a contributor or a few that would be able to add their own personal cards. If a C+ sees this and has a way to test, please comment.

    so... not so helpful

  21. quinthar commented on Apr 21, 2026

    @quinthar
    Contributor

    Approved $250 to @abzokhattab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions