You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-03-30] [$250] Admins unable to edit Reimbursable status for personal card in ND #81997
Version Number: 9.3.14-0 Reproducible in staging?: Needs Reproduction (Reproduction blocked) Reproducible in production?: Needs Reproduction If this was caught during regression testing, add the test name, ID and link from BrowserStack: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by:@abbagail Slack conversation (hyperlinked to channel name): #Expensify Bugs
Action Performed:
Go to Reports > Approve
click on the report to open it
Select a line item to open the expenses
Check for Reimbursable status to edit
Expected Result:
See the "Reimbursable" option to switch it from Reimbursable > Non- reimbursable
Actual Result:
No option for Reimbursable
work around: switch back to Classic.
Workaround:
witch back to Classic.
Platforms:
Select the officially supported platforms where the issue was reproduced:
changed the title [-]Admins unable to edit Reimbursable status for personal card in ND[/-][+][$250] Admins unable to edit Reimbursable status for personal card in ND[/+]on Feb 10, 2026
Please re-state the problem that we are trying to solve in this issue.
When an admin opens an expense from the Reports > Approve flow, the Reimbursable toggle is missing for personal card transactions in NewDot. This prevents admins from switching reimbursable/non-reimbursable status unless they use Classic.
What is the root cause of that problem?
The reimbursement visibility logic in MoneyRequestView uses isFromCreditCardImport (aliased as isCardTransactionTransactionUtils) to decide whether to hide the Reimbursable row. That helper explicitly returns true for both managed cards and personal card imports, so the UI incorrectly treats personal card transactions like managed/company cards and hides the toggle.
import{// ...isFromCreditCardImportasisCardTransactionTransactionUtils,// ...}from'@libs/TransactionUtils';constisManagedCardTransaction=isCardTransactionTransactionUtils(transaction);constshouldShowReimbursable=(isPolicyExpenseChat||(isExpenseUnreported&&!!policy))&&(policy?.disabledFields?.reimbursable!==true||isCurrentTransactionReimbursableDifferentFromPolicyDefault)&&!isManagedCardTransaction&&!isInvoice;// TransactionUtilsfunctionisFromCreditCardImport(transaction: OnyxEntry<Transaction>): boolean{// This includes managed cards (Expensify/Company cards) and personal cards imported via bank connection.// ...if(isManagedCardTransaction(transaction)){returntrue;}if(transaction?.cardNumber){returntrue;}if(transaction?.bank){returntrue;}returnfalse;}
What changes do you think we should make in order to solve the problem?
Use the managed-card-specific helper for the Reimbursable visibility gate, instead of the broader credit-card-import helper. This keeps the existing behavior for managed/company cards (toggle hidden) while allowing personal card transactions to show the toggle as expected.
What alternative solutions did you explore? (Optional)
I considered changing isFromCreditCardImport so it excludes personal cards, but that helper is intentionally broad and used for multiple flows that need to treat both managed and personal card imports as card transactions. Narrowing the check only at this UI gating point is the smallest and safest fix.
[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Log in as a workspace admin that has personal card transactions (not managed/company card)
Test:
Go to Reports > Approve
Open a report containing a personal card transaction
Select a line item to open the expense
Verify the "Reimbursable" toggle is visible and can be switched
Open a managed/company card transaction and verify the "Reimbursable" toggle is NOT shown (expected hidden for managed cards)
@abzokhattab Applause is blocked from executing the regression test proposal as this requires a personal card transactions. Do you have any workaround for this?
@m-natarajan I have this in the main C+ process doc
Testing personal cards
Matt A. is unsure how best to do this. Ideally there’d be a contributor or a few that would be able to add their own personal cards. If a C+ sees this and has a way to test, please comment.
Activity
melvin-bot commentedon Feb 10, 2026
Triggered auto assignment to Contributor-plus team member for initial proposal review - @abzokhattab (
External)melvin-bot commentedon Feb 10, 2026
Triggered auto assignment to @dylanexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.[-]Admins unable to edit Reimbursable status for personal card in ND[/-][+][$250] Admins unable to edit Reimbursable status for personal card in ND[/+]melvin-bot commentedon Feb 10, 2026
Job added to Upwork: https://www.upwork.com/jobs/~022021237612347400388
annaweber830 commentedon Feb 10, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
When an admin opens an expense from the Reports > Approve flow, the Reimbursable toggle is missing for personal card transactions in NewDot. This prevents admins from switching reimbursable/non-reimbursable status unless they use Classic.
What is the root cause of that problem?
The reimbursement visibility logic in
MoneyRequestViewusesisFromCreditCardImport(aliased asisCardTransactionTransactionUtils) to decide whether to hide the Reimbursable row. That helper explicitly returnstruefor both managed cards and personal card imports, so the UI incorrectly treats personal card transactions like managed/company cards and hides the toggle.App/src/components/ReportActionItem/MoneyRequestView.tsx
Line 91 in aa5d2da
App/src/components/ReportActionItem/MoneyRequestView.tsx
Lines 396 to 400 in aa5d2da
App/src/libs/TransactionUtils/index.ts
Lines 1361 to 1389 in aa5d2da
What changes do you think we should make in order to solve the problem?
Use the managed-card-specific helper for the Reimbursable visibility gate, instead of the broader credit-card-import helper. This keeps the existing behavior for managed/company cards (toggle hidden) while allowing personal card transactions to show the toggle as expected.
App/src/components/ReportActionItem/MoneyRequestView.tsx
Lines 76 to 103 in aa5d2da
App/src/components/ReportActionItem/MoneyRequestView.tsx
Line 304 in aa5d2da
Current code:
Updated code:
What alternative solutions did you explore? (Optional)
I considered changing
isFromCreditCardImportso it excludes personal cards, but that helper is intentionally broad and used for multiple flows that need to treat both managed and personal card imports as card transactions. Narrowing the check only at this UI gating point is the smallest and safest fix.abzokhattab commentedon Feb 10, 2026
@annaweber830 are u able to reproduce it? I am struggling to .. will check it again later today
annaweber830 commentedon Feb 10, 2026
Hi @abzokhattab I will check again.
melvin-bot commentedon Feb 13, 2026
@abzokhattab Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
55 remaining items
mallenexpensify commentedon Mar 31, 2026
Payment Summary
Contributor+: @abzokhattab due $250 via NewDot
@abzokhattab plz complete the BZ checklist and tag me in a post once you have. Thx
melvin-bot commentedon Apr 6, 2026
@mallenexpensify Eep! 4 days overdue now. Issues have feelings too...
melvin-bot commentedon Apr 8, 2026
@mallenexpensify Still overdue 6 days?! Let's take care of this!
mallenexpensify commentedon Apr 8, 2026
@abzokhattab plz complete the BZ checklist and tag me in a post once you have. Thx
melvin-bot commentedon Apr 10, 2026
@abzokhattab 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!
abzokhattab commentedon Apr 13, 2026
BugZero Checklist
[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to the comment on the PR: https://github.com/Expensify/App/pull/77243/changes#r3072559796
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
abzokhattab commentedon Apr 13, 2026
@mallenexpensify done
m-natarajan commentedon Apr 14, 2026
@abzokhattab Applause is blocked from executing the regression test proposal as this requires a personal card transactions. Do you have any workaround for this?
mallenexpensify commentedon Apr 14, 2026
@m-natarajan I have this in the main C+ process doc
so... not so helpful
quinthar commentedon Apr 21, 2026
Approved $250 to @abzokhattab