Skip to content

[Due for Payment 2026-03-17] [$250] Thread - Thread header doesn´t match details page when creating thread with system message #82003

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.16.0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #81086
Email or phone of affected tester (no customers): ibellicotest+2250@gmail.com
Issue reported by: Applause Internal Team
Bug source: Pull Request QA execution
Device used: Motorola MotoG60 / Android 12 (Hybrid app) - Windows 11 / Chrome
App Component: Other

Action Performed:

Prerequisite: Account has at least one workspace.

  1. Open the Expensify app.
  2. Open any workspace chat.
  3. Create a manual expense.
  4. Open the just created expense.
  5. Hold and unhold the expense.
  6. Long tap on the "Held this expense" message and select "Reply in thread"
  7. Note that thread header shows "Held this expense"
  8. Tap on header to navigate to details page.
  9. Note that details page header shows "Held this money request" message,

Expected Result:

Thread header and details page header should be the same when creating a thread with a system-generated message.

Actual Result:

Thread header and details page header shows different message when creating a thread with a system-generated message of a held expense.
Thread header shows a "Held this expense" message while details page header shows a "Held this money request" message.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Bug7073633_1770732375231.Thr_1.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @nkuoch
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~022021249041301512388
  • Upwork Job ID: 2021249041301512388
  • Last Price Increase: 2026-02-10

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 10, 2026
  2. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 10, 2026
  3. melvin-bot commented on Feb 10, 2026

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @ZhenjaHorbach (External)

  4. melvin-bot commented on Feb 10, 2026

    @melvin-bot

    Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. changed the title [-]Thread - Thread header doesn´t match details page when creating thread with system message[/-] [+][$250] Thread - Thread header doesn´t match details page when creating thread with system message[/+] on Feb 10, 2026
  6. melvin-bot commented on Feb 10, 2026

    @melvin-bot
  7. daledah commented on Feb 10, 2026

    @daledah
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Actual Result:
    Thread header and details page header shows different message when creating a thread with a system-generated message of a held expense.
    Thread header shows a "Held this expense" message while details page header shows a "Held this money request" message.

    What is the root cause of that problem?

    The root cause is that ReportDetailsPage.tsx and HeaderView.tsx use different functions to get the report name for thread reports:

    1. HeaderView.tsx (thread header) uses getReportName() from ReportUtils.ts which dynamically computes the thread name. For HOLD actions, it calls translate('iou.heldExpense') via getReportActionMessage():

      • App/src/libs/ReportUtils.ts

        Lines 5637 to 5638 in 013badf

        if (reportAction.actionName === CONST.REPORT.ACTIONS.TYPE.HOLD) {
        return translate('iou.heldExpense');
      • const title = getReportName(reportHeaderData, policy, parentReportAction, personalDetails, invoiceReceiverPolicy, undefined, undefined, isReportHeaderDataArchived);
    2. ReportDetailsPage.tsx (details page) uses getReportName() from ReportNameUtils.ts which simply returns the stored report.reportName field directly without dynamic translation:

      • function getReportName(report?: Report, reportAttributesDerivedValue?: ReportAttributesDerivedValue['reports']): string {
        if (!report || !report.reportID) {
        return '';
        }
        return reportAttributesDerivedValue?.[report.reportID]?.reportName ?? report.reportName ?? '';
        }
      • import {getReportName as getReportNameFromReportNameUtils} from '@libs/ReportNameUtils';
      • const rawReportName = getReportNameFromReportNameUtils(reportForHeader, reportAttributes);

    When a thread is created from a HOLD action, the report.reportName is set from the action's message text. If this stored value differs from the dynamically translated value, the two pages show different messages.

    What changes do you think we should make in order to solve the problem?

    We should update ReportDetailsPage.tsx to use the same dynamic report name computation as HeaderView.tsx for consistency.

    In src/pages/ReportDetailsPage.tsx:

    - import {getReportName as getReportNameFromReportNameUtils} from '@libs/ReportNameUtils';
    + import {getReportName as getReportNameFromReportUtils} from '@libs/ReportUtils';

    And update the usage:

    - const rawReportName = getReportNameFromReportNameUtils(reportForHeader, reportAttributes);
    + const rawReportName = getReportNameFromReportUtils(reportForHeader, policy, parentReportAction, personalDetails);

    This ensures both HeaderView.tsx and ReportDetailsPage.tsx use the same dynamic computation for the report name, producing consistent results for threads created from system-generated messages like HOLD actions.

    What alternative solutions did you explore? (Optional)

    N/A

  8. samranahm commented on Feb 10, 2026

    @samranahm
    Contributor

    🚨 Edited by proposal-police: This proposal was edited at 2026-02-10 16:49:08 UTC.

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Thread - Thread header doesn´t match details page when creating thread with system message

    What is the root cause of that problem?

    The report details page title comes from ReportNameUtils’ derived report name computeReportNameBasedOnReportAction, which did not handle HOLD/UNHOLD. The thread header (headerView) uses ReportUtils’ getReportActionMessage, which does. So these two page used different logic and showed different text.### What changes do you think we should make in order to solve the problem?

    Since the getReportName form ReportUtils is depreciated, We should add

    if (parentReportAction?.actionName === CONST.REPORT.ACTIONS.TYPE.HOLD) {
        return translate('iou.heldExpense');
    }
    if (parentReportAction?.actionName === CONST.REPORT.ACTIONS.TYPE.UNHOLD) {
        return translate('iou.unheldExpense');
    }

    in computeReportNameBasedOnReportAction to keep using getReportNameFromReportNameUtils

    here

    function computeReportNameBasedOnReportAction(
    translate: LocalizedTranslate,
    parentReportAction: ReportAction | undefined,
    report: Report | undefined,
    reportPolicy: Policy | undefined,
    parentReport: Report | undefined,
    ): string | undefined {
    if (!parentReportAction) {
    return undefined;
    }

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  9. ZhenjaHorbach commented on Feb 11, 2026

    @ZhenjaHorbach
    Contributor

    Thanks for your proposals
    But as for me, @daledah's proposal looks better
    So I don't mind going with this proposal!

    🎀👀🎀 С+

  10. 14 remaining items

  11. ZhenjaHorbach commented on Mar 16, 2026

    @ZhenjaHorbach
    Contributor

    @NicMendonca
    We are ready for payment!

  12. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed
    ReviewingHas a PR in review
    on Mar 17, 2026
  13. melvin-bot commented on Mar 17, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  14. changed the title [-][$250] Thread - Thread header doesn´t match details page when creating thread with system message[/-] [+][Due for Payment 2026-03-17] [$250] Thread - Thread header doesn´t match details page when creating thread with system message[/+] on Mar 17, 2026
  15. mallenexpensify commented on Mar 17, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor: @daledah due $250 via NewDot
    Contributor+: @ZhenjaHorbach due $250 via NewDot

    ^ Test case created

  16. garrettmknight commented on Mar 18, 2026

    @garrettmknight
    Contributor

    $250 approved for @ZhenjaHorbach

  17. garrettmknight commented on Mar 25, 2026

    @garrettmknight
    Contributor

    $250 approved for @daledah

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions