You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for Payment 2026-03-17] [$250] Thread - Thread header doesn´t match details page when creating thread with system message #82003
Version Number: 9.3.16.0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from BrowserStack:#81086 Email or phone of affected tester (no customers):ibellicotest+2250@gmail.com Issue reported by: Applause Internal Team Bug source: Pull Request QA execution Device used: Motorola MotoG60 / Android 12 (Hybrid app) - Windows 11 / Chrome App Component: Other
Action Performed:
Prerequisite: Account has at least one workspace.
Open the Expensify app.
Open any workspace chat.
Create a manual expense.
Open the just created expense.
Hold and unhold the expense.
Long tap on the "Held this expense" message and select "Reply in thread"
Note that thread header shows "Held this expense"
Tap on header to navigate to details page.
Note that details page header shows "Held this money request" message,
Expected Result:
Thread header and details page header should be the same when creating a thread with a system-generated message.
Actual Result:
Thread header and details page header shows different message when creating a thread with a system-generated message of a held expense.
Thread header shows a "Held this expense" message while details page header shows a "Held this money request" message.
changed the title [-]Thread - Thread header doesn´t match details page when creating thread with system message[/-][+][$250] Thread - Thread header doesn´t match details page when creating thread with system message[/+]on Feb 10, 2026
Please re-state the problem that we are trying to solve in this issue.
Actual Result:
Thread header and details page header shows different message when creating a thread with a system-generated message of a held expense.
Thread header shows a "Held this expense" message while details page header shows a "Held this money request" message.
What is the root cause of that problem?
The root cause is that ReportDetailsPage.tsx and HeaderView.tsx use different functions to get the report name for thread reports:
HeaderView.tsx (thread header) uses getReportName() from ReportUtils.ts which dynamically computes the thread name. For HOLD actions, it calls translate('iou.heldExpense') via getReportActionMessage():
ReportDetailsPage.tsx (details page) uses getReportName() from ReportNameUtils.ts which simply returns the stored report.reportName field directly without dynamic translation:
When a thread is created from a HOLD action, the report.reportName is set from the action's message text. If this stored value differs from the dynamically translated value, the two pages show different messages.
What changes do you think we should make in order to solve the problem?
We should update ReportDetailsPage.tsx to use the same dynamic report name computation as HeaderView.tsx for consistency.
In src/pages/ReportDetailsPage.tsx:
- import {getReportName as getReportNameFromReportNameUtils} from '@libs/ReportNameUtils';+ import {getReportName as getReportNameFromReportUtils} from '@libs/ReportUtils';
This ensures both HeaderView.tsx and ReportDetailsPage.tsx use the same dynamic computation for the report name, producing consistent results for threads created from system-generated messages like HOLD actions.
What alternative solutions did you explore? (Optional)
🚨 Edited by proposal-police: This proposal was edited at 2026-02-10 16:49:08 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
Thread - Thread header doesn´t match details page when creating thread with system message
What is the root cause of that problem?
The report details page title comes from ReportNameUtils’ derived report name computeReportNameBasedOnReportAction, which did not handle HOLD/UNHOLD. The thread header (headerView) uses ReportUtils’ getReportActionMessage, which does. So these two page used different logic and showed different text.### What changes do you think we should make in order to solve the problem?
Since the getReportName form ReportUtils is depreciated, We should add
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
changed the title [-][$250] Thread - Thread header doesn´t match details page when creating thread with system message[/-][+][Due for Payment 2026-03-17] [$250] Thread - Thread header doesn´t match details page when creating thread with system message[/+]on Mar 17, 2026
Activity
melvin-bot commentedon Feb 10, 2026
Triggered auto assignment to Contributor-plus team member for initial proposal review - @ZhenjaHorbach (
External)melvin-bot commentedon Feb 10, 2026
Triggered auto assignment to @NicMendonca (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.[-]Thread - Thread header doesn´t match details page when creating thread with system message[/-][+][$250] Thread - Thread header doesn´t match details page when creating thread with system message[/+]melvin-bot commentedon Feb 10, 2026
Job added to Upwork: https://www.upwork.com/jobs/~022021249041301512388
daledah commentedon Feb 10, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
Actual Result:
Thread header and details page header shows different message when creating a thread with a system-generated message of a held expense.
Thread header shows a "Held this expense" message while details page header shows a "Held this money request" message.
What is the root cause of that problem?
The root cause is that
ReportDetailsPage.tsxandHeaderView.tsxuse different functions to get the report name for thread reports:HeaderView.tsx (thread header) uses
getReportName()fromReportUtils.tswhich dynamically computes the thread name. For HOLD actions, it callstranslate('iou.heldExpense')viagetReportActionMessage():App/src/libs/ReportUtils.ts
Lines 5637 to 5638 in 013badf
App/src/pages/inbox/HeaderView.tsx
Line 155 in 013badf
ReportDetailsPage.tsx (details page) uses
getReportName()fromReportNameUtils.tswhich simply returns the storedreport.reportNamefield directly without dynamic translation:App/src/libs/ReportNameUtils.ts
Lines 835 to 841 in 013badf
App/src/pages/ReportDetailsPage.tsx
Line 55 in 013badf
App/src/pages/ReportDetailsPage.tsx
Line 357 in 013badf
When a thread is created from a HOLD action, the
report.reportNameis set from the action's message text. If this stored value differs from the dynamically translated value, the two pages show different messages.What changes do you think we should make in order to solve the problem?
We should update
ReportDetailsPage.tsxto use the same dynamic report name computation asHeaderView.tsxfor consistency.In
src/pages/ReportDetailsPage.tsx:And update the usage:
This ensures both
HeaderView.tsxandReportDetailsPage.tsxuse the same dynamic computation for the report name, producing consistent results for threads created from system-generated messages like HOLD actions.What alternative solutions did you explore? (Optional)
N/A
samranahm commentedon Feb 10, 2026
🚨 Edited by proposal-police: This proposal was edited at 2026-02-10 16:49:08 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
Thread - Thread header doesn´t match details page when creating thread with system message
What is the root cause of that problem?
The report details page title comes from ReportNameUtils’ derived report name
computeReportNameBasedOnReportAction, which did not handleHOLD/UNHOLD. The thread header (headerView) uses ReportUtils’ getReportActionMessage, which does. So these two page used different logic and showed different text.### What changes do you think we should make in order to solve the problem?Since the
getReportNameformReportUtilsis depreciated, We should addin
computeReportNameBasedOnReportActionto keep usinggetReportNameFromReportNameUtilshere
App/src/libs/ReportNameUtils.ts
Lines 372 to 381 in 431fce2
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
ZhenjaHorbach commentedon Feb 11, 2026
Thanks for your proposals
But as for me, @daledah's proposal looks better
So I don't mind going with this proposal!
🎀👀🎀 С+
14 remaining items
ZhenjaHorbach commentedon Mar 16, 2026
@NicMendonca
We are ready for payment!
melvin-bot commentedon Mar 17, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)[-][$250] Thread - Thread header doesn´t match details page when creating thread with system message[/-][+][Due for Payment 2026-03-17] [$250] Thread - Thread header doesn´t match details page when creating thread with system message[/+]mallenexpensify commentedon Mar 17, 2026
Payment Summary
Contributor: @daledah due $250 via NewDot
Contributor+: @ZhenjaHorbach due $250 via NewDot
^ Test case created
garrettmknight commentedon Mar 18, 2026
$250 approved for @ZhenjaHorbach
garrettmknight commentedon Mar 25, 2026
$250 approved for @daledah