Skip to content

[No payment] Mark down - Message is centered when editing message #82095

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.17-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #81018
Email or phone of affected tester (no customers): sjiondjsondjoisjsojdos@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.2 / Chrome
App Component: Money Requests

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to any chat.
  3. Send the message.
  4. Right click on the sent message > Edit comment.

Expected Result:

The message will be left-aligned.

Actual Result:

The message is centered.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Bug7074468_1770803126388.Screen_Recording_2026-02-11_at_17.45.19.mov

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @inimaga
Issue OwnerCurrent Issue Owner: @lydiabarclay

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Feb 11, 2026
  2. melvin-bot commented on Feb 11, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #81018

  3. melvin-bot commented on Feb 11, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  4. melvin-bot commented on Feb 11, 2026

    @melvin-bot

    Triggered auto assignment to @lydiabarclay (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. github-actions commented on Feb 11, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. OSBotify commented on Feb 11, 2026

    @OSBotify
    Contributor

    Investigation Summary

    Classification: Frontend bug (App)
    Causing PR: Unable to identify with high confidence
    Current Status: Needs Investigation

    Recommendation: NEEDS INVESTIGATION

    The issue reports that messages are centered instead of left-aligned when editing. While the issue was discovered during regression testing of PR #81018 (emoji code block handling), my investigation found that #81018 did not modify any styling or alignment code - it only changed emoji replacement logic in EmojiUtils.tsx and SuggestionEmoji.tsx.

    The bug is only reproducible on staging, not production, which confirms it was introduced by a PR in the current deploy (9.3.17-0). However, after reviewing the modified files in #81018 and checking recent changes to ReportActionItemMessageEdit.tsx (the component responsible for editing messages), I could not find any obvious styling changes that would cause centering.

    Evidence

    • PR fix: code block not displayed for ASCII characters #81018 changes: EmojiUtils.tsx, SuggestionEmoji.tsx, and test files only
    • No modifications to ReportActionItemMessageEdit.tsx, styles/index.ts (for chat message styles), or any alignment-related code
    • The editing component uses styles.chatItemMessage and styles.flexRow at line 487
    • Bug is staging-only, indicating a recent regression

    Next Steps

    1. Need visual confirmation: Review the video/screenshot in the issue to understand exactly what "centered" means in this context
    2. Compare with production: Check if there were style changes to chatItemMessage, flexRow, chatItemComposeBox, or textInputCompose styles
    3. Review other PRs in this deploy: Check PRs that modified styles or composer-related components beyond fix: code block not displayed for ASCII characters #81018

    Labels: No label changes made. Keeping both DeployBlockerCash and DeployBlocker until root cause is identified.

    @TaduJR @mitarachim - Can you help clarify which specific PR introduced this issue? The regression was found while testing #81018, but that PR does not contain styling changes that would cause this alignment bug.

  7. 25 remaining items

  8. melvin-bot commented on Feb 13, 2026

    @melvin-bot

    @inimaga @lydiabarclay The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  9. brianlee-expensify commented on Feb 19, 2026

    @brianlee-expensify
    Contributor

    payment still needs to be made for this, reopening (CC @lydiabarclay)

    @mallenexpensify would love your thoughts on the payments for the following GHs:

  10. lydiabarclay commented on Feb 19, 2026

    @lydiabarclay
    Contributor

    Pinged in Slack

  11. mallenexpensify commented on Feb 20, 2026

    @mallenexpensify
    Contributor

    Weird edge case here, payment won't be due here so we'll sort elsewhere if needed. thx

    actually... @situchan, might you be due compensation for helping to find the offending PR? We don't have a normal process for that but you mentioned it took you a while and you found #82124 too.

    hmmm

  12. situchan commented on Feb 20, 2026

    @situchan
    Contributor

    It's true that this was hard investigation to find the offending PR.
    @mallenexpensify I'll defer to you whether I am eligible payment or not. I am fine either way. Thanks

  13. melvin-bot commented on Feb 20, 2026

    @melvin-bot

    Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

  14. mallenexpensify commented on Feb 20, 2026

    @mallenexpensify
    Contributor

    Thanks @situchan , we appreciate the help here. I don't want to set precedence for paying to help find regressions, especially right now with a lot of changes happening, so I'm going to close this out and ping you 1:1 about summin. Thanks again

  15. changed the title [-][Due for payment 2026-02-20] Mark down - Message is centered when editing message[/-] [+][No payment] Mark down - Message is centered when editing message[/+] on Feb 20, 2026
  16. situchan commented on Feb 26, 2026

    @situchan
    Contributor

    accessibilityRole={CONST.ROLE.BUTTON}

    A bit late but the offending line (which caused 2 regressions) also caused another regression:

    #37447 (comment)

    This should have been reverted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions