Skip to content

[Due for payment 2026-04-07] [$250] From Home, take member to the report directly vs reports page, depending on number of reports #82102

Closed

Description

@JmillsExpensify

In order to avoid an extra click for the one report case, while still giving approvers the ability to pick and choose specific reports to approve in the case of many reports, we'll update the behavior of the Begin button on the Home page.

Image

The product spec is:

  • This behavior is specific to the Home page
  • The Begin button can appear for the submit/approve/pay/export report actions
  • When there is only one report, Begin will take the user directly to the report thread
    • On desktop, this means the user will see the "super wide" report modal
    • On mobile, this means the user will see the full screen report
  • When there is more than one report, Begin will take the user to the relevant filter, where they're able to pick the first report they action on. The relevant pages are:
    • Reports > To-do > Submit
    • Reports > To-do > Approve
    • Reports > To-do > Pay
    • Reports > To-do > Export
Issue OwnerCurrent Issue Owner: @mallenexpensify
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~022021536811613994415
  • Upwork Job ID: 2021536811613994415
  • Last Price Increase: 2026-02-11

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    NewFeatureSomething to build that is a new item.
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 11, 2026
  2. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 11, 2026
  3. melvin-bot commented on Feb 11, 2026

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @truph01 (External)

  4. melvin-bot commented on Feb 11, 2026

    @melvin-bot

    Current assignee @JmillsExpensify is eligible for the NewFeature assigner, not assigning anyone new.

  5. melvin-bot commented on Feb 11, 2026

    @melvin-bot

    Current assignee @JmillsExpensify is eligible for the Bug assigner, not assigning anyone new.

  6. 43 remaining items

  7. melvin-bot commented on Mar 31, 2026

    @melvin-bot

    @truph01 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  8. melvin-bot commented on Mar 31, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  9. mallenexpensify commented on Apr 7, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor: @mukhrr due $250 via Upwork
    Contributor+: @truph01 due $250 via NewDot

    @mukhrr can you please accept the job below? Please reply here and tag me once you have.
    https://www.upwork.com/jobs/~022041544607600656116

    @truph01 plz complete the BZ checklist and tag me in a post once you have. Thx

  10. mukhrr commented on Apr 7, 2026

    @mukhrr
    Contributor

    @mallenexpensify, accepted them

  11. melvin-bot commented on Apr 7, 2026

    @melvin-bot

    Payment Summary

    Upwork Job

    • ROLE: @mukhrr paid $(AMOUNT) via Upwork (LINK)
    • Reviewer: @truph01 owed $250 via NewDot

    BugZero Checklist (@mallenexpensify)

    • (if NewFeature) I have created a PR for any necessary HelpDot updates, or I confirmed no updates are necessary.
    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/2021536811613994415/hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  12. JmillsExpensify commented on Apr 8, 2026

    @JmillsExpensify
    ContributorAuthor

    Paid out contributor and regression test created, so closing this one. We still have the pending task from @truph01

  13. truph01 commented on May 5, 2026

    @truph01
    Contributor

    BugZero Checklist:

    • [Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to the comment on the PR:
      Link to the comment on the Issue:

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Precondition:

    Test:

    1. Create a report with an expense -> Submit
    2. Create two reports with expenses for each
    3. Go to Home page
    4. Verify you see two rows:
    • Submit 2 reports
    • Approve 1 report
    1. Click Begin button of Approve
    2. Verify Report is opened as RHP -> close it
    3. Click Begin button of Submit
    4. Verify you go to Report/Submit page

    Also:

    1. Create Report through Create button on Reports page
    2. Delete it
    3. Verify you are still Report page

    Do we agree 👍 or 👎

  14. garrettmknight commented on May 22, 2026

    @garrettmknight
    Contributor

    $250 approved for @truph01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributorNewFeatureSomething to build that is a new item.

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions