Skip to content

Time - Confirm page opens instead of Merchant page after clearing merchant field #82107

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.17-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #80480
Email or phone of affected tester (no customers): josidjnoidjoisjisod@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.2 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • Time tracking is enabled in the workspace.
  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Create a time expense.
  4. Open the time expense.
  5. Click Report > Remove from report.
  6. Go to self DM.
  7. Open the time expense.
  8. Click on the header > Submit it to someone.
  9. Enter email and select user.
  10. On confirm page, click Merchant.
  11. Clear the merchant and save it.
  12. Click RHP back button.
  13. Select workspace chat.

Expected Result:

Merchant page will open.

Actual Result:

Confirm page opens.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Bug7074503_1770805118934.4.mp4

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Feb 11, 2026
  2. melvin-bot commented on Feb 11, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #80480

  3. melvin-bot commented on Feb 11, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  4. melvin-bot commented on Feb 11, 2026

    @melvin-bot

    Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. github-actions commented on Feb 11, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. OSBotify commented on Feb 11, 2026

    @OSBotify
    Contributor

    🔍 Investigation Summary

    Classification: Frontend bug
    Causing PR: #80480 - "Update create transaction Manual flow to ask for merchant after asking for amount v2" by @nkdengineer (High confidence)
    Related Issues: None

    Recommendation: REVERT

    PR #80480 introduced complex navigation changes for the merchant step in the manual expense flow. The bug occurs when moving a time expense between reports and clearing the merchant field - the navigation logic does not properly handle the back navigation, causing the confirmation page to open instead of the merchant page.

    Given the complexity of the navigation flow changes and the specific edge case affected, a revert is the safest approach to unblock the deploy while the navigation logic is fixed properly.

    Labels: Keeping DeployBlockerCash (App deploy is blocked). Removing DeployBlocker (no backend changes involved).

    📋 Detailed Analysis

    Evidence

    The bug follows this exact reproduction path:

    1. Create time expense in workspace chat
    2. Remove from report (moves to self DM)
    3. Submit to workspace chat (triggers merchant step per new flow)
    4. Clear merchant field and save
    5. Click back button on confirmation page
    6. Bug: Confirmation page opens instead of merchant page

    This specific flow was introduced/modified in PR #80480 which changed when and how the merchant step appears in the expense creation flow.

    Verification

    PR #80480 modified these files:

    • src/pages/iou/request/step/IOURequestStepMerchant.tsx - Added navigation logic after save (lines 97-101)
    • src/pages/iou/request/step/IOURequestStepAmount.tsx - Added shouldRequireMerchant checks
    • src/pages/iou/request/step/IOURequestStepParticipants.tsx - Added merchant step navigation
    • src/libs/IOUUtils.ts - Added shouldRequireMerchant function

    The merchant step component has a useFocusEffect hook (lines 85-90) that resets state, and navigation logic (lines 92-102) that determines next screen. When backTo parameter exists and merchant is cleared, the navigation does not properly maintain the merchant step in the back stack.

    Root Cause

    In IOURequestStepMerchant.tsx lines 97-101:

    if (!isEditing && !backTo) {
        Navigation.navigate(ROUTES.MONEY_REQUEST_STEP_CONFIRMATION.getRoute(...));
        return;
    }
    navigateBack();

    When merchant is cleared and saved during the "submit to workspace" flow, the backTo parameter exists, causing the code to call navigateBack() instead of explicitly navigating to confirmation. However, the back navigation stack is not properly configured for this edge case, resulting in incorrect page being shown on subsequent back button press.

  7. 7 remaining items

  8. lakchote commented on Feb 11, 2026

    @lakchote
    Contributor

    @nkdengineer can you link the PR here please?

  9. nkdengineer commented on Feb 11, 2026

    @nkdengineer
    Contributor

    @lakchote, We reverted the offending PR, so I closed my PR.

  10. self-assigned this
    on Feb 11, 2026
  11. cead22 commented on Feb 11, 2026

    @cead22
    Contributor

    Looks like the offending PR got reverted, so we can probably close this

  12. m-natarajan commented on Feb 11, 2026

    @m-natarajan

    Reproduced, Windows 11 / Chrome, v9.3.17-5 9Waiting for the validation results for other platform)

    confirm.page.mp4
  13. lakchote commented on Feb 11, 2026

    @lakchote
    Contributor

    cc @nkdengineer @cead22 looks like it's still reproducible?

  14. nkdengineer commented on Feb 11, 2026

    @nkdengineer
    Contributor

    @lakchote It's not a bug now since the PR was reverted and merchant step is not a step before confirmation step now.

  15. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Feb 11, 2026
  16. lakchote commented on Feb 11, 2026

    @lakchote
    Contributor

    We can close this then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions