You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$250] Merchant rules - Preview matches do not display the receipt preview #82175
Version Number: v9.3.17-5 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#81033 Email or phone of affected tester (no customers): N/A Issue reported by: Applause Internal Team Bug source: Pull Request QA execution Device used: Windows 11, Chrome | iPhone SE 3rd generation, Tahoe 26.2.1 | Samsung A15, Android 16 App Component: Workspace Settings
Action Performed:
Preconditions:
User is an admin of a workspace with rules enabled.
changed the title [-]Merchant rules - Preview matches do not display the receipt preview[/-][+][$250] Merchant rules - Preview matches do not display the receipt preview[/+]on Feb 11, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #80758 - "[NO QA] Add preview expenses to merchant rules" by @JS00001 (High confidence) Related Issues: None
Recommendation: ROLL FORWARD
The bug exists in the PreviewMatchesPage component which passes raw Transaction objects to UnreportedExpenseListItem, but the component expects TransactionListItemType (which includes ListItem properties like keyForList, text, etc.). This causes the receipt thumbnails to not display properly because TransactionItemRow cannot access the necessary display properties.
Rolling forward with a fix is recommended because:
Lines 260-287 define TransactionListItemType which extends both ListItem and Transaction
ListItem type (lines 142-239) includes properties like keyForList, text, icons, etc. that are not present in raw Transaction objects
Root Cause
The PreviewMatchesPage fetches Transaction objects from ONYXKEYS.COLLECTION.CODING_RULE_MATCHING_TRANSACTION and passes them directly to UnreportedExpenseListItem without converting them to TransactionListItemType. The UnreportedExpenseListItem then passes these to TransactionItemRow which expects the full TransactionListItemType interface with all ListItem properties populated. Without these properties, the TransactionItemRow cannot properly render the receipt thumbnails and other display elements.
The bug was introduced in PR #80758 but only became visible to users when PR #81033 removed the production environment check on 2026-02-10, enabling merchant rules for all users.
PR #81033 only removed 6 lines of code that checked isProduction and returned null. It did not introduce any new logic or modify how the PreviewMatchesPage works. The bug already existed in the codebase from PR #80758, but was hidden behind the production flag.
My read: this is documentation-focused work for "[$250] Merchant rules - Preview matches do not display the receipt preview".
I will focus on these issue-specific points first: merchant, rules, preview.
Confirm audience and acceptance criteria, then draft reproducible steps.
Add concrete examples and edge cases so contributors can follow directly.
Keep progress updates clear (24h for scoped implementation plan, 48h+ for full patch and validation).
If this scope looks good, I can begin right away.
Activity
melvin-bot commentedon Feb 11, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #81033
melvin-bot commentedon Feb 11, 2026
💬 A slack conversation has been started in #expensify-open-source
melvin-bot commentedon Feb 11, 2026
Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (
External)melvin-bot commentedon Feb 11, 2026
Triggered auto assignment to @laurenreidexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.[-]Merchant rules - Preview matches do not display the receipt preview[/-][+][$250] Merchant rules - Preview matches do not display the receipt preview[/+]melvin-bot commentedon Feb 11, 2026
Job added to Upwork: https://www.upwork.com/jobs/~022021668705202993626
1 remaining item
github-actions commentedon Feb 11, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon Feb 11, 2026
Investigation Summary
Classification: Frontend bug
Causing PR: #80758 - "[NO QA] Add preview expenses to merchant rules" by @JS00001 (High confidence)
Related Issues: None
Recommendation: ROLL FORWARD
The bug exists in the PreviewMatchesPage component which passes raw Transaction objects to UnreportedExpenseListItem, but the component expects TransactionListItemType (which includes ListItem properties like keyForList, text, etc.). This causes the receipt thumbnails to not display properly because TransactionItemRow cannot access the necessary display properties.
Rolling forward with a fix is recommended because:
Labels: Keeping DeployBlockerCash - this is a frontend bug in the App repository that needs to be fixed before deploying to production.
Detailed Analysis
Evidence
PR #80758 created the PreviewMatchesPage component on 2026-01-29. The code at lines 70-76 shows:
The Transaction object from Onyx is passed directly to UnreportedExpenseListItem without transformation.
Verification
File: /home/runner/_work/App/App/src/pages/workspace/rules/MerchantRules/PreviewMatchesPage.tsx
File: /home/runner/_work/App/App/src/components/SelectionListWithSections/types.ts
Root Cause
The PreviewMatchesPage fetches Transaction objects from
ONYXKEYS.COLLECTION.CODING_RULE_MATCHING_TRANSACTIONand passes them directly to UnreportedExpenseListItem without converting them to TransactionListItemType. The UnreportedExpenseListItem then passes these to TransactionItemRow which expects the full TransactionListItemType interface with all ListItem properties populated. Without these properties, the TransactionItemRow cannot properly render the receipt thumbnails and other display elements.The bug was introduced in PR #80758 but only became visible to users when PR #81033 removed the production environment check on 2026-02-10, enabling merchant rules for all users.
Why PR #81033 is Not the Cause
PR #81033 only removed 6 lines of code that checked
isProductionand returned null. It did not introduce any new logic or modify how the PreviewMatchesPage works. The bug already existed in the codebase from PR #80758, but was hidden behind the production flag.luacmartins commentedon Feb 11, 2026
BE PR in review. This is NAB.
luacmartins commentedon Feb 12, 2026
Fixed by https://github.com/Expensify/Auth/pull/19896
zhanglin2603 commentedon Feb 13, 2026
Hey, I went over #82175 and can take this on.
If this scope looks good, I can begin right away.