You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-03-02] Expense - "Only the oldest matching rule will apply" is not shown in save rule dialog box. #82239
Version Number: V9.3.17-6 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#81033 Email or phone of affected tester (no customers):dreamnitethedragon@gmail.com Issue reported by: Applause Internal Team Bug source: Pull Request QA execution Device used: Redminote 10S Android 13 App Component: Money Requests
Action Performed:
Launch app
Login as new gmail account
Create a workspace
Enable rules and create a merchant rule
Merchant Uber (contains)
Update category to any
Go to workspace chat
Create an expense with merchant Uber
Navigate back to merchant rules
Add another merchant rule with same merchant
Merchant Uber (contains)
Update category to any
Tap save rule
Expected Result:
"Only the oldest matching rule will apply" must be shown in save rule dialog box.
Actual Result:
"Only the oldest matching rule will apply" is not shown in save rule dialog box.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: Not applicable - This is a missing feature, not a regression from PR #81033 Related PRs: #80545 (original merchant rules implementation), #81033 (enabled merchant rules for all users)
Recommendation: ROLL FORWARD
This is not a regression introduced by PR #81033. The duplicate merchant rule warning dialog works correctly, but the prompt text is missing important information. The current text says:
"Do you want to save a new rule for "{merchantName}" even though you already have an existing one?"
But according to the test plan and help documentation, it should also mention: "Only the oldest matching rule will apply."
This is a simple text update to the translations file. Rolling forward with a text fix is much simpler than reverting PR #81033.
Labels: Removing DeployBlockerCash because:
This is not reproducible in production (new feature that does not exist in prod)
The duplicate check functionality works correctly - only the informational text is incomplete
This does not block the App deploy since it is a minor UX polish issue, not a broken feature
📋 Detailed Analysis
Evidence
The duplicate rule check is implemented and working in /home/runner/_work/App/App/src/pages/workspace/rules/MerchantRules/MerchantRulePageBase.tsx (lines 165-189, 214-228). When a duplicate is detected, it shows a confirmation modal using showConfirmModal with:
I verified the translation in /home/runner/_work/App/App/src/languages/en.ts line 6374:
duplicateRulePrompt: (merchantName: string)=>`Do you want to save a new rule for "${merchantName}" even though you already have an existing one?`,
The help documentation at /home/runner/_work/App/App/docs/articles/new-expensify/workspaces/Workspace-Merchant-Rules.md line 46 states:
If multiple Workspace Merchant Rules match the same expense, only the earliest-created rule applies.
Root Cause
The duplicate warning dialog was implemented in PR #80545 but the prompt text never included the clarification about rule precedence. PR #81033 simply enabled the feature for all users by removing the production gate - it did not introduce or cause this issue.
Fix Required
Update duplicateRulePrompt in all language files to include information about rule precedence. Example:
duplicateRulePrompt: (merchantName: string)=>`Do you want to save a new rule for "${merchantName}" even though you already have an existing one? Only the oldest matching rule will apply.`,
changed the title [-]Expense - "Only the oldest matching rule will apply" is not shown in save rule dialog box.[/-][+][Due for payment 2026-03-02] Expense - "Only the oldest matching rule will apply" is not shown in save rule dialog box.[/+]on Feb 23, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.24-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@luacmartins@JmillsExpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon Feb 12, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #81033
melvin-bot commentedon Feb 12, 2026
💬 A slack conversation has been started in #expensify-open-source
melvin-bot commentedon Feb 12, 2026
Triggered auto assignment to @sonialiap (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.github-actions commentedon Feb 12, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon Feb 12, 2026
🔍 Investigation Summary
Classification: Frontend bug
Causing PR: Not applicable - This is a missing feature, not a regression from PR #81033
Related PRs: #80545 (original merchant rules implementation), #81033 (enabled merchant rules for all users)
Recommendation: ROLL FORWARD
This is not a regression introduced by PR #81033. The duplicate merchant rule warning dialog works correctly, but the prompt text is missing important information. The current text says:
But according to the test plan and help documentation, it should also mention: "Only the oldest matching rule will apply."
This is a simple text update to the translations file. Rolling forward with a text fix is much simpler than reverting PR #81033.
Labels: Removing
DeployBlockerCashbecause:📋 Detailed Analysis
Evidence
The duplicate rule check is implemented and working in
/home/runner/_work/App/App/src/pages/workspace/rules/MerchantRules/MerchantRulePageBase.tsx(lines 165-189, 214-228). When a duplicate is detected, it shows a confirmation modal usingshowConfirmModalwith:workspace.rules.merchantRules.duplicateRuleTitleworkspace.rules.merchantRules.duplicateRulePromptVerification
I verified the translation in
/home/runner/_work/App/App/src/languages/en.tsline 6374:The help documentation at
/home/runner/_work/App/App/docs/articles/new-expensify/workspaces/Workspace-Merchant-Rules.mdline 46 states:Root Cause
The duplicate warning dialog was implemented in PR #80545 but the prompt text never included the clarification about rule precedence. PR #81033 simply enabled the feature for all users by removing the production gate - it did not introduce or cause this issue.
Fix Required
Update
duplicateRulePromptin all language files to include information about rule precedence. Example:20 remaining items
JmillsExpensify commentedon Feb 21, 2026
Works for me as well.
[-]Expense - "Only the oldest matching rule will apply" is not shown in save rule dialog box.[/-][+][Due for payment 2026-03-02] Expense - "Only the oldest matching rule will apply" is not shown in save rule dialog box.[/+]melvin-bot commentedon Feb 23, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Feb 23, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.24-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-03-02. 🎊
melvin-bot commentedon Feb 23, 2026
@luacmartins @JmillsExpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
JmillsExpensify commentedon Feb 24, 2026
@situchan you're being paid in one lump payment for this project, right?
situchan commentedon Feb 24, 2026
right. this can be closed