Skip to content

[Due for payment 2026-02-23] Navigation is repeated when returning from per diem confirm page with at least two workspaces #82333

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.18-2
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #78109
Email or phone of affected tester (no customers): sdoisjdionjsidojisj@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.2 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • Create two workspaces.
  • Import per diem rates to both workspaces.
  1. Go to staging.new.expensify.com
  2. Go to self DM.
  3. Click + > Create expense > Per diem.
  4. Select any workspace.
  5. Select any details and reach confirm page.
  6. On confirm page, click RHP back button three times.
  7. Click RHP back button again.

Expected Result:

RHP will return to per diem initial page.

Actual Result:

RHP reopens subrate page, then back button returns to time and destination page.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Bug7076283_1770930249467.14.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @dylanexpensify

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Feb 12, 2026
  2. melvin-bot commented on Feb 12, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #78109

  3. melvin-bot commented on Feb 12, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  4. melvin-bot commented on Feb 12, 2026

    @melvin-bot

    Triggered auto assignment to @heyjennahay (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. github-actions commented on Feb 12, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. OSBotify commented on Feb 12, 2026

    @OSBotify
    Contributor

    🔍 Investigation Summary

    Classification: Frontend bug
    Causing PR: #78109 - "Enable creating per diem expense from self dm" by @koko57 (High confidence)
    Related Issues: None found

    Recommendation: REVERT

    This PR introduced the ability to create per diem expenses from self DM. The navigation regression appears to be caused by changes to the back button handling in the per diem flow, particularly in the confirmation step and related navigation pages.

    A revert is recommended because:

    • The causing PR is clear and recent (merged 2026-02-11)
    • The feature is new and does not exist in production, so reverting will not affect production users
    • A clean revert is preferred to ensure the navigation flow works correctly

    Labels: Removed DeployBlocker label. Kept DeployBlockerCash as this is a frontend bug in the App that blocks the mobile deployment.

    📋 Detailed Analysis

    Evidence

    PR #78109 was explicitly called out in the issue description under "If this was caught during regression testing, add the test name, ID and link from BrowserStack". Additionally, melvin-bot automatically assigned this issue to the PR author.

    The issue describes a navigation problem when pressing the back button multiple times from the per diem confirmation page:

    • Expected: RHP returns to per diem initial page
    • Actual: RHP reopens subrate page, then back button returns to time and destination page

    This indicates the navigation stack is not being managed correctly when moving backwards through the per diem flow.

    Verification

    PR #78109 modifies the following files that are directly involved in this navigation flow:

    • src/pages/iou/request/step/IOURequestStepConfirmation.tsx (91 additions, 57 deletions) - The confirmation page where users press back
    • src/pages/iou/request/step/IOURequestStepPerDiemWorkspace.tsx (18 additions, 11 deletions) - Initial workspace selection
    • src/pages/iou/request/step/IOURequestStepSubrate.tsx (11 additions, 3 deletions) - Subrate selection page that incorrectly reopens
    • src/pages/iou/request/step/IOURequestStepTime.tsx (15 additions, 4 deletions) - Time selection page
    • src/pages/iou/request/step/IOURequestStepDestination.tsx (9 additions, 2 deletions) - Destination page

    The PR added new navigation logic to support creating per diem expenses from self DM, which introduced this regression in the back button behavior when multiple workspaces are present.

    Root Cause

    The PR added support for per diem expenses in self DM with workspace selection (when user has 2+ workspaces with per diem enabled). The navigation stack management for the back button was not properly updated to account for this new flow, causing the navigation to repeat steps when going backwards from the confirmation page.

    Specifically, the changes to IOURequestStepConfirmation.tsx modified how per diem submissions are handled (adding submitPerDiemExpenseForSelfDM for track expenses), and the changes to the step pages altered the navigation flow. The back button logic appears to not correctly pop the navigation stack when returning from the confirmation page in the multi-workspace scenario.

  7. 5 remaining items

  8. melvin-bot commented on Feb 13, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  9. koko57 commented on Feb 13, 2026

    @koko57
    Contributor

    PR ready for review #82400

  10. IuliiaHerets commented on Feb 13, 2026

    @IuliiaHerets

    Windows 10/ Chrome
    v9.3.18-8
    Not Repro

    repro-.issue.82333.mp4
  11. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Feb 16, 2026
  12. changed the title [-]Navigation is repeated when returning from per diem confirm page with at least two workspaces[/-] [+][Due for payment 2026-02-23] Navigation is repeated when returning from per diem confirm page with at least two workspaces[/+] on Feb 16, 2026
  13. melvin-bot commented on Feb 16, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  14. melvin-bot commented on Feb 16, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.19-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-02-23. 🎊

    For reference, here are some details about the assignees on this issue:

    • @parasharrajat requires payment through NewDot Manual Requests
    • @koko57 does not require payment (Contractor)
  15. melvin-bot commented on Feb 16, 2026

    @melvin-bot

    @parasharrajat @dylanexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions