You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-02-27] "Hmm... Its not here" page displays after trying changing Tag's name #82336
Version Number: 9.3.18-0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from BrowserStack:#81128 Email or phone of affected tester (no customers):jsat+testnn@applausemail.com Issue reported by: Applause Internal Team Bug source: Pull Request QA execution Device used: Macbook Pro/iOS 13.7.8, iPhone 13/18.6.2 App Component: Workspace Settings
Action Performed:
Launch Expensify app and login with valid credentials
Create a new WorkSpace
Select More features > enable Tags
Open tags page add some tags
Enable Simulate failing network requests
Select a tag just create and change the name
Expected Result:
The tag's name is not changed and an error message: "An error occurred while updating the tag, please try again" is displayed evenly spaced between the two items
Actual Result:
"Hmm... Its not here" page displays after trying changing Tag's name. The tag's name is not changed and an error message: "An error occurred while updating the tag, please try again" is displayed evenly spaced between the two items
After the optimistic update is rolled back, TagSettingsPage has the new tag name in route params (updated by the useEffect) but can't find the tag because the old tag doesn't have previousTagName set to the new name anymore. The lookup at this line fails and NotFound page is shown.
What alternative solutions did you explore? (Optional)
Prevent the useEffect from updating route params when there's a pending name change, so the route params stay at the original tag name until the rename succeeds.
I have a question, I still see the NotFoundPage, if I cleared the tag error, then turned on the offline mode and edited it with a different name then Go back online. I'll see the NotFoundPage again. Could you double check?
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.23-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@hungvu193@JmillsExpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
nyomanjyotisa commentedon Feb 13, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
"Hmm... Its not here" page displays after trying changing Tag's name when the network request fails
What is the root cause of that problem?
When
renamePolicyTagfails, the failure data restores the old tag without settingpreviousTagName.App/src/libs/actions/Policy/Tag.ts
Lines 671 to 679 in 7ccc11c
After the optimistic update is rolled back,
TagSettingsPagehas the new tag name in route params (updated by the useEffect) but can't find the tag because the old tag doesn't havepreviousTagNameset to the new name anymore. The lookup at this line fails and NotFound page is shown.App/src/pages/workspace/tags/TagSettingsPage.tsx
Lines 61 to 76 in 7ccc11c
What changes do you think we should make in order to solve the problem?
Add
previousTagNameto the failure data inrenamePolicyTagsoTagSettingsPagecan find the tag after rollback.App/src/libs/actions/Policy/Tag.ts
Lines 671 to 679 in 7ccc11c
What alternative solutions did you explore? (Optional)
Prevent the useEffect from updating route params when there's a pending name change, so the route params stay at the original tag name until the rename succeeds.
App/src/pages/workspace/tags/TagSettingsPage.tsx
Lines 67 to 72 in 7ccc11c
melvin-bot commentedon Feb 13, 2026
Triggered auto assignment to @JmillsExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Feb 13, 2026
Triggered auto assignment to Contributor-plus team member for initial proposal review - @hungvu193 (
External)JmillsExpensify commentedon Feb 13, 2026
OP expense result sounds right to me.
melvin-bot commentedon Feb 13, 2026
Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.
hungvu193 commentedon Feb 13, 2026
@nyomanjyotisa Your main solution looks good to me.
I have a question, I still see the NotFoundPage, if I cleared the tag error, then turned on the offline mode and edited it with a different name then Go back online. I'll see the NotFoundPage again. Could you double check?
Screen.Recording.2026-02-13.at.23.24.49.mov
16 remaining items
melvin-bot commentedon Feb 20, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.23-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-02-27. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Feb 20, 2026
@hungvu193 @JmillsExpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
JmillsExpensify commentedon Feb 21, 2026
Everyone is paid through manual requests, so closing the Upwork job and including the payment summary below.
JmillsExpensify commentedon Feb 21, 2026
Payment summary:
twisterdotcom commentedon Feb 27, 2026
@hungvu193 has submitted payment for this report on ND here.
SO: https://stackoverflowteams.com/c/expensify/questions/7582
Zapier Logs
Run ID: 00040eee-b75f-a4ff-233d-966e5fffcc34JmillsExpensify commentedon Mar 3, 2026
Regression test created so closing this one out.
trjExpensify commentedon May 29, 2026
approved $250 for @nyomanjyotisa