Skip to content

[Due for payment 2026-02-27] "Hmm... Its not here" page displays after trying changing Tag's name #82336

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.18-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #81128
Email or phone of affected tester (no customers): jsat+testnn@applausemail.com
Issue reported by: Applause Internal Team
Bug source: Pull Request QA execution
Device used: Macbook Pro/iOS 13.7.8, iPhone 13/18.6.2
App Component: Workspace Settings

Action Performed:

  1. Launch Expensify app
and login with valid credentials
  2. Create a new WorkSpace
  3. Select More features > enable Tags
  4. Open tags page add some tags
  5. Enable Simulate failing network requests
  6. Select a tag just create and change the name

Expected Result:

The tag's name is not changed and an error message: "An error occurred while updating the tag, please try again" is displayed evenly spaced between the two items

Actual Result:

"Hmm... Its not here" page displays after trying changing Tag's name. The tag's name is not changed and an error message: "An error occurred while updating the tag, please try again" is displayed evenly spaced between the two items

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Bug7076293_1770930608091.pr-web.mp4
Bug7076293_1770930608104.PR-IOS.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @JmillsExpensify

Activity

  1. nyomanjyotisa commented on Feb 13, 2026

    @nyomanjyotisa
    Member

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    "Hmm... Its not here" page displays after trying changing Tag's name when the network request fails

    What is the root cause of that problem?

    When renamePolicyTag fails, the failure data restores the old tag without setting previousTagName.

    [oldTagName]: {
    ...tag,
    pendingAction: null,
    pendingFields: {
    ...tag.pendingFields,
    name: null,
    },
    errors: ErrorUtils.getMicroSecondOnyxErrorWithTranslationKey('workspace.tags.genericFailureMessage'),
    },

    After the optimistic update is rolled back, TagSettingsPage has the new tag name in route params (updated by the useEffect) but can't find the tag because the old tag doesn't have previousTagName set to the new name anymore. The lookup at this line fails and NotFound page is shown.

    const currentPolicyTag = hasDependentTags
    ? Object.values(policyTag.tags ?? {}).find((tag) => tag?.name === tagName && tag.rules?.parentTagsFilter === parentTagsFilter)
    : (policyTag.tags[tagName] ?? Object.values(policyTag.tags ?? {}).find((tag) => tag.previousTagName === tagName));
    const shouldPreventDisableOrDelete = isDisablingOrDeletingLastEnabledTag(policyTag, [currentPolicyTag]);
    useEffect(() => {
    if (currentPolicyTag?.name === tagName || !currentPolicyTag) {
    return;
    }
    navigation.setParams({tagName: currentPolicyTag?.name});
    }, [tagName, currentPolicyTag, navigation]);
    if (!currentPolicyTag) {
    return <NotFoundPage />;
    }

    What changes do you think we should make in order to solve the problem?

    Add previousTagName to the failure data in renamePolicyTag so TagSettingsPage can find the tag after rollback.

                                [oldTagName]: {
                                    ...tag,
                                    pendingAction: null,
                                    pendingFields: {
                                        ...tag.pendingFields,
                                        name: null,
                                    },
                                    errors: ErrorUtils.getMicroSecondOnyxErrorWithTranslationKey('workspace.tags.genericFailureMessage'),
                                    previousTagName: newTagName,
                                },

    [oldTagName]: {
    ...tag,
    pendingAction: null,
    pendingFields: {
    ...tag.pendingFields,
    name: null,
    },
    errors: ErrorUtils.getMicroSecondOnyxErrorWithTranslationKey('workspace.tags.genericFailureMessage'),
    },

    What alternative solutions did you explore? (Optional)

    Prevent the useEffect from updating route params when there's a pending name change, so the route params stay at the original tag name until the rename succeeds.

        useEffect(() => {
            if (currentPolicyTag?.name === tagName || !currentPolicyTag || currentPolicyTag.pendingFields?.name) {
                return;
            }
            navigation.setParams({tagName: currentPolicyTag?.name});
        }, [tagName, currentPolicyTag, navigation]);

    useEffect(() => {
    if (currentPolicyTag?.name === tagName || !currentPolicyTag) {
    return;
    }
    navigation.setParams({tagName: currentPolicyTag?.name});
    }, [tagName, currentPolicyTag, navigation]);

  2. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 13, 2026
  3. melvin-bot commented on Feb 13, 2026

    @melvin-bot

    Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Feb 13, 2026
  5. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 13, 2026
  6. melvin-bot commented on Feb 13, 2026

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @hungvu193 (External)

  7. JmillsExpensify commented on Feb 13, 2026

    @JmillsExpensify
    Contributor

    OP expense result sounds right to me.

  8. melvin-bot commented on Feb 13, 2026

    @melvin-bot

    Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.

  9. hungvu193 commented on Feb 13, 2026

    @hungvu193
    Contributor

    @nyomanjyotisa Your main solution looks good to me.

    I have a question, I still see the NotFoundPage, if I cleared the tag error, then turned on the offline mode and edited it with a different name then Go back online. I'll see the NotFoundPage again. Could you double check?

    Screen.Recording.2026-02-13.at.23.24.49.mov
  10. 16 remaining items

  11. melvin-bot commented on Feb 20, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.23-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-02-27. 🎊

    For reference, here are some details about the assignees on this issue:

    • @hungvu193 requires payment through NewDot Manual Requests
    • @nyomanjyotisa requires payment through NewDot Manual Requests
  12. melvin-bot commented on Feb 20, 2026

    @melvin-bot

    @hungvu193 @JmillsExpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  13. JmillsExpensify commented on Feb 21, 2026

    @JmillsExpensify
    Contributor

    Everyone is paid through manual requests, so closing the Upwork job and including the payment summary below.

  14. JmillsExpensify commented on Feb 21, 2026

    @JmillsExpensify
    Contributor

    Payment summary:

  15. twisterdotcom commented on Feb 27, 2026

    @twisterdotcom
    Contributor

    @hungvu193 has submitted payment for this report on ND here.

    SO: https://stackoverflowteams.com/c/expensify/questions/7582

    Zapier Logs Run ID: 00040eee-b75f-a4ff-233d-966e5fffcc34
  16. JmillsExpensify commented on Mar 3, 2026

    @JmillsExpensify
    Contributor

    Regression test created so closing this one out.

  17. trjExpensify commented on May 29, 2026

    @trjExpensify
    Contributor

    approved $250 for @nyomanjyotisa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions