You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-02-23] Domains - When invited member is auto deselected, dropdown button still shows "1 selected" #82352
Version Number: 9.3.18-2 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#81527 Email or phone of affected tester (no customers):applausetester@applause.expensifail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.2 / Chrome App Component: Workspace Settings
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #81527 - "[Release 3.6] [Domain Control] Bulk close members' accounts" by @jmusial (High confidence) Related Issues: None
Recommendation: ROLL FORWARD
A fix should be straightforward - the selectedMembers state needs to be cleaned up when members become disabled (e.g., when their pending action changes). This is simpler than reverting the entire bulk close members feature, which adds significant functionality.
Labels: Keeping DeployBlockerCash as this is a Frontend bug in the App repository that needs to be fixed before deploying to production.
📋 Detailed Analysis
Evidence
PR #81527 introduced the bulk member selection and close accounts feature for Domain members. The issue directly references this PR in the reproduction steps and melvin-bot assigned the PR author.
The bug occurs specifically with the new bulk selection functionality:
When a member is invited, they initially appear with a fallback avatar
User can select them with "Select all" during this optimistic state
When the member data updates (avatar loads, pending action changes), they become isDisabled
The member is no longer selectable, but their ID remains in the selectedMembers state array
The dropdown button visibility check only looks at selectedMembers.length > 0, not whether those members are still valid/enabled
The selectedMembers state in DomainMembersPage.tsx is not automatically cleaned up when members become disabled. When a newly invited member transitions from optimistic to final state and becomes disabled, their accountID remains in the selectedMembers array, causing the button to show "1 selected" even though no valid members are selected.
Fix approach: Add a useEffect or similar mechanism to filter out disabled member IDs from selectedMembers, or update the button visibility condition to check against actually selectable members in filteredData.
changed the title [-]Domains - When invited member is auto deselected, dropdown button still shows "1 selected"[/-][+][Due for payment 2026-02-23] Domains - When invited member is auto deselected, dropdown button still shows "1 selected"[/+]on Feb 16, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.19-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@mountiny@twisterdotcom The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon Feb 13, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #81527
melvin-bot commentedon Feb 13, 2026
💬 A slack conversation has been started in #expensify-open-source
melvin-bot commentedon Feb 13, 2026
Triggered auto assignment to @twisterdotcom (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.github-actions commentedon Feb 13, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon Feb 13, 2026
🔍 Investigation Summary
Classification: Frontend bug
Causing PR: #81527 - "[Release 3.6] [Domain Control] Bulk close members' accounts" by @jmusial (High confidence)
Related Issues: None
Recommendation: ROLL FORWARD
A fix should be straightforward - the
selectedMembersstate needs to be cleaned up when members become disabled (e.g., when their pending action changes). This is simpler than reverting the entire bulk close members feature, which adds significant functionality.Labels: Keeping
DeployBlockerCashas this is a Frontend bug in the App repository that needs to be fixed before deploying to production.📋 Detailed Analysis
Evidence
PR #81527 introduced the bulk member selection and close accounts feature for Domain members. The issue directly references this PR in the reproduction steps and melvin-bot assigned the PR author.
The bug occurs specifically with the new bulk selection functionality:
isDisabledselectedMembersstate arrayselectedMembers.length > 0, not whether those members are still valid/enabledVerification
Files modified by PR #81527 that are affected:
/home/runner/_work/App/App/src/pages/domain/Members/DomainMembersPage.tsx- Contains the bulk selection logic and button visibility condition (line 124)/home/runner/_work/App/App/src/pages/domain/BaseDomainMembersPage.tsx- Contains thetoggleAllUsersfunction that filters disabled members (line 149)Key code locations:
DomainMembersPage.tsx:124- Button visibility condition:(shouldUseNarrowLayout ? canSelectMultiple : selectedMembers.length > 0)BaseDomainMembersPage.tsx:132- Member becomes disabled:isDisabled: isPendingActionDeleteBaseDomainMembersPage.tsx:149- Select all filters disabled:filter((member) => !member.isDisabled && !member.isDisabledCheckbox)Root Cause
The
selectedMembersstate inDomainMembersPage.tsxis not automatically cleaned up when members become disabled. When a newly invited member transitions from optimistic to final state and becomes disabled, their accountID remains in theselectedMembersarray, causing the button to show "1 selected" even though no valid members are selected.Fix approach: Add a
useEffector similar mechanism to filter out disabled member IDs fromselectedMembers, or update the button visibility condition to check against actually selectable members infilteredData.jmusial commentedon Feb 13, 2026
Looking into that
jmusial commentedon Feb 13, 2026
Raised a PR here
IuliiaHerets commentedon Feb 13, 2026
Issue is not rerpo anymore on Windows 11 / Chrome and iPhone 13 / iOS 18.7.1, v9.3.18-4
select.2.mp4
domain.ios.MP4
[-]Domains - When invited member is auto deselected, dropdown button still shows "1 selected"[/-][+][Due for payment 2026-02-23] Domains - When invited member is auto deselected, dropdown button still shows "1 selected"[/+]melvin-bot commentedon Feb 16, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Feb 16, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.19-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-02-23. 🎊
melvin-bot commentedon Feb 16, 2026
@mountiny @twisterdotcom The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]