You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for Payment March 9th] Reports - "Merchant" cell in the expenses table doesn't show the word Scanning... #82402
Version Number: 9.3.18-5 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from BrowserStack: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by:@shawnborton Slack conversation (hyperlinked to channel name): expensify_bugs
Please re-state the problem that we are trying to solve in this issue.
When user scans a receipt to their personal space, the "Merchant" cell in the expenses table doesn't show the word "Scanning..."
What is the root cause of that problem?
The getShouldShowMerchant function in SearchUIUtils.ts determines whether the merchant column should be displayed based on whether any transaction has a valid merchant value. However, it doesn't account for scanning transactions.
When a receipt is being scanned, the merchant value is "(none)" (PARTIAL_TRANSACTION_MERCHANT), which is considered invalid by isInvalidMerchantValue(). As a result, shouldShowMerchant is set to false for the transaction item.
In getMerchantName(), the scanning text is only shown when both isScanning(transactionItem) AND shouldShowMerchant are true:
What alternative solutions did you explore? (Optional)
An alternative would be to modify the getMerchantName function to not require shouldShowMerchant to be true when showing the scanning text. However, the proposed solution is more consistent with the existing pattern used in updateColumns function and ensures the merchant column is visible when there are scanning transactions.
Since shouldShowMerchant was false, the "Scanning…" text was never shown — even though the transaction was actively scanning
What changes do you think we should make in order to solve the problem?
We should remove the && shouldShowMerchant guard from the scanning check in getMerchantName() since Scanning is a transient UI state that should always be displayed regardless of column visibility. Also, column visibility is already properly handled by getColumnsToShow()
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
Please re-state the problem that we are trying to solve in this issue.
When a user creates an expense via “Scan” in a personal space (Reports > Expenses), the Expenses table does not show “Scanning...” in the Merchant cell for that transaction while the receipt scan is in progress, and the Merchant cell stays blank even though “Scanning...” appears elsewhere on the row.
What is the root cause of that problem?
In this implementation, getShouldShowMerchant in src/libs/SearchUIUtils.ts makes the earliest incorrect assumption that the Merchant column should only be shown when at least one transaction has a non-invalid merchant value, but scanning transactions keep an invalid placeholder merchant until SmartScan finishes, so a list that contains only scanning transactions produces shouldShowMerchant === false, and getMerchantName in src/components/TransactionItemRow/index.tsx depends on that flag to show the scanning label, which prevents the Merchant cell from ever rendering “Scanning...” for those rows.
What changes do you think we should make in order to solve the problem?
Update getShouldShowMerchant in src/libs/SearchUIUtils.ts so scanning transactions are treated as “should show merchant,” while keeping the existing row rendering logic unchanged.
⚠️@yatin-italy Your proposal is a duplicate of an already existing proposal and has been automatically withdrawn to prevent spam. Please review the existing proposals before submitting a new one.
Activity
melvin-bot commentedon Feb 13, 2026
Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (
External)melvin-bot commentedon Feb 13, 2026
Triggered auto assignment to @trjExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Feb 13, 2026
Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.
daledah commentedon Feb 13, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
When user scans a receipt to their personal space, the "Merchant" cell in the expenses table doesn't show the word "Scanning..."
What is the root cause of that problem?
The
getShouldShowMerchantfunction inSearchUIUtils.tsdetermines whether the merchant column should be displayed based on whether any transaction has a valid merchant value. However, it doesn't account for scanning transactions.App/src/libs/SearchUIUtils.ts
Lines 1042 to 1051 in 4e0897a
When a receipt is being scanned, the merchant value is
"(none)"(PARTIAL_TRANSACTION_MERCHANT), which is considered invalid byisInvalidMerchantValue(). As a result,shouldShowMerchantis set tofalsefor the transaction item.In
getMerchantName(), the scanning text is only shown when bothisScanning(transactionItem)ANDshouldShowMerchantare true:App/src/components/TransactionItemRow/index.tsx
Lines 148 to 150 in 4e0897a
Since
shouldShowMerchantisfalse, the "Scanning..." text is never displayed.Interestingly, there's already similar logic in the
updateColumnsfunction that correctly handles scanning transactions:App/src/libs/SearchUIUtils.ts
Lines 4382 to 4385 in 4e0897a
What changes do you think we should make in order to solve the problem?
Update the
getShouldShowMerchantfunction to also returntruewhen a transaction is scanning:function getShouldShowMerchant(data: OnyxTypes.SearchResults['data']): boolean { return Object.keys(data).some((key) => { if (isTransactionEntry(key)) { const item = data[key]; const merchant = item.modifiedMerchant ? item.modifiedMerchant : (item.merchant ?? ''); - return !isInvalidMerchantValue(merchant); + return !isInvalidMerchantValue(merchant) || isScanning(item); } return false; }); }What alternative solutions did you explore? (Optional)
An alternative would be to modify the
getMerchantNamefunction to not requireshouldShowMerchantto be true when showing the scanning text. However, the proposed solution is more consistent with the existing pattern used inupdateColumnsfunction and ensures the merchant column is visible when there are scanning transactions.lorretheboy commentedon Feb 16, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
Reports - "Merchant" cell in the expenses table doesn't show the word Scanning...
What is the root cause of that problem?
When scanning a receipt to personal space, the transaction's merchant is set to "(none)" (PARTIAL_TRANSACTION_MERCHANT). The flow was:
First,
getShouldShowMerchant()checks all transactions and returnsfalsebecauseisInvalidMerchantValue("(none)")is trueApp/src/libs/SearchUIUtils.ts
Lines 1042 to 1051 in 79d8a98
--> This sets
shouldShowMerchant = falseon the transaction itemSo that in getMerchantName() (TransactionItemRow), the scanning check was gated on that flag:
App/src/components/TransactionItemRow/index.tsx
Lines 144 to 148 in 3581b29
Since
shouldShowMerchantwasfalse, the "Scanning…" text was never shown — even though the transaction was actively scanningWhat changes do you think we should make in order to solve the problem?
We should remove the && shouldShowMerchant guard from the scanning check in getMerchantName() since Scanning is a transient UI state that should always be displayed regardless of column visibility. Also, column visibility is already properly handled by
getColumnsToShow()App/src/components/TransactionItemRow/index.tsx
Lines 143 to 154 in 3581b29
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
yatin-italy commentedon Feb 16, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
When a user creates an expense via “Scan” in a personal space (Reports > Expenses), the Expenses table does not show “Scanning...” in the Merchant cell for that transaction while the receipt scan is in progress, and the Merchant cell stays blank even though “Scanning...” appears elsewhere on the row.
What is the root cause of that problem?
In this implementation,
getShouldShowMerchantinsrc/libs/SearchUIUtils.tsmakes the earliest incorrect assumption that the Merchant column should only be shown when at least one transaction has a non-invalid merchant value, but scanning transactions keep an invalid placeholder merchant until SmartScan finishes, so a list that contains only scanning transactions producesshouldShowMerchant === false, andgetMerchantNameinsrc/components/TransactionItemRow/index.tsxdepends on that flag to show the scanning label, which prevents the Merchant cell from ever rendering “Scanning...” for those rows.What changes do you think we should make in order to solve the problem?
Update
getShouldShowMerchantinsrc/libs/SearchUIUtils.tsso scanning transactions are treated as “should show merchant,” while keeping the existing row rendering logic unchanged.What alternative solutions did you explore? (Optional)
None
github-actions commentedon Feb 16, 2026
35 remaining items
MelvinBot commentedon Mar 12, 2026
Sorry, I'm not able to manage payment labels or process payment workflows. That functionality is handled by a different system.
You may need to manually update the label or ask someone with the appropriate permissions to do so.
melvin-bot commentedon Mar 12, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)melvin-bot commentedon Mar 12, 2026
Current assignee @mallenexpensify is eligible for the Awaiting Payment assigner, not assigning anyone new.
trjExpensify commentedon Mar 12, 2026
Payment summary as follows:
Closing!
JmillsExpensify commentedon Mar 18, 2026
$250 approved for @DylanDylann
garrettmknight commentedon Mar 25, 2026
$250 approved for @daledah