Skip to content

[$100] Close button for Concierge RHP is on the left side of the header #82411

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.18-6
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation (hyperlinked to channel name): #expensify_bugs

Action Performed:

  1. Navigate to https://staging.new.expensify.com/
  2. Click to the "Concierge" icon at the top right side

Expected Result:

Close button for Concierge RHP is on the right side.

Actual Result:

Close button for Concierge RHP is on the left side of the header.

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Image Image

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @mallenexpensify
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~022046259521519579756
  • Upwork Job ID: 2046259521519579756
  • Last Price Increase: 2026-04-20

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 13, 2026
  2. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 13, 2026
  3. melvin-bot commented on Feb 13, 2026

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

  4. melvin-bot commented on Feb 13, 2026

    @melvin-bot

    Triggered auto assignment to @heyjennahay (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. melvin-bot commented on Feb 13, 2026

    @melvin-bot

    Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.

  6. samranahm commented on Feb 13, 2026

    @samranahm
    Contributor

    🚨 Edited by proposal-police: This proposal was edited at 2026-02-13 13:19:15 UTC.

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Close button for Concierge RHP is on the left side of the header

    What is the root cause of that problem?

    We show the icon here and alway keep it in left

    >
    <Tooltip
    text={backButtonLabel}
    shiftVertical={4}
    >
    <View>
    <Icon
    src={backButtonIcon}
    fill={theme.icon}
    />
    </View>
    </Tooltip>
    </PressableWithoutFeedback>
    )}

    What changes do you think we should make in order to solve the problem?

    We should check if its concierge chat show the icon on right, add new icon on right

    const shouldShowCloseButton = isInSidePanel && !shouldUseNarrowLayout && isConciergeChatReport(report);
    const backButtonIcon = shouldShowCloseButton ? icons.Close : icons.BackArrow;
    const backButtonLabel = shouldShowCloseButton ? translate('common.close') : translate('common.back');

        const shouldShowBackButton = shouldUseNarrowLayout || (!!isInSidePanel && !shouldShowCloseButton);
        const backButtonIcon = icons.BackArrow;
        const backButtonLabel = translate('common.back');
    ...
      {shouldShowCloseButton && (
                                            <Tooltip text={translate('common.close')}>
                                                <PressableWithoutFeedback
                                                    onPress={onNavigationMenuButtonClicked}
                                                    style={[styles.touchableButtonImage, styles.ml2]}
                                                    role={CONST.ROLE.BUTTON}
                                                    accessibilityLabel={translate('common.close')}
                                                    sentryLabel={CONST.SENTRY_LABEL.HEADER.CLOSE_BUTTON}
                                                >
                                                    <Icon
                                                        src={icons.Close}
                                                        fill={theme.icon}
                                                    />
                                                </PressableWithoutFeedback>
                                            </Tooltip>
                                        )}

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  7. nyomanjyotisa commented on Feb 13, 2026

    @nyomanjyotisa
    Member

    🚨 Edited by proposal-police: This proposal was edited at 2026-02-13 13:38:22 UTC.

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Close button for Concierge RHP is on the left side of the header

    What is the root cause of that problem?

    When showing the close button for Concierge RHP, it replaces the back button icon but still renders on the left. The close button should be on the right side of the header.

    const shouldShowCloseButton = isInSidePanel && !shouldUseNarrowLayout && isConciergeChatReport(report);
    const backButtonIcon = shouldShowCloseButton ? icons.Close : icons.BackArrow;
    const backButtonLabel = shouldShowCloseButton ? translate('common.close') : translate('common.back');

    {shouldShowBackButton && (
    <PressableWithoutFeedback
    onPress={onNavigationMenuButtonClicked}
    style={[styles.LHNToggle, shouldUseNarrowLayout && styles.pl5]}
    accessibilityHint={translate('accessibilityHints.navigateToChatsList')}
    accessibilityLabel={backButtonLabel}
    role={CONST.ROLE.BUTTON}
    sentryLabel={CONST.SENTRY_LABEL.HEADER_VIEW.BACK_BUTTON}
    >
    <Tooltip
    text={backButtonLabel}
    shiftVertical={4}
    >
    <View>
    <Icon
    src={backButtonIcon}
    fill={theme.icon}
    />
    </View>
    </Tooltip>
    </PressableWithoutFeedback>
    )}

    What changes do you think we should make in order to solve the problem?

    Don't show the back button when shouldShowCloseButton is true, and render the close button on the right side after the reportOptions View.

    Update shouldShowBackButton to exclude the close button case:

        const shouldShowBackButton = (shouldUseNarrowLayout || !!isInSidePanel) && !shouldShowCloseButton;

    const shouldShowBackButton = shouldUseNarrowLayout || !!isInSidePanel;

    Add the close button on the right side after the reportOptions View:

                                    </View>
                                    {shouldShowCloseButton && (
                                        <Tooltip text={translate('common.close')}>
                                            <PressableWithoutFeedback
                                                onPress={onNavigationMenuButtonClicked}
                                                style={[styles.touchableButtonImage]}
                                                role={CONST.ROLE.BUTTON}
                                                accessibilityLabel={translate('common.close')}
                                                sentryLabel={CONST.SENTRY_LABEL.HEADER_VIEW.BACK_BUTTON}
                                            >
                                                <Icon
                                                    src={icons.Close}
                                                    fill={theme.icon}
                                                />
                                            </PressableWithoutFeedback>
                                        </Tooltip>
                                    )}
                                    {!isInSidePanel && <SidePanelButton style={styles.ml2} />}

    </View>
    {!isInSidePanel && <SidePanelButton style={styles.ml2} />}

    Note: We should remove the backButtonIcon and backButtonLabel conditionals and always use the BackArrow icon here and back label since the close button is now rendered in a different view (right side)

    What alternative solutions did you explore? (Optional)

    None

  8. abbasifaizan70 commented on Feb 13, 2026

    @abbasifaizan70
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Click the Concierge icon at the top right to open the Concierge RHP (Right Hand Panel). The close button for the Concierge RHP should appear on the right side of the header. Currently, the close button is shown on the left side of the header instead of the right.

    What is the root cause of that problem?

    In HeaderView, when the Concierge chat is shown in the side panel on wide layout, the header shows a close control by reusing the back-button slot on the left: shouldShowCloseButton is true and the back button is rendered with the Close icon and "Close" label. There is no separate close button on the right; the right side only shows SidePanelButton when not in the side panel and SearchButton. So the close control is always left-aligned.

    const shouldShowBackButton = shouldUseNarrowLayout || !!isInSidePanel;
    const shouldShowCloseButton = isInSidePanel && !shouldUseNarrowLayout && isConciergeChatReport(report);
    const backButtonIcon = shouldShowCloseButton ? icons.Close : icons.BackArrow;
    const backButtonLabel = shouldShowCloseButton ? translate('common.close') : translate('common.back');

    singleAvatarContainerStyle={[styles.actionAvatar, styles.mr3]}
    />
    );
    return (
    <>
    <View
    style={[styles.borderBottom]}
    dataSet={{dragArea: true}}
    >
    <View style={[styles.appContentHeader, styles.pr3]}>
    {isLoading ? (
    <ReportHeaderSkeletonView onBackButtonPress={onNavigationMenuButtonClicked} />
    ) : (
    <View style={[styles.appContentHeaderTitle, !shouldUseNarrowLayout && !isLoading && styles.pl5]}>
    {shouldShowBackButton && (
    <PressableWithoutFeedback
    onPress={onNavigationMenuButtonClicked}
    style={[styles.LHNToggle, shouldUseNarrowLayout && styles.pl5]}
    accessibilityHint={translate('accessibilityHints.navigateToChatsList')}

    >
    <CaretWrapper>
    <DisplayNames
    fullTitle={title}
    displayNamesWithTooltips={displayNamesWithTooltips}
    shouldParseFullTitle={shouldParseFullTitle && !isGroupChat}
    tooltipEnabled
    numberOfLines={1}
    textStyles={[styles.headerText, styles.pre]}
    shouldUseFullTitle={isChatRoom || isPolicyExpenseChat || isChatThread || isTaskReport || shouldUseGroupTitle || isReportArchived}

    What changes do you think we should make in order to solve the problem?

    Keep the close action only on the right for Concierge RHP: do not show the back control on the left when shouldShowCloseButton is true, and render a dedicated close button on the right (same row as report options and search). Use the same onNavigationMenuButtonClicked handler for the new close button so the side panel still closes correctly.

    File: App/src/pages/inbox/HeaderView.tsx

    -    const shouldShowBackButton = shouldUseNarrowLayout || !!isInSidePanel;
    -
         const shouldShowCloseButton = isInSidePanel && !shouldUseNarrowLayout && isConciergeChatReport(report);
    +    const shouldShowBackButton = (shouldUseNarrowLayout || !!isInSidePanel) && !shouldShowCloseButton;
    -    const backButtonIcon = shouldShowCloseButton ? icons.Close : icons.BackArrow;
    -    const backButtonLabel = shouldShowCloseButton ? translate('common.close') : translate('common.back');
    +    const backButtonIcon = icons.BackArrow;
    +    const backButtonLabel = translate('common.back');
                                     </View>
                                     {!isInSidePanel && <SidePanelButton style={styles.ml2} />}
    +                                {shouldShowCloseButton && (
    +                                    <Tooltip text={translate('common.close')}>
    +                                        <PressableWithoutFeedback
    +                                            onPress={onNavigationMenuButtonClicked}
    +                                            style={[styles.touchableButtonImage, styles.ml2]}
    +                                            role={CONST.ROLE.BUTTON}
    +                                            accessibilityLabel={translate('common.close')}
    +                                            sentryLabel={CONST.SENTRY_LABEL.HEADER.CLOSE_BUTTON}
    +                                        >
    +                                            <Icon
    +                                                src={icons.Close}
    +                                                fill={theme.icon}
    +                                            />
    +                                        </PressableWithoutFeedback>
    +                                    </Tooltip>
    +                                )}
                                     {shouldDisplaySearchRouter && <SearchButton />}

    Note: icons already includes 'Close' from the existing useMemoizedLazyExpensifyIcons(['BackArrow', 'Close']) in this file, so no import change is required.

  9. github-actions commented on Feb 13, 2026

    @github-actions
    Contributor

    ⚠️ @abbasifaizan70 Your proposal is a duplicate of an already existing proposal and has been automatically withdrawn to prevent spam. Please review the existing proposals before submitting a new one.

  10. annaweber830 commented on Feb 13, 2026

    @annaweber830
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    When opening the Concierge chat in the right-hand panel (RHP) on web, the close control appears on the left side of the header. The expected behavior is to keep the close button on the right side, consistent with RHP header behavior.

    What is the root cause of that problem?

    const shouldShowBackButton = shouldUseNarrowLayout || !!isInSidePanel;
    const shouldShowCloseButton = isInSidePanel && !shouldUseNarrowLayout && isConciergeChatReport(report);
    const backButtonIcon = shouldShowCloseButton ? icons.Close : icons.BackArrow;
    const backButtonLabel = shouldShowCloseButton ? translate('common.close') : translate('common.back');
    const onboardingHelpDropdownButton = (
    <OnboardingHelpDropdownButton
    reportID={report?.reportID}
    shouldUseNarrowLayout={shouldUseNarrowLayout}
    shouldShowRegisterForWebinar={shouldShowRegisterForWebinar}
    shouldShowGuideBooking={shouldShowGuideBooking}
    hasActiveScheduledCall={hasActiveScheduledCall}
    />
    );
    const multipleAvatars = (
    <ReportActionAvatars
    reportID={report?.reportID}
    size={shouldShowSubscript ? defaultSubscriptSize : undefined}
    singleAvatarContainerStyle={[styles.actionAvatar, styles.mr3]}
    />
    );
    return (
    <>
    <View
    style={[styles.borderBottom]}
    dataSet={{dragArea: true}}
    >
    <View style={[styles.appContentHeader, styles.pr3]}>
    {isLoading ? (
    <ReportHeaderSkeletonView onBackButtonPress={onNavigationMenuButtonClicked} />
    ) : (
    <View style={[styles.appContentHeaderTitle, !shouldUseNarrowLayout && !isLoading && styles.pl5]}>
    {shouldShowBackButton && (
    <PressableWithoutFeedback
    onPress={onNavigationMenuButtonClicked}
    style={[styles.LHNToggle, shouldUseNarrowLayout && styles.pl5]}
    accessibilityHint={translate('accessibilityHints.navigateToChatsList')}
    accessibilityLabel={backButtonLabel}
    role={CONST.ROLE.BUTTON}
    sentryLabel={CONST.SENTRY_LABEL.HEADER_VIEW.BACK_BUTTON}
    >
    <Tooltip
    text={backButtonLabel}
    shiftVertical={4}
    >
    <View>
    <Icon
    src={backButtonIcon}
    fill={theme.icon}
    />
    </View>
    </Tooltip>
    </PressableWithoutFeedback>

    HeaderView currently treats Concierge-in-RHP as a special case by swapping the left back arrow icon to a close icon. Because that icon is still rendered in the left shouldShowBackButton slot, the close control is displayed on the left instead of in the right actions area.

    What changes do you think we should make in order to solve the problem?

    const shouldShowBackButton = shouldUseNarrowLayout || !!isInSidePanel;
    const shouldShowCloseButton = isInSidePanel && !shouldUseNarrowLayout && isConciergeChatReport(report);
    const backButtonIcon = shouldShowCloseButton ? icons.Close : icons.BackArrow;
    const backButtonLabel = shouldShowCloseButton ? translate('common.close') : translate('common.back');
    const onboardingHelpDropdownButton = (
    <OnboardingHelpDropdownButton
    reportID={report?.reportID}
    shouldUseNarrowLayout={shouldUseNarrowLayout}
    shouldShowRegisterForWebinar={shouldShowRegisterForWebinar}
    shouldShowGuideBooking={shouldShowGuideBooking}
    hasActiveScheduledCall={hasActiveScheduledCall}
    />
    );
    const multipleAvatars = (
    <ReportActionAvatars
    reportID={report?.reportID}
    size={shouldShowSubscript ? defaultSubscriptSize : undefined}
    singleAvatarContainerStyle={[styles.actionAvatar, styles.mr3]}
    />
    );
    return (
    <>
    <View
    style={[styles.borderBottom]}
    dataSet={{dragArea: true}}
    >
    <View style={[styles.appContentHeader, styles.pr3]}>
    {isLoading ? (
    <ReportHeaderSkeletonView onBackButtonPress={onNavigationMenuButtonClicked} />
    ) : (
    <View style={[styles.appContentHeaderTitle, !shouldUseNarrowLayout && !isLoading && styles.pl5]}>
    {shouldShowBackButton && (
    <PressableWithoutFeedback
    onPress={onNavigationMenuButtonClicked}
    style={[styles.LHNToggle, shouldUseNarrowLayout && styles.pl5]}
    accessibilityHint={translate('accessibilityHints.navigateToChatsList')}
    accessibilityLabel={backButtonLabel}
    role={CONST.ROLE.BUTTON}
    sentryLabel={CONST.SENTRY_LABEL.HEADER_VIEW.BACK_BUTTON}
    >
    <Tooltip
    text={backButtonLabel}
    shiftVertical={4}
    >
    <View>
    <Icon
    src={backButtonIcon}
    fill={theme.icon}
    />
    </View>
    </Tooltip>
    </PressableWithoutFeedback>
    )}
    <View style={[styles.flex1, styles.flexRow, styles.alignItemsCenter, styles.justifyContentBetween]}>
    <PressableWithoutFeedback
    onPress={() => navigateToDetailsPage(report, Navigation.getReportRHPActiveRoute(), true)}
    style={[styles.flexRow, styles.alignItemsCenter, styles.flex1]}
    disabled={shouldDisableDetailPage}
    accessibilityLabel={title}
    role={CONST.ROLE.BUTTON}
    sentryLabel={CONST.SENTRY_LABEL.HEADER_VIEW.DETAILS_BUTTON}
    >
    {shouldShowSubscript ? multipleAvatars : <OfflineWithFeedback pendingAction={report?.pendingFields?.avatar}>{multipleAvatars}</OfflineWithFeedback>}
    <View
    fsClass={CONST.FULLSTORY.CLASS.UNMASK}
    style={[styles.flex1, styles.flexColumn]}
    >
    <CaretWrapper>
    <DisplayNames
    fullTitle={title}
    displayNamesWithTooltips={displayNamesWithTooltips}
    shouldParseFullTitle={shouldParseFullTitle && !isGroupChat}
    tooltipEnabled
    numberOfLines={1}
    textStyles={[styles.headerText, styles.pre]}
    shouldUseFullTitle={isChatRoom || isPolicyExpenseChat || isChatThread || isTaskReport || shouldUseGroupTitle || isReportArchived}
    renderAdditionalText={renderAdditionalText}
    shouldAddEllipsis={shouldAddEllipsis}
    />
    </CaretWrapper>
    {!isEmptyObject(parentNavigationSubtitleData) && (
    <ParentNavigationSubtitle
    statusText={statusTextForInvoiceReport}
    statusTextColor={statusColorForInvoiceReport?.textColor}
    statusTextBackgroundColor={statusColorForInvoiceReport?.backgroundColor}
    parentNavigationSubtitleData={parentNavigationSubtitleData}
    reportID={parentNavigationReport?.reportID}
    parentReportID={parentNavigationReport?.parentReportID}
    parentReportActionID={isParentOneTransactionThread ? undefined : parentNavigationReport?.parentReportActionID}
    pressableStyles={[styles.alignSelfStart, styles.mw100]}
    />
    )}
    {shouldShowSubtitle() && (
    <Text
    style={[styles.sidebarLinkText, styles.optionAlternateText, styles.textLabelSupporting]}
    numberOfLines={1}
    >
    {subtitle}
    </Text>
    )}
    {isChatRoom && !isInvoiceRoom(reportHeaderData) && !!reportDescription && isEmptyObject(parentNavigationSubtitleData) && (
    <View style={[styles.alignSelfStart, styles.mw100]}>
    <Text
    style={[styles.sidebarLinkText, styles.optionAlternateText, styles.textLabelSupporting]}
    numberOfLines={1}
    >
    {reportDescription}
    </Text>
    </View>
    )}
    {isPolicyExpenseChat && !!policyDescription && isEmptyObject(parentNavigationSubtitleData) && (
    <View style={[styles.alignSelfStart, styles.mw100]}>
    <Text
    style={[styles.sidebarLinkText, styles.optionAlternateText, styles.textLabelSupporting]}
    numberOfLines={1}
    >
    {policyDescription}
    </Text>
    </View>
    )}
    </View>
    {brickRoadIndicator === CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR && (
    <View style={[styles.alignItemsCenter, styles.justifyContentCenter]}>
    <Icon
    src={DotIndicator}
    fill={theme.danger}
    />
    </View>
    )}
    </PressableWithoutFeedback>
    <View style={[styles.reportOptions, styles.flexRow, styles.alignItemsCenter, styles.gap2]}>
    {shouldShowOnBoardingHelpDropdownButton && !shouldUseNarrowLayout && onboardingHelpDropdownButton}
    {!shouldUseNarrowLayout && !shouldShowDiscount && isChatUsedForOnboarding && (
    <FreeTrial
    pressable
    success={!hasActiveScheduledCall}
    />
    )}
    {!shouldUseNarrowLayout && isOpenTaskReport(report, parentReportAction) && <TaskHeaderActionButton report={report} />}
    {!isParentReportLoading && canJoin && !shouldUseNarrowLayout && joinButton}
    </View>
    {!isInSidePanel && <SidePanelButton style={styles.ml2} />}
    {shouldDisplaySearchRouter && <SearchButton />}
    </View>

    Render the left back control only when it is actually a back action, and render Concierge close as a right-side action button in the header actions group.

    Current code:

    const shouldShowBackButton = shouldUseNarrowLayout || !!isInSidePanel;
    
    const shouldShowCloseButton = isInSidePanel && !shouldUseNarrowLayout && isConciergeChatReport(report);
    const backButtonIcon = shouldShowCloseButton ? icons.Close : icons.BackArrow;
    const backButtonLabel = shouldShowCloseButton ? translate('common.close') : translate('common.back');
    
    {shouldShowBackButton && (
        <PressableWithoutFeedback
            onPress={onNavigationMenuButtonClicked}
            style={[styles.LHNToggle, shouldUseNarrowLayout && styles.pl5]}
            accessibilityHint={translate('accessibilityHints.navigateToChatsList')}
            accessibilityLabel={backButtonLabel}
            role={CONST.ROLE.BUTTON}
            sentryLabel={CONST.SENTRY_LABEL.HEADER_VIEW.BACK_BUTTON}
        >
            <Tooltip
                text={backButtonLabel}
                shiftVertical={4}
            >
                <View>
                    <Icon
                        src={backButtonIcon}
                        fill={theme.icon}
                    />
                </View>
            </Tooltip>
        </PressableWithoutFeedback>
    )}

    Updated code:

    const shouldShowCloseButton = isInSidePanel && !shouldUseNarrowLayout && isConciergeChatReport(report);
    const shouldShowBackButton = shouldUseNarrowLayout || (!!isInSidePanel && !shouldShowCloseButton);
    const backButtonLabel = translate('common.back');
    
    {shouldShowBackButton && (
        <PressableWithoutFeedback
            onPress={onNavigationMenuButtonClicked}
            style={[styles.LHNToggle, shouldUseNarrowLayout && styles.pl5]}
            accessibilityHint={translate('accessibilityHints.navigateToChatsList')}
            accessibilityLabel={backButtonLabel}
            role={CONST.ROLE.BUTTON}
            sentryLabel={CONST.SENTRY_LABEL.HEADER_VIEW.BACK_BUTTON}
        >
            <Tooltip
                text={backButtonLabel}
                shiftVertical={4}
            >
                <View>
                    <Icon
                        src={icons.BackArrow}
                        fill={theme.icon}
                    />
                </View>
            </Tooltip>
        </PressableWithoutFeedback>
    )}
    
    <View style={[styles.reportOptions, styles.flexRow, styles.alignItemsCenter, styles.gap2]}>
        {shouldShowCloseButton && (
            <Tooltip text={translate('common.close')}>
                <PressableWithoutFeedback
                    onPress={onNavigationMenuButtonClicked}
                    accessibilityLabel={translate('common.close')}
                    role={CONST.ROLE.BUTTON}
                    sentryLabel={CONST.SENTRY_LABEL.HEADER.CLOSE_BUTTON}
                >
                    <Icon
                        src={icons.Close}
                        fill={theme.icon}
                    />
                </PressableWithoutFeedback>
            </Tooltip>
        )}
        {/* existing reportOptions actions... */}
    </View>

    This keeps Concierge RHP behavior (a close action is still available) while aligning placement with the expected RHP convention by moving close into the right actions cluster.

    What alternative solutions did you explore? (Optional)

    Keeping the close icon in the left slot and adjusting only spacing/alignment was considered, but that would preserve the incorrect interaction pattern and remain inconsistent with other RHP headers. I also considered using HeaderWithBackButton, but that is a larger refactor than needed for this focused bug fix.

  11. 27 remaining items

  12. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Apr 20, 2026
  13. melvin-bot commented on Apr 20, 2026

    @melvin-bot

    Current assignees @nyomanjyotisa and @aimane-chnaif are eligible for the External assigner, not assigning anyone new.

  14. melvin-bot commented on Apr 20, 2026

    @melvin-bot
  15. mallenexpensify commented on Apr 20, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor: @nyomanjyotisa due $100 via NewDot
    Contributor+: @aimane-chnaif paid $100 via Upwork.

    @aimane-chnaif plz complete the BZ checklist and tag me in a post once you have. Thx

    @aimane-chnaif can you please accept the job below? Please reply here and tag me once you have.
    https://www.upwork.com/jobs/~022046259521519579756

  16. Abdullah9213 commented on Apr 20, 2026

    @Abdullah9213

    Proposal
    Root Cause: The ConciergePage (or equivalent component rendering the Concierge RHP header) is using shouldShowBackButton on HeaderWithBackButton, which positions the button on the left. When rendered as an RHP/modal, it should use shouldShowCloseButton to position the close button on the right.
    Fix: In the Concierge page component's HeaderWithBackButton usage, replace shouldShowBackButton / onBackButtonPress with shouldShowCloseButton and onCloseButtonPress={Navigation.dismissModal}.
    If the Concierge page is used in multiple navigation contexts (e.g., full screen on mobile vs. RHP on web/tablet), I will add a conditional check — likely using useNavigationState or checking if the screen is in a modal stack — to switch between back and close behavior, consistent with how other dual-context pages in the codebase handle it.
    Testing: Will verify on all listed platforms (Android app, Android mWeb, iOS app, iOS mWeb, Windows Chrome, MacOS Chrome/Safari) with screenshots confirming the close button appears on the right.

  17. melvin-bot commented on Apr 20, 2026

    @melvin-bot

    📣 @Abdullah9213! 📣
    Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
    Please follow these steps:

    1. Make sure you've read and understood the contributing guidelines.
    2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
    3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
    4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
      Screen Shot 2022-11-16 at 4 42 54 PM
      Format:
    Contributor details
    Your Expensify account email: <REPLACE EMAIL HERE>
    Upwork Profile Link: <REPLACE LINK HERE>
    
  18. Abdullah9213 commented on Apr 20, 2026

    @Abdullah9213

    Contributor details

    Your Expensify account email: abdullah.ghaffar256@gmail.com

    Upwork Profile Link: https://www.upwork.com/freelancers/~01d9e5ac5bd0b4248c

  19. melvin-bot commented on Apr 20, 2026

    @melvin-bot

    ✅ Contributor details stored successfully. Thank you for contributing to Expensify!

  20. aimane-chnaif commented on Apr 20, 2026

    @aimane-chnaif
    Contributor

    @mallenexpensify accepted offer

  21. aimane-chnaif commented on Apr 20, 2026

    @aimane-chnaif
    Contributor

    BugZero Checklist:

    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: new design update

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue: https://github.com/Expensify/Expensify/issues/626270

    Regression Test Proposal

    Test:

    1. Login any account
    2. Click to the "Concierge" icon at the top right side
    3. Verify that the close button for Concierge RHP appears on the right side in the desktop view

    Do we agree 👍 or 👎

    Zapier Logs Run ID: 00040eee-b6c0-a132-2fa6-6d4cb240c274
  22. mallenexpensify commented on Apr 20, 2026

    @mallenexpensify
    Contributor

    @aimane-chnaif paid, summary updated above. Thx.

    ^ Test case created

  23. trjExpensify commented on May 29, 2026

    @trjExpensify
    Contributor

    approved $100 for @nyomanjyotisa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions