You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$100] Close button for Concierge RHP is on the left side of the header #82411
Version Number: 9.3.18-6 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from BrowserStack: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by:@shawnborton Slack conversation (hyperlinked to channel name): #expensify_bugs
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
🚨 Edited by proposal-police: This proposal was edited at 2026-02-13 13:38:22 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
Close button for Concierge RHP is on the left side of the header
What is the root cause of that problem?
When showing the close button for Concierge RHP, it replaces the back button icon but still renders on the left. The close button should be on the right side of the header.
Note: We should remove the backButtonIcon and backButtonLabel conditionals and always use the BackArrow icon here and back label since the close button is now rendered in a different view (right side)
What alternative solutions did you explore? (Optional)
Please re-state the problem that we are trying to solve in this issue.
Click the Concierge icon at the top right to open the Concierge RHP (Right Hand Panel). The close button for the Concierge RHP should appear on the right side of the header. Currently, the close button is shown on the left side of the header instead of the right.
What is the root cause of that problem?
In HeaderView, when the Concierge chat is shown in the side panel on wide layout, the header shows a close control by reusing the back-button slot on the left: shouldShowCloseButton is true and the back button is rendered with the Close icon and "Close" label. There is no separate close button on the right; the right side only shows SidePanelButton when not in the side panel and SearchButton. So the close control is always left-aligned.
What changes do you think we should make in order to solve the problem?
Keep the close action only on the right for Concierge RHP: do not show the back control on the left when shouldShowCloseButton is true, and render a dedicated close button on the right (same row as report options and search). Use the same onNavigationMenuButtonClicked handler for the new close button so the side panel still closes correctly.
Note: icons already includes 'Close' from the existing useMemoizedLazyExpensifyIcons(['BackArrow', 'Close']) in this file, so no import change is required.
⚠️@abbasifaizan70 Your proposal is a duplicate of an already existing proposal and has been automatically withdrawn to prevent spam. Please review the existing proposals before submitting a new one.
Please re-state the problem that we are trying to solve in this issue.
When opening the Concierge chat in the right-hand panel (RHP) on web, the close control appears on the left side of the header. The expected behavior is to keep the close button on the right side, consistent with RHP header behavior.
HeaderView currently treats Concierge-in-RHP as a special case by swapping the left back arrow icon to a close icon. Because that icon is still rendered in the left shouldShowBackButton slot, the close control is displayed on the left instead of in the right actions area.
What changes do you think we should make in order to solve the problem?
Render the left back control only when it is actually a back action, and render Concierge close as a right-side action button in the header actions group.
This keeps Concierge RHP behavior (a close action is still available) while aligning placement with the expected RHP convention by moving close into the right actions cluster.
What alternative solutions did you explore? (Optional)
Keeping the close icon in the left slot and adjusting only spacing/alignment was considered, but that would preserve the incorrect interaction pattern and remain inconsistent with other RHP headers. I also considered using HeaderWithBackButton, but that is a larger refactor than needed for this focused bug fix.
Proposal Root Cause: The ConciergePage (or equivalent component rendering the Concierge RHP header) is using shouldShowBackButton on HeaderWithBackButton, which positions the button on the left. When rendered as an RHP/modal, it should use shouldShowCloseButton to position the close button on the right. Fix: In the Concierge page component's HeaderWithBackButton usage, replace shouldShowBackButton / onBackButtonPress with shouldShowCloseButton and onCloseButtonPress={Navigation.dismissModal}.
If the Concierge page is used in multiple navigation contexts (e.g., full screen on mobile vs. RHP on web/tablet), I will add a conditional check — likely using useNavigationState or checking if the screen is in a modal stack — to switch between back and close behavior, consistent with how other dual-context pages in the codebase handle it. Testing: Will verify on all listed platforms (Android app, Android mWeb, iOS app, iOS mWeb, Windows Chrome, MacOS Chrome/Safari) with screenshots confirming the close button appears on the right.
📣 @Abdullah9213! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: new design update
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Activity
melvin-bot commentedon Feb 13, 2026
Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (
External)melvin-bot commentedon Feb 13, 2026
Triggered auto assignment to @heyjennahay (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Feb 13, 2026
Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.
samranahm commentedon Feb 13, 2026
🚨 Edited by proposal-police: This proposal was edited at 2026-02-13 13:19:15 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
Close button for Concierge RHP is on the left side of the header
What is the root cause of that problem?
We show the icon here and alway keep it in left
App/src/pages/inbox/HeaderView.tsx
Lines 292 to 305 in 4341230
What changes do you think we should make in order to solve the problem?
We should check if its concierge chat show the icon on right, add new icon on right
App/src/pages/inbox/HeaderView.tsx
Lines 251 to 253 in 4341230
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
nyomanjyotisa commentedon Feb 13, 2026
🚨 Edited by proposal-police: This proposal was edited at 2026-02-13 13:38:22 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
Close button for Concierge RHP is on the left side of the header
What is the root cause of that problem?
When showing the close button for Concierge RHP, it replaces the back button icon but still renders on the left. The close button should be on the right side of the header.
App/src/pages/inbox/HeaderView.tsx
Lines 251 to 253 in 7ccc11c
App/src/pages/inbox/HeaderView.tsx
Lines 284 to 305 in 7ccc11c
What changes do you think we should make in order to solve the problem?
Don't show the back button when
shouldShowCloseButtonis true, and render the close button on the right side after thereportOptionsView.Update
shouldShowBackButtonto exclude the close button case:App/src/pages/inbox/HeaderView.tsx
Line 249 in 7ccc11c
Add the close button on the right side after the
reportOptionsView:App/src/pages/inbox/HeaderView.tsx
Lines 393 to 394 in 7ccc11c
Note: We should remove the
backButtonIconandbackButtonLabelconditionals and always use theBackArrowicon here and back label since the close button is now rendered in a different view (right side)What alternative solutions did you explore? (Optional)
None
abbasifaizan70 commentedon Feb 13, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
Click the Concierge icon at the top right to open the Concierge RHP (Right Hand Panel). The close button for the Concierge RHP should appear on the right side of the header. Currently, the close button is shown on the left side of the header instead of the right.
What is the root cause of that problem?
In
HeaderView, when the Concierge chat is shown in the side panel on wide layout, the header shows a close control by reusing the back-button slot on the left:shouldShowCloseButtonis true and the back button is rendered with the Close icon and "Close" label. There is no separate close button on the right; the right side only showsSidePanelButtonwhen not in the side panel andSearchButton. So the close control is always left-aligned.App/src/pages/inbox/HeaderView.tsx
Lines 249 to 253 in 0779780
App/src/pages/inbox/HeaderView.tsx
Lines 269 to 288 in 0779780
App/src/pages/inbox/HeaderView.tsx
Lines 319 to 328 in 0779780
What changes do you think we should make in order to solve the problem?
Keep the close action only on the right for Concierge RHP: do not show the back control on the left when
shouldShowCloseButtonis true, and render a dedicated close button on the right (same row as report options and search). Use the sameonNavigationMenuButtonClickedhandler for the new close button so the side panel still closes correctly.File:
App/src/pages/inbox/HeaderView.tsx</View> {!isInSidePanel && <SidePanelButton style={styles.ml2} />} + {shouldShowCloseButton && ( + <Tooltip text={translate('common.close')}> + <PressableWithoutFeedback + onPress={onNavigationMenuButtonClicked} + style={[styles.touchableButtonImage, styles.ml2]} + role={CONST.ROLE.BUTTON} + accessibilityLabel={translate('common.close')} + sentryLabel={CONST.SENTRY_LABEL.HEADER.CLOSE_BUTTON} + > + <Icon + src={icons.Close} + fill={theme.icon} + /> + </PressableWithoutFeedback> + </Tooltip> + )} {shouldDisplaySearchRouter && <SearchButton />}Note:
iconsalready includes'Close'from the existinguseMemoizedLazyExpensifyIcons(['BackArrow', 'Close'])in this file, so no import change is required.github-actions commentedon Feb 13, 2026
annaweber830 commentedon Feb 13, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
When opening the Concierge chat in the right-hand panel (RHP) on web, the close control appears on the left side of the header. The expected behavior is to keep the close button on the right side, consistent with RHP header behavior.
What is the root cause of that problem?
App/src/pages/inbox/HeaderView.tsx
Lines 249 to 304 in 7b4fcd0
HeaderViewcurrently treats Concierge-in-RHP as a special case by swapping the left back arrow icon to a close icon. Because that icon is still rendered in the leftshouldShowBackButtonslot, the close control is displayed on the left instead of in the right actions area.What changes do you think we should make in order to solve the problem?
App/src/pages/inbox/HeaderView.tsx
Lines 249 to 396 in 7b4fcd0
Render the left back control only when it is actually a back action, and render Concierge close as a right-side action button in the header actions group.
Current code:
Updated code:
This keeps Concierge RHP behavior (a close action is still available) while aligning placement with the expected RHP convention by moving close into the right actions cluster.
What alternative solutions did you explore? (Optional)
Keeping the close icon in the left slot and adjusting only spacing/alignment was considered, but that would preserve the incorrect interaction pattern and remain inconsistent with other RHP headers. I also considered using
HeaderWithBackButton, but that is a larger refactor than needed for this focused bug fix.27 remaining items
melvin-bot commentedon Apr 20, 2026
Current assignees @nyomanjyotisa and @aimane-chnaif are eligible for the External assigner, not assigning anyone new.
melvin-bot commentedon Apr 20, 2026
Job added to Upwork: https://www.upwork.com/jobs/~022046259521519579756
mallenexpensify commentedon Apr 20, 2026
Payment Summary
Contributor: @nyomanjyotisa due $100 via NewDot
Contributor+: @aimane-chnaif paid $100 via Upwork.
@aimane-chnaif plz complete the BZ checklist and tag me in a post once you have. Thx
@aimane-chnaif can you please accept the job below? Please reply here and tag me once you have.
https://www.upwork.com/jobs/~022046259521519579756
Abdullah9213 commentedon Apr 20, 2026
Proposal
Root Cause: The ConciergePage (or equivalent component rendering the Concierge RHP header) is using shouldShowBackButton on HeaderWithBackButton, which positions the button on the left. When rendered as an RHP/modal, it should use shouldShowCloseButton to position the close button on the right.
Fix: In the Concierge page component's HeaderWithBackButton usage, replace shouldShowBackButton / onBackButtonPress with shouldShowCloseButton and onCloseButtonPress={Navigation.dismissModal}.
If the Concierge page is used in multiple navigation contexts (e.g., full screen on mobile vs. RHP on web/tablet), I will add a conditional check — likely using useNavigationState or checking if the screen is in a modal stack — to switch between back and close behavior, consistent with how other dual-context pages in the codebase handle it.
Testing: Will verify on all listed platforms (Android app, Android mWeb, iOS app, iOS mWeb, Windows Chrome, MacOS Chrome/Safari) with screenshots confirming the close button appears on the right.
melvin-bot commentedon Apr 20, 2026
📣 @Abdullah9213! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Format:
Abdullah9213 commentedon Apr 20, 2026
Contributor details
Your Expensify account email: abdullah.ghaffar256@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01d9e5ac5bd0b4248c
melvin-bot commentedon Apr 20, 2026
✅ Contributor details stored successfully. Thank you for contributing to Expensify!
aimane-chnaif commentedon Apr 20, 2026
@mallenexpensify accepted offer
aimane-chnaif commentedon Apr 20, 2026
BugZero Checklist:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: new design update
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue: https://github.com/Expensify/Expensify/issues/626270
Regression Test Proposal
Test:
Do we agree 👍 or 👎
Zapier Logs
Run ID: 00040eee-b6c0-a132-2fa6-6d4cb240c274mallenexpensify commentedon Apr 20, 2026
@aimane-chnaif paid, summary updated above. Thx.
^ Test case created
trjExpensify commentedon May 29, 2026
approved $100 for @nyomanjyotisa