Skip to content

[Due for payment 2026-05-22] [CFI] Travel - App back button on Book travel page returns to ND instead of OD when opened from OD #82476

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.19-1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://github.com/Expensify/Mobile-Expensify/pull/13835
Email or phone of affected tester (no customers): sjiondjsondjoisjsojdos@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: iPhone 15 Pro Max / iOS 26.2
App Component: Other

Action Performed:

  1. Launch Expensify app.
  2. Go to Account > Troubleshoot > Switch to Expensify Classic.
  3. On OD, open hamburger menu > Travel.
  4. Tap app back button.

Expected Result:

App will return to Expensify Classic.

Actual Result:

App returns to ND.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Bug7077450_1771025023009.ScreenRecording_02-14-2026_07-20-14_1.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @truph01

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Feb 13, 2026
  2. melvin-bot commented on Feb 13, 2026

    @melvin-bot

    Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. github-actions commented on Feb 13, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  4. melvin-bot commented on Feb 13, 2026

    @melvin-bot

    Triggered auto assignment to @grgia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  5. melvin-bot commented on Feb 13, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  6. OSBotify commented on Feb 13, 2026

    @OSBotify
    Contributor

    🔍 Investigation Summary

    Classification: Frontend bug (HybridApp navigation issue)
    Causing PR: Mobile-Expensify#13835 - "fix: Opening travel in OD does not opens ND experience" by @truph01 (High confidence)
    Related Issues: None found

    Recommendation: REVERT

    The Mobile-Expensify PR should be reverted. It introduced query parameters to the travel URL which broke the back button navigation logic in ScreenWrapper, causing users to return to NewDot instead of OldDot.

    Labels: Keeping both DeployBlockerCash and DeployBlocker labels as this blocks both mobile (App) and needs investigation for proper fix.

    📋 Detailed Analysis

    Evidence

    Mobile-Expensify PR #13835 changed how Travel is opened from OldDot by modifying the deeplink from /travel to travel?policyID=XXX in app/Controllers/SlidingMenuController.js:

    // Before
    deeplink: API.getNewDotUrlFromPath('/travel'),
    
    // After  
    deeplink: API.getNewDotUrlFromPath('travel?policyID=' + activePolicyID),

    This PR merged on 2026-02-12 and is listed in the current StagingDeployCash (#82449).

    Verification

    The issue occurs specifically when:

    1. User switches from NewDot to Expensify Classic (OldDot)
    2. Opens Travel from OldDot hamburger menu
    3. Presses the back button on the Travel page

    Affected file in App: /home/runner/_work/App/App/src/components/ScreenWrapper/index.tsx (lines 173-178)

    Root Cause

    The ScreenWrapper component has logic to close NewDot and return to OldDot when navigating back from a "single entry" screen:

    usePreventRemove(isSingleNewDotEntry && !!initialURL?.endsWith(Navigation.getActiveRouteWithoutParams()), () => {
        closeReactNativeApp({shouldSetNVP: false, isTrackingGPS: false});
    });

    The bug:

    • initialURL from OldDot is now "travel?policyID=123" (with query params)
    • getActiveRouteWithoutParams() returns "travel" (without query params)
    • The check "travel?policyID=123".endsWith("travel") returns FALSE
    • Therefore usePreventRemove doesn't trigger
    • Back button navigates within NewDot instead of closing and returning to OldDot

    The Mobile-Expensify PR inadvertently broke the route matching by adding query parameters that the App's ScreenWrapper wasn't designed to handle.

    Alternative Fix

    If reverting is problematic, the fix could be made in App by updating the ScreenWrapper logic to strip query parameters from initialURL before comparison. However, reverting Mobile-Expensify#13835 is the safer, faster approach to unblock the deploy.

  7. 91 remaining items

  8. mallenexpensify commented on May 25, 2026

    @mallenexpensify
    Contributor

    @truph01 is this a regression of https://github.com/Expensify/Mobile-Expensify/pull/13835?

    Looks like it to me, waiting for @truph01 to reply before doing anything.

  9. melvin-bot commented on Jun 1, 2026

    @melvin-bot

    @truph01 Eep! 4 days overdue now. Issues have feelings too...

  10. JmillsExpensify commented on Jun 3, 2026

    @JmillsExpensify
    Contributor

    Waiting on reply

  11. truph01 commented on Jun 4, 2026

    @truph01
    Contributor

    @truph01 is this a regression of https://github.com/Expensify/Mobile-Expensify/pull/13835?

    No, it isn't regression from our PR, based on the RCA #82476 (comment)

  12. mallenexpensify commented on Jun 4, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor: @truph01 due $250 via NewDot
    Contributor+: @QichenZhu due $250 via NewDot

    ^ Test case created. Thx

  13. trjExpensify commented on Jun 19, 2026

    @trjExpensify
    Contributor

    approved $250 for @QichenZhu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringInternalRequires API changes or must be handled by Expensify staff

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions