You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-05-22] [CFI] Travel - App back button on Book travel page returns to ND instead of OD when opened from OD #82476
Version Number: 9.3.19-1 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack:https://github.com/Expensify/Mobile-Expensify/pull/13835 Email or phone of affected tester (no customers):sjiondjsondjoisjsojdos@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: iPhone 15 Pro Max / iOS 26.2 App Component: Other
Action Performed:
Launch Expensify app.
Go to Account > Troubleshoot > Switch to Expensify Classic.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug (HybridApp navigation issue) Causing PR: Mobile-Expensify#13835 - "fix: Opening travel in OD does not opens ND experience" by @truph01 (High confidence) Related Issues: None found
Recommendation: REVERT
The Mobile-Expensify PR should be reverted. It introduced query parameters to the travel URL which broke the back button navigation logic in ScreenWrapper, causing users to return to NewDot instead of OldDot.
Labels: Keeping both DeployBlockerCash and DeployBlocker labels as this blocks both mobile (App) and needs investigation for proper fix.
📋 Detailed Analysis
Evidence
Mobile-Expensify PR #13835 changed how Travel is opened from OldDot by modifying the deeplink from /travel to travel?policyID=XXX in app/Controllers/SlidingMenuController.js:
// Beforedeeplink: API.getNewDotUrlFromPath('/travel'),// After deeplink: API.getNewDotUrlFromPath('travel?policyID='+activePolicyID),
This PR merged on 2026-02-12 and is listed in the current StagingDeployCash (#82449).
Verification
The issue occurs specifically when:
User switches from NewDot to Expensify Classic (OldDot)
Opens Travel from OldDot hamburger menu
Presses the back button on the Travel page
Affected file in App: /home/runner/_work/App/App/src/components/ScreenWrapper/index.tsx (lines 173-178)
Root Cause
The ScreenWrapper component has logic to close NewDot and return to OldDot when navigating back from a "single entry" screen:
The check "travel?policyID=123".endsWith("travel") returns FALSE
Therefore usePreventRemove doesn't trigger
Back button navigates within NewDot instead of closing and returning to OldDot
The Mobile-Expensify PR inadvertently broke the route matching by adding query parameters that the App's ScreenWrapper wasn't designed to handle.
Alternative Fix
If reverting is problematic, the fix could be made in App by updating the ScreenWrapper logic to strip query parameters from initialURL before comparison. However, reverting Mobile-Expensify#13835 is the safer, faster approach to unblock the deploy.
Activity
melvin-bot commentedon Feb 13, 2026
Triggered auto assignment to @JmillsExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.github-actions commentedon Feb 13, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Feb 13, 2026
Triggered auto assignment to @grgia (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Feb 13, 2026
💬 A slack conversation has been started in #expensify-open-source
OSBotify commentedon Feb 13, 2026
🔍 Investigation Summary
Classification: Frontend bug (HybridApp navigation issue)
Causing PR: Mobile-Expensify#13835 - "fix: Opening travel in OD does not opens ND experience" by @truph01 (High confidence)
Related Issues: None found
Recommendation: REVERT
The Mobile-Expensify PR should be reverted. It introduced query parameters to the travel URL which broke the back button navigation logic in ScreenWrapper, causing users to return to NewDot instead of OldDot.
Labels: Keeping both
DeployBlockerCashandDeployBlockerlabels as this blocks both mobile (App) and needs investigation for proper fix.📋 Detailed Analysis
Evidence
Mobile-Expensify PR #13835 changed how Travel is opened from OldDot by modifying the deeplink from
/traveltotravel?policyID=XXXinapp/Controllers/SlidingMenuController.js:This PR merged on 2026-02-12 and is listed in the current StagingDeployCash (#82449).
Verification
The issue occurs specifically when:
Affected file in App:
/home/runner/_work/App/App/src/components/ScreenWrapper/index.tsx(lines 173-178)Root Cause
The ScreenWrapper component has logic to close NewDot and return to OldDot when navigating back from a "single entry" screen:
The bug:
initialURLfrom OldDot is now"travel?policyID=123"(with query params)getActiveRouteWithoutParams()returns"travel"(without query params)"travel?policyID=123".endsWith("travel")returns FALSEusePreventRemovedoesn't triggerThe Mobile-Expensify PR inadvertently broke the route matching by adding query parameters that the App's ScreenWrapper wasn't designed to handle.
Alternative Fix
If reverting is problematic, the fix could be made in App by updating the ScreenWrapper logic to strip query parameters from
initialURLbefore comparison. However, reverting Mobile-Expensify#13835 is the safer, faster approach to unblock the deploy.91 remaining items
mallenexpensify commentedon May 25, 2026
Looks like it to me, waiting for @truph01 to reply before doing anything.
melvin-bot commentedon Jun 1, 2026
@truph01 Eep! 4 days overdue now. Issues have feelings too...
JmillsExpensify commentedon Jun 3, 2026
Waiting on reply
truph01 commentedon Jun 4, 2026
No, it isn't regression from our PR, based on the RCA #82476 (comment)
mallenexpensify commentedon Jun 4, 2026
Payment Summary
Contributor: @truph01 due $250 via NewDot
Contributor+: @QichenZhu due $250 via NewDot
^ Test case created. Thx
trjExpensify commentedon Jun 19, 2026
approved $250 for @QichenZhu