Skip to content

Invoice- Missing option "Add bank account" when click on Pay as an individual/ business #82485

Closed

Description

@nlemma

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.3.19-1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-5252/folder/13176671/41237470/1189839098
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Bug source: Regression TC Execution
Device used: Win 11/Chrome
App Component: Money Requests

Action Performed:

Precondition: Create account A and B with Profile setting currency USD, workspace setting currency USD. On account A enable Invoice for workspace

  1. Open https://staging.new.expensify.com
  2. User A send invoice to user B
  3. User B navigate to user A invoice report
  4. User B click on the dropdown menu in Pay button of report preview or invoice detail page
  5. User B click on Pay as an individual and observe
  6. User B click on Pay as a business and observe

Expected Result:

Click on "Pay as an individual" or "Pay as a business" should display with the options "Add bank account" and "Mark as paid"

Actual Result:

Click on "Pay as an individual" or "Pay as a business" is only displayed option "Mark as paid"

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Bug7077549_1771039584825.Recording__1817.mp4

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 14, 2026
  2. melvin-bot commented on Feb 14, 2026

    @melvin-bot

    Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Feb 14, 2026

    @melvin-bot

    Triggered auto assignment to @AndrewGable (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Feb 14, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Feb 14, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. OSBotify commented on Feb 14, 2026

    @OSBotify
    Contributor

    🔍 Investigation Summary

    Classification: Frontend bug
    Causing PR: #82046 - "Hide paying invoices via Expensify behind a beta" by @cristipaval (High confidence)
    Related Issues: #67218

    Recommendation: REVERT

    PR #82046 should be reverted. The PR hides the "Add bank account" option for invoice payments behind a beta flag (PAY_INVOICE_VIA_EXPENSIFY). Users without this beta enabled only see "Mark as paid" instead of both "Add bank account" and "Mark as paid" options, which breaks the invoice payment flow for all users not enrolled in the beta.

    Labels: Keeping DeployBlockerCash (Frontend bug - App deploy is blocked). No DeployBlocker label present to remove.

    📋 Detailed Analysis

    Evidence

    • The bug affects invoice payment options - specifically the "Add bank account" option is missing
    • Issue is reproducible on staging but NOT on production
    • PR Hide paying invoices via Expensify behind a beta #82046 was merged on 2026-02-12 and is in the staging deploy checklist (Internal QA section)
    • The PR intentionally hides invoice payment options behind a beta flag

    Verification

    The PR modifies these files related to invoice payment options:

    • src/hooks/usePaymentOptions.ts - Changed line 169 from isCurrencySupported to showPayViaExpensifyOptions = isPayInvoiceViaExpensifyBetaEnabled && isCurrencySupportedForGlobalReimbursement(...)
    • src/hooks/useBulkPayOptions.ts - Same pattern
    • src/components/SettlementButton/index.tsx - Same pattern

    The logic changed from showing payment options based on currency support to requiring both:

    1. Beta flag enabled (isPayInvoiceViaExpensifyBetaEnabled)
    2. Currency supported

    This means users without the beta flag enrolled will not see "Add bank account" options, only "Mark as paid".

    Root Cause

    PR #82046 introduced a beta flag check that gates access to invoice payment options. The condition on line 169 of usePaymentOptions.ts:

    const showPayViaExpensifyOptions = isPayInvoiceViaExpensifyBetaEnabled && isCurrencySupportedForGlobalReimbursement(currency as CurrencyType);

    When isPayInvoiceViaExpensifyBetaEnabled is false (for users not in the beta), showPayViaExpensifyOptions becomes false, which causes lines 205 and 212 to filter out:

    • Bank account payment options (line 205)
    • The "Add bank account" button (line 212)

    This leaves only the "Mark as paid" option visible to non-beta users.

  7. mountiny commented on Feb 15, 2026

    @mountiny
    Contributor

    @cristipaval Is this intentional from your PR? I am not sure

  8. self-assigned this
    on Feb 16, 2026
  9. mountiny commented on Feb 16, 2026

    @mountiny
    Contributor

    Since this is last blocker I will test the revert https://github.com/Expensify/App/pull/82546/changes

  10. IuliiaHerets commented on Feb 16, 2026

    @IuliiaHerets

    Chrome / v9.3.19-3 PR:82546
    Passed

    Screen.Recording.2026-02-16.at.13.38.14.mp4
  11. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Feb 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions