You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$250] [Ready for Payment] IOU - Rate field disabled if destination is self DM and no workspace during manual track distance #82594
🚨 Edited by proposal-police: This proposal was edited at 2026-02-16 19:55:43 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
IOU - Rate field disabled if destination is self DM and no workspace during manual track distance
What is the root cause of that problem?
The Rate field has a condition !isUnreported in both the shouldShowRightIcon and interactive props, which prevented the field from being clickable when the transaction was unreported (i.e., going to self-DM).
So that it allows the Rate field to be clickable when tracking expenses (even if unreported)
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
Please re-state the problem that we are trying to solve in this issue.
IOU - Rate field disabled if destination is self DM and no workspace during manual track distance
What is the root cause of that problem?
The Rate row on the confirm step is only interactive when !!rate is true in MoneyRequestConfirmationListFooter.tsx. With self DM and no workspace there is no policy, so DistanceRequestUtils.getRate() can return a mileage rate with no rate (e.g. no default, or rate not set yet). Then !!rate is false and the row is non-interactive even though the onPress handler is correct: for non–policy chats it should open the Upgrade page. So the bug is the condition that gates interactivity, not the navigation logic.
What changes do you think we should make in order to solve the problem?
We should allow the Rate row to be interactive when there’s no workspace (self DM)
In MoneyRequestConfirmationListFooter.tsx, the Rate row is only interactive when !!rate is true. When the destination is self DM and there’s no workspace, there is no policy and rate can be missing, so the row is not clickable. Change the condition so the row is interactive when there is a rate or when it’s not a policy expense chat (self DM).
Update interactive for the Rate row
so the row is clickable for self DM even when rate is falsy.
Update shouldShowRightIcon for the Rate row
Use the same condition for the right caret:
so the caret only shows when the row is tappable.
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
⚠️@twilight2294 Your proposal is a duplicate of an already existing proposal and has been automatically withdrawn to prevent spam. Please review the existing proposals before submitting a new one.
changed the title [-][Ready for Payment] IOU - Rate field disabled if destination is self DM and no workspace during manual track distance[/-][+][$250] [Ready for Payment] IOU - Rate field disabled if destination is self DM and no workspace during manual track distance[/+]on Mar 25, 2026
📣 @lorretheboy You have been assigned to this job!
Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs!
Keep in mind: Code of Conduct | Contributing 📖
Activity
melvin-bot commentedon Feb 16, 2026
Triggered auto assignment to Contributor-plus team member for initial proposal review - @suneox (
External)melvin-bot commentedon Feb 16, 2026
Triggered auto assignment to @sonialiap (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Feb 16, 2026
Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.
lorretheboy commentedon Feb 16, 2026
🚨 Edited by proposal-police: This proposal was edited at 2026-02-16 19:55:43 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
IOU - Rate field disabled if destination is self DM and no workspace during manual track distance
What is the root cause of that problem?
The Rate field has a condition !isUnreported in both the shouldShowRightIcon and interactive props, which prevented the field from being clickable when the transaction was unreported (i.e., going to self-DM).
App/src/components/MoneyRequestConfirmationListFooter.tsx
Line 554 in 35a55d7
What changes do you think we should make in order to solve the problem?
Update to
So that it allows the Rate field to be clickable when tracking expenses (even if unreported)
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
samranahm commentedon Feb 16, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
IOU - Rate field disabled if destination is self DM and no workspace during manual track distance
What is the root cause of that problem?
The Rate row on the confirm step is only interactive when !!rate is true in MoneyRequestConfirmationListFooter.tsx. With self DM and no workspace there is no policy, so DistanceRequestUtils.getRate() can return a mileage rate with no rate (e.g. no default, or rate not set yet). Then !!rate is false and the row is non-interactive even though the onPress handler is correct: for non–policy chats it should open the Upgrade page. So the bug is the condition that gates interactivity, not the navigation logic.
What changes do you think we should make in order to solve the problem?
We should allow the Rate row to be interactive when there’s no workspace (self DM)
In
MoneyRequestConfirmationListFooter.tsx, the Rate row is only interactive when!!rateis true. When the destination is self DM and there’s no workspace, there is no policy and rate can be missing, so the row is not clickable. Change the condition so the row is interactive when there is a rate or when it’s not a policy expense chat (self DM).Update interactive for the Rate row
here
App/src/components/MoneyRequestConfirmationListFooter.tsx
Line 554 in 3be7fc6
App/src/components/MoneyRequestConfirmationListFooter.tsx
Line 582 in 3be7fc6
so the row is clickable for self DM even when rate is falsy.
Update shouldShowRightIcon for the Rate row
Use the same condition for the right caret:
so the caret only shows when the row is tappable.
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
twilight2294 commentedon Feb 17, 2026
🚫 Duplicated proposal withdrawn by 🤖 ProposalPolice.
github-actions commentedon Feb 17, 2026
50 remaining items
melvin-bot commentedon Mar 25, 2026
Current assignee @suneox is eligible for the External assigner, not assigning anyone new.
[-][Ready for Payment] IOU - Rate field disabled if destination is self DM and no workspace during manual track distance[/-][+][$250] [Ready for Payment] IOU - Rate field disabled if destination is self DM and no workspace during manual track distance[/+]melvin-bot commentedon Mar 25, 2026
Job added to Upwork: https://www.upwork.com/jobs/~022036911844599092850
melvin-bot commentedon Mar 25, 2026
📣 @lorretheboy You have been assigned to this job!
Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs!
Keep in mind: Code of Conduct | Contributing 📖
garrettmknight commentedon Mar 25, 2026
Payment Summary
garrettmknight commentedon Mar 25, 2026
@lorretheboy offer out to you here
lorretheboy commentedon Mar 26, 2026
@garrettmknight I accepted the offer
garrettmknight commentedon Mar 27, 2026
Done!
trjExpensify commentedon Mar 27, 2026
approved $250 for @suneox