Skip to content

[$250] [Ready for Payment] IOU - Rate field disabled if destination is self DM and no workspace during manual track distance #82594

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.3.20-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-5427/folder/18717689/49855697/1193287714
Email or phone of affected tester (no customers): applausetester+ck2162610@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: Regression TC Execution
Device used: Windows 11/Chrome, iPhone 16/iOS 18.7.1, Pixel 8a/Android 16
App Component: Money Requests

Action Performed:

Precondition:

  1. Use new Expensifail account
  2. The user does not have workspace
  3. User have Self-DM
    Steps:
  4. Navigate to staging.new.expensify.com
  5. Click the + global create button, select "Track Distance", and go to the "Manual" tab
  6. Enter a valid distance and click "Next"
  7. Select the user’s email address(Personal) as the recipient
  8. On confirm page, observe Rate row is not clickable

Expected Result:

"Rate" option row in confirm page should be clickable & clicking on it should display the Upgrade pge

Actual Result:

Rate field not clickable if destination is self DM and no workspace during manual track distance flow

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Bug7079676_1771268812163.60.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @lorretheboy
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~022036911844599092850
  • Upwork Job ID: 2036911844599092850
  • Last Price Increase: 2026-03-25

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Feb 16, 2026
  2. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 16, 2026
  3. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 16, 2026
  4. melvin-bot commented on Feb 16, 2026

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @suneox (External)

  5. melvin-bot commented on Feb 16, 2026

    @melvin-bot

    Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  6. melvin-bot commented on Feb 16, 2026

    @melvin-bot

    Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.

  7. lorretheboy commented on Feb 16, 2026

    @lorretheboy
    Contributor

    🚨 Edited by proposal-police: This proposal was edited at 2026-02-16 19:55:43 UTC.

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    IOU - Rate field disabled if destination is self DM and no workspace during manual track distance

    What is the root cause of that problem?

    The Rate field has a condition !isUnreported in both the shouldShowRightIcon and interactive props, which prevented the field from being clickable when the transaction was unreported (i.e., going to self-DM).

    shouldShowRightIcon={!!rate && !isReadOnly && iouType !== CONST.IOU.TYPE.SPLIT && !isUnreported}

    What changes do you think we should make in order to solve the problem?

    Update to

                        shouldShowRightIcon={!!rate && !isReadOnly && iouType !== CONST.IOU.TYPE.SPLIT && (!isUnreported || isTrackExpense)}
    
                        interactive={!!rate && !isReadOnly && iouType !== CONST.IOU.TYPE.SPLIT && (!isUnreported || isTrackExpense)}

    So that it allows the Rate field to be clickable when tracking expenses (even if unreported)

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  8. samranahm commented on Feb 16, 2026

    @samranahm
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    IOU - Rate field disabled if destination is self DM and no workspace during manual track distance

    What is the root cause of that problem?

    The Rate row on the confirm step is only interactive when !!rate is true in MoneyRequestConfirmationListFooter.tsx. With self DM and no workspace there is no policy, so DistanceRequestUtils.getRate() can return a mileage rate with no rate (e.g. no default, or rate not set yet). Then !!rate is false and the row is non-interactive even though the onPress handler is correct: for non–policy chats it should open the Upgrade page. So the bug is the condition that gates interactivity, not the navigation logic.

    What changes do you think we should make in order to solve the problem?

    We should allow the Rate row to be interactive when there’s no workspace (self DM)
    In MoneyRequestConfirmationListFooter.tsx, the Rate row is only interactive when !!rate is true. When the destination is self DM and there’s no workspace, there is no policy and rate can be missing, so the row is not clickable. Change the condition so the row is interactive when there is a rate or when it’s not a policy expense chat (self DM).
    Update interactive for the Rate row

    interactive={(!!rate || !isPolicyExpenseChat) && !isReadOnly && iouType !== CONST.IOU.TYPE.SPLIT && !isUnreported}
    shouldShowRightIcon={(!!rate || !isPolicyExpenseChat) && !isReadOnly && iouType !== CONST.IOU.TYPE.SPLIT && !isUnreported}

    here

    shouldShowRightIcon={!!rate && !isReadOnly && iouType !== CONST.IOU.TYPE.SPLIT && !isUnreported}

    interactive={!!rate && !isReadOnly && iouType !== CONST.IOU.TYPE.SPLIT && !isUnreported}

    so the row is clickable for self DM even when rate is falsy.
    Update shouldShowRightIcon for the Rate row
    Use the same condition for the right caret:
    so the caret only shows when the row is tappable.

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  9. twilight2294 commented on Feb 17, 2026

    @twilight2294
    Contributor

    🚫 Duplicated proposal withdrawn by 🤖 ProposalPolice.

  10. github-actions commented on Feb 17, 2026

    @github-actions
    Contributor

    ⚠️ @twilight2294 Your proposal is a duplicate of an already existing proposal and has been automatically withdrawn to prevent spam. Please review the existing proposals before submitting a new one.

  11. 50 remaining items

  12. melvin-bot commented on Mar 25, 2026

    @melvin-bot

    Current assignee @suneox is eligible for the External assigner, not assigning anyone new.

  13. changed the title [-][Ready for Payment] IOU - Rate field disabled if destination is self DM and no workspace during manual track distance[/-] [+][$250] [Ready for Payment] IOU - Rate field disabled if destination is self DM and no workspace during manual track distance[/+] on Mar 25, 2026
  14. melvin-bot commented on Mar 25, 2026

    @melvin-bot
  15. removed
    Help WantedApply this label when an issue is open to proposals by contributors
    on Mar 25, 2026
  16. melvin-bot commented on Mar 25, 2026

    @melvin-bot

    📣 @lorretheboy You have been assigned to this job!
    Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
    Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs!
    Keep in mind: Code of Conduct | Contributing 📖

  17. garrettmknight commented on Mar 25, 2026

    @garrettmknight
    Contributor

    Payment Summary

  18. garrettmknight commented on Mar 25, 2026

    @garrettmknight
    Contributor

    @lorretheboy offer out to you here

  19. lorretheboy commented on Mar 26, 2026

    @lorretheboy
    Contributor

    @garrettmknight I accepted the offer

  20. garrettmknight commented on Mar 27, 2026

    @garrettmknight
    Contributor

    Done!

  21. trjExpensify commented on Mar 27, 2026

    @trjExpensify
    Contributor

    approved $250 for @suneox

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributorMelvin TriageAutomatic AI Analysis of an issue

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions