You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-03-02] Add Sentry spans for expense creation flow #82993
When analyzing expense creation performance in Sentry, all expense flows (request money, distance, split, track, invoice) are mixed under one broad span. This makes it hard to identify which specific flow has performance issues and to measure the full round-trip including server response time.
Solution
Add granular Sentry spans to the expense creation flow:
Add ManualSubmitExpense span measuring confirm tap → API dispatch, tagged with scenario attribute (e.g. request_money_manual, distance, split, track_expense, invoice) to distinguish flows
Add ManualNavigateAfterExpenseCreate span measuring post-submit navigation to the Search page
Add SentryServerTiming middleware that creates a ManualExpenseServerResponse span for expense write commands
changed the title [-]Add Sentry spans for expense creation flow[/-][+][Due for payment 2026-03-02] Add Sentry spans for expense creation flow[/+]on Feb 23, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.24-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
This wasn't a bug but adding the label because I think @bernhardoj was C+ on this and not sure if this is ready to be closed yet. The PR has been deployed for some time.
Summary: This is an enhancement (not a bug) to add granular Sentry performance spans to the expense creation flow. The linked PR (#82287) was merged on 2026-02-19 and deployed to production in version 9.3.24-3.
Current Status: The implementation is complete and deployed. The PR added:
ManualSubmitExpense span (confirm tap → API dispatch) with scenario tagging
src/libs/telemetry/markSubmitExpenseEnd.ts — submit span end marker
src/libs/telemetry/markNavigateAfterExpenseCreateEnd.ts — navigation span end marker
src/pages/iou/request/step/IOURequestStepConfirmation.tsx — span start on confirm
src/components/Search/index.tsx — navigation span end on Search page render
src/libs/API/index.ts — middleware integration
Assessment: The work is done and deployed. The 7-day regression period (ending 2026-03-02) has passed without reported regressions. This issue appears ready to be closed and payment processed.
Next Steps: This issue can likely be closed. bernhardoj (C+) may want to confirm the regression period is clear before closing.
Activity
[-]Add Sentry spans for expense creation flow[/-][+][Due for payment 2026-03-02] Add Sentry spans for expense creation flow[/+]melvin-bot commentedon Feb 23, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Feb 23, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.24-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-03-02. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Mar 5, 2026
@OlimpiaZurek, @marcaaron, @bernhardoj Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
melvin-bot commentedon Mar 9, 2026
@OlimpiaZurek, @marcaaron, @bernhardoj 6 days overdue. This is scarier than being forced to listen to Vogon poetry!
melvin-bot commentedon Mar 9, 2026
@OlimpiaZurek, @marcaaron, @bernhardoj 6 days overdue. This is scarier than being forced to listen to Vogon poetry!
melvin-bot commentedon Mar 9, 2026
Triggered auto assignment to @JmillsExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.marcaaron commentedon Mar 9, 2026
This wasn't a bug but adding the label because I think @bernhardoj was C+ on this and not sure if this is ready to be closed yet. The PR has been deployed for some time.
MelvinBot commentedon Mar 9, 2026
🔍 Issue Analysis
Summary: This is an enhancement (not a bug) to add granular Sentry performance spans to the expense creation flow. The linked PR (#82287) was merged on 2026-02-19 and deployed to production in version 9.3.24-3.
Current Status: The implementation is complete and deployed. The PR added:
ManualSubmitExpensespan (confirm tap → API dispatch) with scenario taggingManualNavigateAfterExpenseCreatespan (post-submit navigation)SentryServerTimingmiddleware forManualExpenseServerResponsespansFiles changed in the PR:
src/CONST/index.ts— new span/scenario constantssrc/libs/Middleware/SentryServerTiming.ts— new middleware for server timing spanssrc/libs/actions/IOU/index.ts— span instrumentation in IOU actionssrc/libs/telemetry/getSubmitExpenseScenario.ts— scenario classification helpersrc/libs/telemetry/markSubmitExpenseEnd.ts— submit span end markersrc/libs/telemetry/markNavigateAfterExpenseCreateEnd.ts— navigation span end markersrc/pages/iou/request/step/IOURequestStepConfirmation.tsx— span start on confirmsrc/components/Search/index.tsx— navigation span end on Search page rendersrc/libs/API/index.ts— middleware integrationAssessment: The work is done and deployed. The 7-day regression period (ending 2026-03-02) has passed without reported regressions. This issue appears ready to be closed and payment processed.
Next Steps: This issue can likely be closed.
bernhardoj(C+) may want to confirm the regression period is clear before closing.JmillsExpensify commentedon Mar 9, 2026
This is eligible for payment now.
Summary: $250 @bernhardoj for PR review and testing. Paid via New Expensify.
bernhardoj commentedon Mar 10, 2026
Requested in ND.
garrettmknight commentedon Mar 10, 2026
$250 approved for @bernhardoj