You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-03-06] [$250] Onboarding-App crashes when completed test drive as Get paid and opening Reports #83267
Version Number: 9.3.25-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack:https://test-management.browserstack.com/projects/2219752/folder/13176677/test-cases/41237682 Email or phone of affected tester (no customers): N/A Issue reported by: Applause Internal Team Bug source: Regression TC Execution Device used: MacBook Air 15.7.4 Chrome App Component: Money Requests
Action Performed:
Sign up with a new gmail account (without a +), choose Get paid back purpose
Complete the test drive with another fake gmail
Open the created expense, then close
Go to the Reports page
Expected Result:
User can open Reports page successfully
Actual Result:
The app crashes after completing test drive as Get paid and opening Reports
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Please re-state the problem that we are trying to solve in this issue.
After completing onboarding with the "Get paid back" purpose and finishing the test drive, the app crashes when navigating to the Reports page. The crash is a TypeError: Cannot read properties of undefined (reading 'toString') occurring in the UserSelectPopup component.
What is the root cause of that problem?
The root cause is in createOptionList in src/libs/PersonalDetailOptionsListUtils/index.ts:386-389. When iterating over personalDetailsList (typed as Record<string, PersonalDetails | null>), null entries are converted into empty objects via an unsafe type cast:
constallPersonalDetailsOptions=Object.values(personalDetails).map((personalDetail)=>{if(!personalDetail){return{}asOptionData;// ← empty object with accountID: undefined}// ...});
These empty {} as OptionData objects have accountID: undefined at runtime, even though TypeScript thinks they satisfy the OptionData type.
Although getValidOptions (called on line 84) would filter out entries without accountID, the crash happens in transformedOptions (line 74) which executes beforegetValidOptions is called.
After onboarding, personalDetailsList in Onyx contains null entries (which is valid per its type), and these flow through unfiltered to the crash site.
What changes do you think we should make in order to solve the problem?
The fix should be in createOptionList in src/libs/PersonalDetailOptionsListUtils/index.ts. Instead of returning {} as OptionData for null personalDetails entries, we should filter them out:
constallPersonalDetailsOptions=Object.values(personalDetails).filter((personalDetail): personalDetail is NonNullable<typeofpersonalDetail>=>!!personalDetail).map((personalDetail)=>{// ... existing createOption logic});
This addresses the root cause by never producing empty objects in the options array. The downstream .toString() calls in UserSelectPopup (lines 78, 97, 121, 123) will then always receive options with valid accountID values.
What alternative solutions did you explore? (Optional)
An alternative is to add defensive guards in UserSelectPopup.tsx at each .toString() call site (lines 78, 97, 121, 123), e.g., option.accountID?.toString() ?? ''. However, this treats the symptom rather than the root cause — the real problem is that createOptionList produces invalid OptionData objects that violate the type contract. Fixing it at the source prevents similar crashes in any other consumer of this function.
Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, or @MelvinBot <your feedback> to refine this analysis.
changed the title [-][$250] Onboarding-App crashes when completed test drive as Get paid and opening Reports[/-][+][Due for payment 2026-03-06] [$250] Onboarding-App crashes when completed test drive as Get paid and opening Reports[/+]on Feb 27, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.26-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@hoangzinh / @shubham1206agra@brianlee-expensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon Feb 23, 2026
Triggered auto assignment to @brianlee-expensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Feb 23, 2026
Triggered auto assignment to @lakchote (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Feb 23, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Feb 23, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Feb 23, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
After completing onboarding with the "Get paid back" purpose and finishing the test drive, the app crashes when navigating to the Reports page. The crash is a
TypeError: Cannot read properties of undefined (reading 'toString')occurring in theUserSelectPopupcomponent.What is the root cause of that problem?
The root cause is in
createOptionListinsrc/libs/PersonalDetailOptionsListUtils/index.ts:386-389. When iterating overpersonalDetailsList(typed asRecord<string, PersonalDetails | null>), null entries are converted into empty objects via an unsafe type cast:These empty
{} as OptionDataobjects haveaccountID: undefinedat runtime, even though TypeScript thinks they satisfy theOptionDatatype.The
UserSelectPopupcomponent (src/components/Search/FilterDropdowns/UserSelectPopup.tsx:74-81) maps over these options and calls.toString()onaccountIDbefore any filtering occurs:Although
getValidOptions(called on line 84) would filter out entries withoutaccountID, the crash happens intransformedOptions(line 74) which executes beforegetValidOptionsis called.After onboarding,
personalDetailsListin Onyx contains null entries (which is valid per its type), and these flow through unfiltered to the crash site.What changes do you think we should make in order to solve the problem?
The fix should be in
createOptionListinsrc/libs/PersonalDetailOptionsListUtils/index.ts. Instead of returning{} as OptionDatafor null personalDetails entries, we should filter them out:This addresses the root cause by never producing empty objects in the options array. The downstream
.toString()calls inUserSelectPopup(lines 78, 97, 121, 123) will then always receive options with validaccountIDvalues.What alternative solutions did you explore? (Optional)
An alternative is to add defensive guards in
UserSelectPopup.tsxat each.toString()call site (lines 78, 97, 121, 123), e.g.,option.accountID?.toString() ?? ''. However, this treats the symptom rather than the root cause — the real problem is thatcreateOptionListproduces invalidOptionDataobjects that violate the type contract. Fixing it at the source prevents similar crashes in any other consumer of this function.Next Steps for Contributor+ team: Reply with
@MelvinBot implement thisto create a draft PR, or@MelvinBot <your feedback>to refine this analysis.24 remaining items
[-][$250] Onboarding-App crashes when completed test drive as Get paid and opening Reports[/-][+][Due for payment 2026-03-06] [$250] Onboarding-App crashes when completed test drive as Get paid and opening Reports[/+]melvin-bot commentedon Feb 27, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Feb 27, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.26-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-03-06. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Feb 27, 2026
@hoangzinh / @shubham1206agra @brianlee-expensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
brianlee-expensify commentedon Feb 27, 2026
@mountiny just wanted to confirm whether payment is still required for this GH?
mountiny commentedon Feb 27, 2026
Not needed