Skip to content

[$250] [Due for payment 2026-04-14] [Odometer] DRY shared camera logic between IOURequestStepScan and Odometer image capture #83356

Closed

Description

@Julesssss

Parent issue: #71841

Follow up improvement issue from #82432


The Odometer image capture flow (IOURequestStepDistanceOdometerScan) duplicates significant logic from src/pages/iou/request/step/IOURequestStepScan/index.native.tsx. Extract shared functions/hooks/components to be reused in both places.

Improvements include: (some were already applied to PR updates)

  • Remove useEffect watching focusPoint - call focusCamera directly from tap
    gesture handler
  • Missing return after showCameraAlert() when camera.current
  • tapGesture / capturePhoto duplication
  • Child components
  • CONSISTENCY-6: Missing .catch() on cropImageToAspectRatio().then()
  • CONSISTENCY-5: eslint-disable at line 408 lacks justification comment
  • P1 (Codex): Hardcoded shouldUseTransactionDraft(CONST.IOU.ACTION.CREATE,
    CONST.IOU.TYPE.REQUEST)
  • Magic number style values should use named constants
Issue OwnerCurrent Issue Owner: @Eskalifer1
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~022044859033912396201
  • Upwork Job ID: 2044859033912396201
  • Last Price Increase: 2026-04-16

Activity

  1. self-assigned this
    on Feb 24, 2026
  2. jakubkalinski0 commented on Mar 1, 2026

    @jakubkalinski0
    Member

    This topic should be taken into account and discussed when resolving this issue a471d44#r2857231314

    Full context
    • issue:
    Image
    • change and discussion:
    Image Image Image
  3. DylanDylann commented on Mar 12, 2026

    @DylanDylann
    Contributor

    Not overdue

  4. Julesssss commented on Mar 23, 2026

    @Julesssss
    ContributorAuthor

    Not overdue

  5. added
    ReviewingHas a PR in review
    and removed on Mar 31, 2026
  6. 15 remaining items

  7. Eskalifer1 commented on Apr 14, 2026

    @Eskalifer1
    Contributor

    I think payment summary is not correct, since i was reviewing PR and @DylanDylann was implementer

    Also please assign me here, thx 😊

  8. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Apr 16, 2026
  9. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Apr 16, 2026
  10. melvin-bot commented on Apr 16, 2026

    @melvin-bot

    Current assignees @Eskalifer1 and @DylanDylann are eligible for the External assigner, not assigning anyone new.

  11. changed the title [-][Due for payment 2026-04-14] [Odometer] DRY shared camera logic between IOURequestStepScan and Odometer image capture[/-] [+][$250] [Due for payment 2026-04-14] [Odometer] DRY shared camera logic between IOURequestStepScan and Odometer image capture[/+] on Apr 16, 2026
  12. melvin-bot commented on Apr 16, 2026

    @melvin-bot
  13. removed
    Help WantedApply this label when an issue is open to proposals by contributors
    on Apr 16, 2026
  14. mallenexpensify commented on Apr 16, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @Eskalifer1 paid $250 via Upwork

    @Eskalifer1 can you please accept the job below? Please reply here and tag me once you have.
    https://www.upwork.com/jobs/~022044859033912396201

    Refactor, no checklist needed.

  15. Eskalifer1 commented on Apr 16, 2026

    @Eskalifer1
    Contributor

    Hi @mallenexpensify, i have accepted, thanks 🙏!

  16. mallenexpensify commented on Apr 16, 2026

    @mallenexpensify
    Contributor

    @Eskalifer1 paid, summary updated above. Thx.

  17. DylanDylann commented on Apr 17, 2026

    @DylanDylann
    Contributor

    Not due payment for me because this belongs to my project and I will get paid later once the project is done. @Eskalifer1 review this PR only, so please only pay him here

  18. mallenexpensify commented on Apr 17, 2026

    @mallenexpensify
    Contributor

    Thanks @DylanDylann , payment summary updated above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorImprovementItem broken or needs improvement.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions