Skip to content

[BT-150] Migrate Settings - Profile (Part 1) #83361

Closed

Description

@mjasikowski

Description

Current State:

  • 4 routes in Settings Profile section use backTo parameter
  • These routes handle profile and address settings

Implementation:

  • Replace getRoute(..., backTo) with createDynamicRoute()
  • Add source screens to entryScreens array for each route
  • Remove backTo parameter from route definitions
  • Test forward/back navigation

Scope

Routes (4):

Route Constant Path
SETTINGS_PROFILE settings/profile
SETTINGS_ADDRESS_COUNTRY settings/profile/address/country
SETTINGS_ADDRESS_STATE settings/profile/address/state
SETTINGS_CONTACT_METHODS settings/profile/contact-methods

Usages

SETTINGS_PROFILE:

  • src/pages/settings/InitialSettingsPage.tsx:225
  • src/pages/ProfilePage.tsx:258

SETTINGS_ADDRESS_COUNTRY:

  • src/components/CountrySelector.tsx:83

SETTINGS_ADDRESS_STATE:

  • src/components/StateSelector.tsx (search for usage)

SETTINGS_CONTACT_METHODS:

  • src/pages/domain/DomainResetPage.tsx:106
  • src/libs/actions/User.ts:268,1277
  • src/pages/settings/Profile/Contacts/NewContactMethodPage.tsx:113
  • src/pages/settings/Profile/Contacts/NewContactMethodConfirmMagicCodePage.tsx:45
  • src/pages/settings/Profile/Contacts/ContactMethodDetailsPage.tsx:155,193,194,306,328
  • src/pages/TeachersUnite/ImTeacherUpdateEmailPage.tsx:22,49
  • src/pages/ReimbursementAccount/ReimbursementAccountPage.tsx:116
  • src/components/BookTravelButton.tsx:57

Files to modify:

  • src/ROUTES.ts - Update route definitions
  • src/libs/Navigation/types.ts - Remove backTo from params
  • Components listed above

Migration Progress

  • SETTINGS_PROFILE
  • SETTINGS_ADDRESS_COUNTRY
  • SETTINGS_ADDRESS_STATE
  • SETTINGS_CONTACT_METHODS
Issue OwnerCurrent Issue Owner: @suneox
Issue OwnerCurrent Issue Owner: @mananjadhav

Activity

  1. added
    InternalRequires API changes or must be handled by Expensify staff
    on Feb 24, 2026
  2. changed the title [-][BT-P2-002] Settings - Profile (Part 1)[/-] [+][BT-102] Migrate Settings - Profile (Part 1)[/+] on Feb 24, 2026
  3. mananjadhav commented on Feb 24, 2026

    @mananjadhav
    Collaborator

    Taking this up as implementer.

  4. mananjadhav commented on Feb 26, 2026

    @mananjadhav
    Collaborator

    @mjasikowski I think it's best to tag @collectioneur as well. I am starting with this one.

    Quick question for @collectioneur, we've got routes like settings/profile/address/country. I thought the nested routes are not support? Can you guide here?

  5. collectioneur commented on Feb 26, 2026

    @collectioneur
    Contributor

    @mananjadhav Feel free to start with the top layer that doesn’t require complex dynamic suffixes, for this batch, that’s just contact-methods.

    In the meantime, I’ll work in parallel on the logic for the complex suffixes. I also noticed we need to support suffix layering (e.g., /profile + /address/country), so I’ll handle that as well. You're absolutely right though, that hasn't been implemented yet 😔

  6. mananjadhav commented on Feb 26, 2026

    @mananjadhav
    Collaborator

    Thanks for the information @collectioneur. I’ll get started with the base layer.

  7. mjasikowski commented on Feb 26, 2026

    @mjasikowski
    ContributorAuthor

    @collectioneur I've created an issue for you: #83551

  8. changed the title [-][BT-102] Migrate Settings - Profile (Part 1)[/-] [+][BT-150] Migrate Settings - Profile (Part 1)[/+] on Mar 2, 2026
  9. 30 remaining items

  10. melvin-bot commented on Aug 1, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  11. melvin-bot commented on Aug 2, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  12. added and removed
    ReviewingHas a PR in review
    on Aug 3, 2026
  13. melvin-bot commented on Aug 3, 2026

    @melvin-bot

    @suneox / @huult

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.48-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-08-10. 🎊

    The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

  14. melvin-bot commented on Aug 7, 2026

    @melvin-bot

    @suneox Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  15. suneox commented on Aug 10, 2026

    @suneox
    Contributor

    Not overdue. PR Part 1 has been deployed to production, and we are currently renaming keys: SETTINGS_PROFILE, SETTINGS_ADDRESS_COUNTRY

  16. huult commented on Aug 12, 2026

    @huult
    Contributor

    SETTINGS_PROFILE already defaults to the split navigator's central screen rather than an RHP overlay, so it doesn't need to be migrated to a dynamic route.

    I am migrating SETTINGS_ADDRESS_STATE and SETTINGS_CONTACT_METHODS.

    @mjasikowski @suneox #97072 (comment) All routes that can be migrated have been migrated, so we can close this ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

DailyKSv2InternalRequires API changes or must be handled by Expensify staffSkip PaymentSkips all the payment process steps for an issue. Use it for fixed-price projects.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions