Skip to content

[BT-151] Migrate Settings - Profile (Part 2) #83362

Closed

Description

@mjasikowski

Description

Current State:

  • 4 routes handle contact methods and state selection
  • These routes use backTo parameter for return navigation

Implementation:

  • Replace getRoute(..., backTo) with createDynamicRoute()
  • Add source screens to entryScreens array
  • Remove backTo parameter from route definitions
  • Test forward/back navigation

Scope

Routes (4):

Route Constant Path
SETTINGS_CONTACT_METHOD_DETAILS settings/profile/contact-methods/:contactMethod/details
SETTINGS_NEW_CONTACT_METHOD settings/profile/contact-methods/new
SETTINGS_NEW_CONTACT_METHOD_CONFIRM_MAGIC_CODE settings/profile/contact-methods/new/confirm-magic-code
MONEY_REQUEST_STATE_SELECTOR submit/state

Usages

SETTINGS_CONTACT_METHOD_DETAILS:

  • src/pages/settings/Profile/Contacts/NewContactMethodPage.tsx:120
  • src/pages/settings/Profile/Contacts/ContactMethodsPage.tsx:83

SETTINGS_NEW_CONTACT_METHOD:

  • src/pages/settings/Profile/Contacts/NewContactMethodConfirmMagicCodePage.tsx:30

SETTINGS_NEW_CONTACT_METHOD_CONFIRM_MAGIC_CODE:

  • src/pages/settings/Profile/Contacts/ContactMethodsPage.tsx:53,57

MONEY_REQUEST_STATE_SELECTOR:

  • Search for usages in IOU/expense flows

Files to modify:

  • src/ROUTES.ts - Update route definitions
  • src/libs/Navigation/types.ts - Remove backTo from params
  • Components listed above

Migration Progress

  • SETTINGS_CONTACT_METHOD_DETAILS
  • SETTINGS_NEW_CONTACT_METHOD
  • SETTINGS_NEW_CONTACT_METHOD_CONFIRM_MAGIC_CODE
  • MONEY_REQUEST_STATE_SELECTOR
Issue OwnerCurrent Issue Owner: @suneox

Activity

  1. added
    InternalRequires API changes or must be handled by Expensify staff
    on Feb 24, 2026
  2. changed the title [-][BT-P2-003] Settings - Profile (Part 2)[/-] [+][BT-103] Migrate Settings - Profile (Part 2)[/+] on Feb 24, 2026
  3. mananjadhav commented on Feb 24, 2026

    @mananjadhav
    Collaborator

    Taking this up as implementer.

  4. changed the title [-][BT-103] Migrate Settings - Profile (Part 2)[/-] [+][BT-151] Migrate Settings - Profile (Part 2)[/+] on Mar 2, 2026
  5. melvin-bot commented on Mar 25, 2026

    @melvin-bot

    This issue has not been updated in over 15 days. @mananjadhav, @mjasikowski, @huult eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

  6. 27 remaining items

  7. melvin-bot commented on Aug 14, 2026

    @melvin-bot

    @suneox / @huult

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.53-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-08-21. 🎊

    The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

  8. melvin-bot commented on Aug 17, 2026

    @melvin-bot

    @suneox Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  9. melvin-bot commented on Aug 19, 2026

    @melvin-bot

    @suneox Huh... This is 4 days overdue. Who can take care of this?

  10. huult commented on Aug 21, 2026

    @huult
    Contributor

    @mjasikowski We can close this ticket. All routes have been migrated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

DailyKSv2InternalRequires API changes or must be handled by Expensify staffSkip PaymentSkips all the payment process steps for an issue. Use it for fixed-price projects.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions