Repository navigation
Closed
Labels
DailyKSv2KSv2InternalRequires API changes or must be handled by Expensify staffRequires API changes or must be handled by Expensify staffSkip PaymentSkips all the payment process steps for an issue. Use it for fixed-price projects.Skips all the payment process steps for an issue. Use it for fixed-price projects.
Description
Description
Current State:
- 6 routes across Security, Wallet, and Subscription settings
- These routes use
backToparameter for return navigation
Implementation:
- Replace
getRoute(..., backTo)withcreateDynamicRoute() - Add source screens to
entryScreensarray - Remove
backToparameter from route definitions - Test forward/back navigation
Scope
Routes (6):
| Route Constant | Path |
|---|---|
SETTINGS_MERGE_ACCOUNTS_RESULT |
settings/security/merge-accounts/:login/result/:result |
SETTINGS_DELEGATE_ROLE |
settings/security/delegate/:login/role/:role |
SETTINGS_ADD_BANK_ACCOUNT |
settings/wallet/add-bank-account |
SETTINGS_ADD_BANK_ACCOUNT_VERIFY_ACCOUNT |
settings/wallet/add-bank-account/verify-account |
SETTINGS_SUBSCRIPTION |
settings/subscription |
SETTINGS_SUBSCRIPTION_DOWNGRADE_BLOCKED |
settings/subscription/downgrade-blocked |
Usages
SETTINGS_MERGE_ACCOUNTS_RESULT:
src/pages/settings/Security/SecuritySettingsPage.tsx:158src/pages/settings/Security/MergeAccounts/AccountValidatePage.tsx:117,126,139src/pages/settings/Security/MergeAccounts/AccountDetailsPage.tsx:106,122
SETTINGS_DELEGATE_ROLE:
src/pages/settings/Security/SecuritySettingsPage.tsx:233src/pages/settings/Security/AddDelegate/ConfirmDelegatePage.tsx:53,75src/pages/settings/Security/AddDelegate/AddDelegatePage.tsx:47
SETTINGS_ADD_BANK_ACCOUNT:
src/libs/actions/BankAccounts.ts:126src/pages/workspace/invoices/WorkspaceInvoicesVerifyAccountPage.tsx:14
SETTINGS_ADD_BANK_ACCOUNT_VERIFY_ACCOUNT:
- Search for usages in bank account flow
SETTINGS_SUBSCRIPTION:
src/pages/workspace/upgrade/GenericFeaturesView.tsx:32src/pages/workspace/WorkspaceOverviewPlanTypePage.tsx:121src/pages/settings/Subscription/FreeTrial.tsx:54src/pages/settings/Subscription/CardSection/BillingBanner/EarlyDiscountBanner.tsx:90src/pages/RestrictedAction/Workspace/WorkspaceOwnerRestrictedAction/index.native.tsx:26src/pages/workspace/upgrade/UpgradeIntro.tsx:75src/pages/workspace/upgrade/UpgradeConfirmation.tsx:31
SETTINGS_SUBSCRIPTION_DOWNGRADE_BLOCKED:
src/pages/settings/Subscription/SubscriptionPlan/SubscriptionPlanCardActionButton.tsx:70
Files to modify:
src/ROUTES.ts- Update route definitionssrc/libs/Navigation/types.ts- RemovebackTofrom params- Components listed above
Migration Progress
-
SETTINGS_MERGE_ACCOUNTS_RESULT -
SETTINGS_DELEGATE_ROLE -
SETTINGS_ADD_BANK_ACCOUNT -
SETTINGS_ADD_BANK_ACCOUNT_VERIFY_ACCOUNT -
SETTINGS_SUBSCRIPTION -
SETTINGS_SUBSCRIPTION_DOWNGRADE_BLOCKED
Issue Owner
Current Issue Owner: @suneoxMetadata
Metadata
Assignees
Labels
DailyKSv2KSv2InternalRequires API changes or must be handled by Expensify staffRequires API changes or must be handled by Expensify staffSkip PaymentSkips all the payment process steps for an issue. Use it for fixed-price projects.Skips all the payment process steps for an issue. Use it for fixed-price projects.
Activity
[-][BT-P2-004] Settings - Security/Wallet/Subscription[/-][+][BT-104] Migrate Settings - Security/Wallet/Subscription[/+]huult commentedon Feb 26, 2026
Hi @mjasikowski @collectioneur I’m running into a case with
SETTINGS_ADD_BANK_ACCOUNTwhere dynamic routing doesn’t seem to work correctly.When we’re on
settings/wallet/bank-account-purposeand append to create a dynamic route, the resulting path becomessettings/wallet/bank-account-purpose/add-bank-account, which doesn’t look correct.Screen.Recording.2026-02-26.at.23.25.02.mov
If we instead update it to
settings/wallet/add-bank-account, I’m not sure how we would navigate back to the correct page without abackToparameter. UsinggoBack()feels risky, I tried it, but I’m still concerned about potential edge cases.I checked the documentation but didn’t see this case mentioned. Could you please guide me on how we should handle this scenario?
collectioneur commentedon Feb 27, 2026
Hi @huult, great catch! This is one of the few edge cases in the app that might not be fully covered by dynamic routes alone.
For this specific scenario, a hybrid approach would likely work best. Here is how we could approach it:
add-bank-accountcan function as a dynamic suffix, we can implement it as a dynamic route.huult commentedon Feb 27, 2026
huult commentedon Mar 2, 2026
@collectioneur I saw that you opened a PR for this ticket. Just to confirm, will you be handling it? If so, I’ll work on another ticket.
[-][BT-104] Migrate Settings - Security/Wallet/Subscription[/-][+][BT-152] Migrate Settings - Security/Wallet/Subscription[/+]collectioneur commentedon Mar 2, 2026
@huult I'm going to focus specifically on the
/add-bank-account/verify-accountroute for now, as it’s a perfect test case for validating approach to multi-segment dynamic suffixes. I'm tackling only this particular route, so feel free to start investigating the migration strategy for the remaining routes in this batch 🙂49 remaining items
MelvinBot commentedon Jun 16, 2026
⏱️ Ran out of time before I could finish. This usually means the task was too complex or I got stuck exploring. Please try again with a more specific request or post in #melvinbot-ai.
Run details
[-][BT-152] Migrate Settings - Security/Wallet/Subscription[/-][+][Due for payment 2026-07-02] [BT-152] Migrate Settings - Security/Wallet/Subscription[/+]melvin-bot commentedon Jun 25, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jun 25, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.19-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-07-02. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jun 30, 2026
@suneox Huh... This is 4 days overdue. Who can take care of this?
[-][Due for payment 2026-07-02] [BT-152] Migrate Settings - Security/Wallet/Subscription[/-][+][BT-152] Migrate Settings - Security/Wallet/Subscription[/+]