Skip to content

Add reasonAttributes to SearchFiltersSkeleton usage sites #83406

Closed

Description

@MelvinBot

Problem

As part of #81683, we need to add reasonAttributes to all skeleton components so that Sentry spans carry structured metadata about why a loading indicator is visible. This helps engineers debug infinite skeleton loading states.

Solution

Add reasonAttributes to all usage sites of SearchFiltersSkeleton (src/components/Skeletons/SearchFiltersSkeleton.tsx).

At each usage site:

  1. Pass a reasonAttributes prop with a context string identifying the parent component (e.g. 'ParentComponent.ChildComponent')
  2. Include relevant boolean state variables that determine the loading state (e.g. isLoading, isDataReady)

Example

const reasonAttributes: SkeletonSpanReasonAttributes = {
    context: 'ParentComponent',
    isLoading,
    isDataReady,
};

<SearchFiltersSkeleton reasonAttributes={reasonAttributes} />

Reference

Scope

  • Component path: src/components/Skeletons/SearchFiltersSkeleton.tsx
  • Usage sites to update: ~1 file

Activity

  1. sosek108 commented on Feb 27, 2026

    @sosek108
    Contributor

    PR ready for review #83678

  2. sobitneupane commented on Mar 10, 2026

    @sobitneupane
    Contributor

    @youssef-lr I reviewed the associated PR. Could you please assign the issue to me?

  3. youssef-lr commented on Mar 14, 2026

    @youssef-lr
    Contributor

    @sobitneupane I think it's a very simple NO QA PR though so not sure if payment is needed?

  4. sobitneupane commented on Mar 16, 2026

    @sobitneupane
    Contributor

    No problem. I am okay with it being no-payment pr.

  5. melvin-bot commented on Apr 6, 2026

    @melvin-bot

    This issue has not been updated in over 15 days. @youssef-lr eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions