You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Add reasonAttributes to SearchFiltersSkeleton usage sites #83406
As part of #81683, we need to add reasonAttributes to all skeleton components so that Sentry spans carry structured metadata about why a loading indicator is visible. This helps engineers debug infinite skeleton loading states.
Solution
Add reasonAttributes to all usage sites of SearchFiltersSkeleton (src/components/Skeletons/SearchFiltersSkeleton.tsx).
At each usage site:
Pass a reasonAttributes prop with a context string identifying the parent component (e.g. 'ParentComponent.ChildComponent')
Include relevant boolean state variables that determine the loading state (e.g. isLoading, isDataReady)
This issue has not been updated in over 15 days. @youssef-lr eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
Activity
sosek108 commentedon Feb 27, 2026
PR ready for review #83678
sobitneupane commentedon Mar 10, 2026
@youssef-lr I reviewed the associated PR. Could you please assign the issue to me?
youssef-lr commentedon Mar 14, 2026
@sobitneupane I think it's a very simple NO QA PR though so not sure if payment is needed?
sobitneupane commentedon Mar 16, 2026
No problem. I am okay with it being no-payment pr.
melvin-bot commentedon Apr 6, 2026
This issue has not been updated in over 15 days. @youssef-lr eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!