Skip to content

[Due for payment 2026-03-13] Add reasonAttributes to SearchInputSelectionSkeleton usage sites #83407

Closed

Description

@MelvinBot

Problem

As part of #81683, we need to add reasonAttributes to all skeleton components so that Sentry spans carry structured metadata about why a loading indicator is visible. This helps engineers debug infinite skeleton loading states.

Solution

Add reasonAttributes to all usage sites of SearchInputSelectionSkeleton (src/components/Skeletons/SearchInputSelectionSkeleton.tsx).

At each usage site:

  1. Pass a reasonAttributes prop with a context string identifying the parent component (e.g. 'ParentComponent.ChildComponent')
  2. Include relevant boolean state variables that determine the loading state (e.g. isLoading, isDataReady)

Example

const reasonAttributes: SkeletonSpanReasonAttributes = {
    context: 'ParentComponent',
    isLoading,
    isDataReady,
};

<SearchInputSelectionSkeleton reasonAttributes={reasonAttributes} />

Reference

Scope

  • Component path: src/components/Skeletons/SearchInputSelectionSkeleton.tsx
  • Usage sites to update: ~2 files

Activity

  1. sosek108 commented on Feb 27, 2026

    @sosek108
    Contributor

    PR ready for review

  2. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Mar 6, 2026
  3. changed the title [-]Add reasonAttributes to SearchInputSelectionSkeleton usage sites[/-] [+][Due for payment 2026-03-13] Add reasonAttributes to SearchInputSelectionSkeleton usage sites[/+] on Mar 6, 2026
  4. melvin-bot commented on Mar 6, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  5. melvin-bot commented on Mar 6, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.31-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-03-13. 🎊

  6. melvin-bot commented on Mar 6, 2026

    @melvin-bot

    Triggered auto assignment to @johncschuster (Awaiting Payment)

  7. johncschuster commented on Mar 11, 2026

    @johncschuster
    Contributor

    Payment Summary

    • Contributor: @sosek108 does not require payment (Contractor)
      - Contributor+: @QichenZhu due $250 via NewDot
  8. QichenZhu commented on Mar 11, 2026

    @QichenZhu
    Contributor

    @johncschuster, I believe I’m not eligible for payment since I didn’t substantively review the PR.

  9. johncschuster commented on Mar 13, 2026

    @johncschuster
    Contributor

    @QichenZhu thank you for calling that out! In that case, I think we're all done here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions