Skip to content

[Due for payment 2026-03-13] [$75] Add reasonAttributes to SearchRowSkeleton usage sites #83408

Closed

Description

@MelvinBot

Problem

As part of #81683, we need to add reasonAttributes to all skeleton components so that Sentry spans carry structured metadata about why a loading indicator is visible. This helps engineers debug infinite skeleton loading states.

Solution

Add reasonAttributes to all usage sites of SearchRowSkeleton (src/components/Skeletons/SearchRowSkeleton.tsx).

At each usage site:

  1. Pass a reasonAttributes prop with a context string identifying the parent component (e.g. 'ParentComponent.ChildComponent')
  2. Include relevant boolean state variables that determine the loading state (e.g. isLoading, isDataReady)

Example

const reasonAttributes: SkeletonSpanReasonAttributes = {
    context: 'ParentComponent',
    isLoading,
    isDataReady,
};

<SearchRowSkeleton reasonAttributes={reasonAttributes} />

Reference

Scope

  • Component path: src/components/Skeletons/SearchRowSkeleton.tsx
  • Usage sites to update: ~3 files
Issue OwnerCurrent Issue Owner: @Krishna2323

Activity

  1. sosek108 commented on Feb 27, 2026

    @sosek108
    Contributor

    PR ready for review #83697

  2. Krishna2323 commented on Mar 2, 2026

    @Krishna2323
    Contributor

    @youssef-lr I'm reviewing the PR, could you please assign me here? Thanks!

  3. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Mar 6, 2026
  4. changed the title [-]Add reasonAttributes to SearchRowSkeleton usage sites[/-] [+][Due for payment 2026-03-13] Add reasonAttributes to SearchRowSkeleton usage sites[/+] on Mar 6, 2026
  5. melvin-bot commented on Mar 6, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  6. melvin-bot commented on Mar 6, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.31-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-03-13. 🎊

  7. melvin-bot commented on Mar 6, 2026

    @melvin-bot

    Triggered auto assignment to @bfitzexpensify (Awaiting Payment)

  8. 1 remaining item

  9. Krishna2323 commented on Mar 6, 2026

    @Krishna2323
    Contributor

    @youssef-lr please assign me here when you get a chance. I reviewed the PR. Thanks!

  10. Krishna2323 commented on Mar 12, 2026

    @Krishna2323
    Contributor

    @youssef-lr friendly bump 🙏🏻

  11. melvin-bot commented on Mar 13, 2026

    @melvin-bot

    Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

  12. changed the title [-][Due for payment 2026-03-13] Add reasonAttributes to SearchRowSkeleton usage sites[/-] [+][Due for payment 2026-03-13] [$75] Add reasonAttributes to SearchRowSkeleton usage sites[/+] on Mar 14, 2026
  13. melvin-bot commented on Mar 14, 2026

    @melvin-bot

    ⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

  14. mallenexpensify commented on Mar 16, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @Krishna2323 due $75 via NewDot

    Doesn't seem like we need a test case, comment/reopen if we do

  15. Krishna2323 commented on Apr 4, 2026

    @Krishna2323
    Contributor

    Requested in ND.

  16. twisterdotcom commented on Apr 5, 2026

    @twisterdotcom
    Contributor

    @Krishna2323 has submitted payment for this report on ND here.

    SO: https://stackoverflowteams.com/c/expensify/questions/7582

    Zapier Logs Run ID: 00040eee-7678-adc3-f362-b101d4690044
  17. quinthar commented on Apr 13, 2026

    @quinthar
    Contributor

    Approved $75 to @Krishna2323

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions