Skip to content

[Due for payment 2026-03-18] Add reasonAttributes to TableRowSkeleton usage sites #83409

Closed

Description

@MelvinBot

Problem

As part of #81683, we need to add reasonAttributes to all skeleton components so that Sentry spans carry structured metadata about why a loading indicator is visible. This helps engineers debug infinite skeleton loading states.

Solution

Add reasonAttributes to all usage sites of TableRowSkeleton (src/components/Skeletons/TableRowSkeleton.tsx).

At each usage site:

  1. Pass a reasonAttributes prop with a context string identifying the parent component (e.g. 'ParentComponent.ChildComponent')
  2. Include relevant boolean state variables that determine the loading state (e.g. isLoading, isDataReady)

Example

const reasonAttributes: SkeletonSpanReasonAttributes = {
    context: 'ParentComponent',
    isLoading,
    isDataReady,
};

<TableRowSkeleton reasonAttributes={reasonAttributes} />

Reference

Scope

  • Component path: src/components/Skeletons/TableRowSkeleton.tsx
  • Usage sites to update: ~8 files
Issue OwnerCurrent Issue Owner: @sosek108

Activity

  1. melvin-bot commented on Mar 6, 2026

    @melvin-bot

    @sosek108 Whoops! This issue is 2 days overdue. Let's get this updated quick!

  2. melvin-bot commented on Mar 9, 2026

    @melvin-bot

    @sosek108 Still overdue 6 days?! Let's take care of this!

  3. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Mar 11, 2026
  4. changed the title [-]Add reasonAttributes to TableRowSkeleton usage sites[/-] [+][Due for payment 2026-03-18] Add reasonAttributes to TableRowSkeleton usage sites[/+] on Mar 11, 2026
  5. melvin-bot commented on Mar 11, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.35-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-03-18. 🎊

    For reference, here are some details about the assignees on this issue:

    • @sosek108 does not require payment (Contractor)
  6. melvin-bot commented on Mar 11, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  7. youssef-lr commented on Mar 14, 2026

    @youssef-lr
    Contributor

    No payment needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions