You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$250] RHP reopens confirm page after changing member and clicking back button twice #83484
Version Number: 9.3.26-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack:#82683 Email or phone of affected tester (no customers):sdjsiodjsnodjsonjsio@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.2 / Chrome App Component: Workspace Settings
Action Performed:
Go to staging.new.expensify.com
Go to workspace settings > Members.
Click Invite member.
Enter email > select user > Next.
On confirm page, click Invite member.
Enter email > select user > Next.
Click RHP back button twice.
Expected Result:
RHP will close.
Actual Result:
RHP reopens confirm page after changing member on confirm page and clicking back button twice.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #82683 - "feat: [CFI] Add Approver row on the member invite confirmation page" by @TaduJR (High confidence) Related Issues: #81594 (similar navigation regression that PR #82683 attempted to fix)
Recommendation: REVERT
PR #82683 introduced a navigation bug in the member invite flow. The issue occurs when navigating back through the invite member flow after changing members on the confirmation page.
Labels: No label changes needed - this is correctly labeled as DeployBlockerCash since it is a Frontend bug that requires fixing/reverting an App PR.
Detailed Analysis
Evidence
In PR #82683, a change was made to line 271 of src/pages/workspace/members/WorkspaceInviteMessageComponent.tsx:
When the user clicks the "Members" row on the confirmation page, the code now calls Navigation.navigate() with Navigation.getActiveRoute() as the backTo parameter. This creates a circular navigation chain where:
User is on Confirm page (Route A)
User clicks Members row
Code navigates to Invite page with backTo = Route A (Confirm page)
User selects member and clicks Next, returns to Confirm page (Route A)
Navigation stack now has: Invite page -> Confirm page -> Invite page (with backTo pointing back to Confirm)
When user clicks back button twice, instead of closing the RHP, it navigates back to Confirm page again
The correct behavior (from the old code) was to use Navigation.goBack(backTo), which would properly traverse the navigation stack without creating circular references.
Verification
The PR modifies the exact file and component involved in the bug (WorkspaceInviteMessageComponent.tsx)
The changes add the Approver row feature to the member invite confirmation page
The reproduction steps directly match the functionality added in this PR
The bug is only reproducible on staging (9.3.26-0), not production, confirming it was introduced in this release
Please re-state the problem that we are trying to solve in this issue.
When a user is on the invite confirmation page (Confirm details) in the RHP and clicks the "Members" row to change the invited member, then selects a new member and clicks Next, pressing the RHP back button twice should close the RHP. Instead, the RHP reopens a stale copy of the confirmation page.
What is the root cause of that problem?
PR #82683 changed the "Members" row onPress handler on the confirmation page (WorkspaceInviteMessageComponent.tsx:271) from Navigation.goBack(backTo) to Navigation.navigate(ROUTES.WORKSPACE_INVITE.getRoute(policyID, Navigation.getActiveRoute())).
The old code popped back to the existing invite page on the navigation stack. The new code pushes a new invite page on top of the stack (because linkTo converts all NAVIGATE actions to PUSH). This creates duplicate entries:
This correctly pops back to the existing WORKSPACE_INVITE page on the stack rather than pushing a duplicate. The invite draft data is stored in Onyx (WORKSPACE_INVITE_MEMBERS_DRAFT), so the invite page will display the correct state when navigated back to.
What alternative solutions did you explore? (Optional)
An alternative would be to pass {forceReplace: true} to the navigate call so it replaces the current screen instead of pushing. However, goBack(backTo) is simpler, matches the original working behavior, and doesn't leave orphaned screens on the stack.
Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, or @MelvinBot <your feedback> to refine this analysis.
changed the title [-]RHP reopens confirm page after changing member and clicking back button twice[/-][+][$250] RHP reopens confirm page after changing member and clicking back button twice[/+]on Feb 25, 2026
📣 @keiru517! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>
🚨 Edited by proposal-police: This proposal was edited at 2026-02-26 00:08:30 UTC.
Proposal
The reason of this behavior is that the stack becomes something like:
Invite (A)
Confirm (B) <- backTo = A
Invite (A2) <- backTo = B
Confirm (B2) <- backTo = A2
If I click back button twice on B2 page, it goes to B page which is Confirm (B).
Solution
Option 1. Remove duplicated records to the stack.
Option 2. Need to use Navigation.popToTop() instead of using Navigation.goBack(backTo)
Option 3. Whichever navigation call transitions to Confirm should use the wrapper's replace option like this. Navigation.navigate(ROUTE.WORKSPACE_INVITE_MESSAGE_CONFIRM.getRoute(policyId, ...), {forceReplace: true})
Activity
melvin-bot commentedon Feb 25, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #82683
melvin-bot commentedon Feb 25, 2026
💬 A slack conversation has been started in #expensify-open-source
melvin-bot commentedon Feb 25, 2026
Triggered auto assignment to @NicMendonca (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.github-actions commentedon Feb 25, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon Feb 25, 2026
Investigation Summary
Classification: Frontend bug
Causing PR: #82683 - "feat: [CFI] Add Approver row on the member invite confirmation page" by @TaduJR (High confidence)
Related Issues: #81594 (similar navigation regression that PR #82683 attempted to fix)
Recommendation: REVERT
PR #82683 introduced a navigation bug in the member invite flow. The issue occurs when navigating back through the invite member flow after changing members on the confirmation page.
Labels: No label changes needed - this is correctly labeled as
DeployBlockerCashsince it is a Frontend bug that requires fixing/reverting an App PR.Detailed Analysis
Evidence
In PR #82683, a change was made to line 271 of
src/pages/workspace/members/WorkspaceInviteMessageComponent.tsx:Before (correct):
After (buggy):
Root Cause
When the user clicks the "Members" row on the confirmation page, the code now calls
Navigation.navigate()withNavigation.getActiveRoute()as thebackToparameter. This creates a circular navigation chain where:The correct behavior (from the old code) was to use
Navigation.goBack(backTo), which would properly traverse the navigation stack without creating circular references.Verification
WorkspaceInviteMessageComponent.tsx)MelvinBot commentedon Feb 25, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
When a user is on the invite confirmation page (Confirm details) in the RHP and clicks the "Members" row to change the invited member, then selects a new member and clicks Next, pressing the RHP back button twice should close the RHP. Instead, the RHP reopens a stale copy of the confirmation page.
What is the root cause of that problem?
PR #82683 changed the "Members" row
onPresshandler on the confirmation page (WorkspaceInviteMessageComponent.tsx:271) fromNavigation.goBack(backTo)toNavigation.navigate(ROUTES.WORKSPACE_INVITE.getRoute(policyID, Navigation.getActiveRoute())).The old code popped back to the existing invite page on the navigation stack. The new code pushes a new invite page on top of the stack (because
linkToconverts all NAVIGATE actions to PUSH). This creates duplicate entries:[INVITE][INVITE, INVITE_MESSAGE][INVITE, INVITE_MESSAGE, INVITE]← duplicate pushed[INVITE, INVITE_MESSAGE, INVITE, INVITE_MESSAGE]← duplicate pushed[INVITE, INVITE_MESSAGE, INVITE][INVITE, INVITE_MESSAGE]← stale confirm page shown instead of closingHere is the specific diff from PR #82683 that introduced the regression (
WorkspaceInviteMessageComponent.tsx:271):What changes do you think we should make in order to solve the problem?
Revert the "Members" row
onPresshandler back toNavigation.goBack(backTo)atsrc/pages/workspace/members/WorkspaceInviteMessageComponent.tsx:271.This correctly pops back to the existing
WORKSPACE_INVITEpage on the stack rather than pushing a duplicate. The invite draft data is stored in Onyx (WORKSPACE_INVITE_MEMBERS_DRAFT), so the invite page will display the correct state when navigated back to.What alternative solutions did you explore? (Optional)
An alternative would be to pass
{forceReplace: true}to the navigate call so it replaces the current screen instead of pushing. However,goBack(backTo)is simpler, matches the original working behavior, and doesn't leave orphaned screens on the stack.Next Steps for Contributor+ team: Reply with
@MelvinBot implement thisto create a draft PR, or@MelvinBot <your feedback>to refine this analysis.3 remaining items
melvin-bot commentedon Feb 25, 2026
Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (
External)melvin-bot commentedon Feb 25, 2026
Job added to Upwork: https://www.upwork.com/jobs/~022026753858625901997
[-]RHP reopens confirm page after changing member and clicking back button twice[/-][+][$250] RHP reopens confirm page after changing member and clicking back button twice[/+]melvin-bot commentedon Feb 25, 2026
📣 @keiru517! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Format:
keiru517 commentedon Feb 25, 2026
🚨 Edited by proposal-police: This proposal was edited at 2026-02-26 00:08:30 UTC.
Proposal
The reason of this behavior is that the stack becomes something like:
If I click back button twice on B2 page, it goes to B page which is
Confirm (B).Solution
Option 1. Remove duplicated records to the stack.
Option 2. Need to use
Navigation.popToTop()instead of usingNavigation.goBack(backTo)Option 3. Whichever navigation call transitions to Confirm should use the wrapper's replace option like this.
Navigation.navigate(ROUTE.WORKSPACE_INVITE_MESSAGE_CONFIRM.getRoute(policyId, ...), {forceReplace: true})Contributor details
Your Expensify account email: ihorusach@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01970f49248499b215?mp_source=share
melvin-bot commentedon Feb 25, 2026
✅ Contributor details stored successfully. Thank you for contributing to Expensify!
inimaga commentedon Feb 26, 2026
Asked for a retest here.
IuliiaHerets commentedon Feb 26, 2026
@inimaga Chrome / v9.3.26-4
The issue is not reproducible anymore
Screen.Recording.2026-02-26.at.13.04.36.mp4
inimaga commentedon Feb 26, 2026
Thanks for confirming. Closing.