Skip to content

[Due for payment 2026-04-28] [Due for payment 2026-03-30] [$250] Android & iOS - Group chat - App returns to group chat after tapping Select on member #83727

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.27-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #82587
Email or phone of affected tester (no customers): sjdsoijsoidjsndoinjsdoi@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Samsung Galaxy S25 FE / Android 16
App Component: Chat Report View

Action Performed:

  1. Launch Expensify app.
  2. Tap FAB > Start chat.
  3. Tap Add to group on any user.
  4. Create a group chat.
  5. Open group chat header > Members.
  6. Long press on the member > Select.

Expected Result:

Member will be selected.

Actual Result:

App returns to group chat after tapping Select on member.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Bug7090184_1772207187227.Screen_Recording_20260227_234426_Expensify.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @linhvovan29546
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~022027423992362619226
  • Upwork Job ID: 2027423992362619226
  • Last Price Increase: 2026-02-27

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Feb 27, 2026
  2. melvin-bot commented on Feb 27, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #82587

  3. melvin-bot commented on Feb 27, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  4. melvin-bot commented on Feb 27, 2026

    @melvin-bot

    Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. github-actions commented on Feb 27, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. OSBotify commented on Feb 27, 2026

    @OSBotify
    Contributor

    Investigation Summary

    Classification: Frontend bug
    Causing PR: #82587 - "Migration navigation from InteractionManager to TransitionTracker" by @blazejkustra (High confidence)
    Related Issues: None

    Recommendation: REVERT

    PR #82587 introduced the TransitionTracker system that changed how modal transitions and navigation work. The PR modified modal dismissal behavior to use afterTransition callbacks and transition tracking, which appears to be interfering with the member selection flow in group chats.

    Labels: This issue has both DeployBlockerCash and DeployBlocker labels. Since this is a frontend bug (App PR causing the issue), I am removing the DeployBlocker label and keeping the DeployBlockerCash label.

    Detailed Analysis

    Evidence

    Verification

    The bug affects the member selection flow in group chats:

    1. User opens group chat header > Members (opens RoomMembersPage modal/RHP)
    2. User long-presses on a member to enter selection mode
    3. User taps "Select" to confirm selection mode activation
    4. Expected: Member should be selected and selection mode should remain active
    5. Actual: App dismisses the modal and returns to the group chat

    Root Cause

    PR #82587 introduced the TransitionTracker module which explicitly tracks navigation, modal, keyboard, and focus transitions. The PR modified:

    1. Navigation.dismissModal to use TransitionTracker.runAfterTransitions with afterTransition callbacks
    2. Modal lifecycle in ReanimatedModal and navigation components to call TransitionTracker.startTransition/endTransition
    3. Timing of navigation actions to wait for transitions to complete before executing

    The bug likely occurs because:

    • When the user taps "Select" after long-pressing a member, something in the transition tracking system is prematurely triggering a modal dismissal or navigation action
    • The afterTransition callback mechanism may be conflicting with the selection mode activation in SelectionListWithModal
    • The timing changes introduced by TransitionTracker are causing the onTurnOnSelectionMode callback in RoomMembersPage (line 467) to trigger a navigation action instead of just toggling selection state

    The issue is specific to the member selection flow, which involves:

    • RoomMembersPage.tsx with SelectionListWithModal component
    • Long-press to activate selection mode (turnOnSelectionModeOnLongPress)
    • onTurnOnSelectionMode callback that should toggle the user selection
  7. 17 remaining items

  8. changed the title [-][$250] Android & iOS - Group chat - App returns to group chat after tapping Select on member[/-] [+][Due for payment 2026-03-30] [$250] Android & iOS - Group chat - App returns to group chat after tapping Select on member[/+] on Mar 23, 2026
  9. melvin-bot commented on Mar 23, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  10. melvin-bot commented on Mar 23, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.41-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-03-30. 🎊

    For reference, here are some details about the assignees on this issue:

  11. melvin-bot commented on Mar 23, 2026

    @melvin-bot

    @linhvovan29546 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  12. melvin-bot commented on Mar 23, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  13. mallenexpensify commented on Mar 30, 2026

    @mallenexpensify
    Contributor
  14. changed the title [-][Due for payment 2026-03-30] [$250] Android & iOS - Group chat - App returns to group chat after tapping Select on member[/-] [+][Due for payment 2026-04-28] [Due for payment 2026-03-30] [$250] Android & iOS - Group chat - App returns to group chat after tapping Select on member[/+] on Apr 21, 2026
  15. melvin-bot commented on Apr 21, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.60-22 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-04-28. 🎊

    For reference, here are some details about the assignees on this issue:

  16. melvin-bot commented on Apr 21, 2026

    @melvin-bot

    @linhvovan29546 @mallenexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions