Skip to content

[Due for payment 2026-06-17] [Due for payment 2026-06-10] [$250] QBO - Selected vendor bill is missing when import locations is enabled #83788

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.27-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #83416
Email or phone of affected tester (no customers): applausetester+270204abc@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.2 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

  • Workspace is connected to QBO.
  1. Go to staging.new.expensify.com
  2. Go to workspace settings > Accounting.
  3. Click Export > Export out-of-pocket expenses as > Export as > Journal entry.
  4. Click RHP back button.
  5. Click Export company card expenses as > Export as > Vendor bill.
  6. Close the RHP.
  7. Click Import.
  8. Click Locations.
  9. Enable Import.
  10. Close the RHP.
  11. Click Export > Export company card expenses as > Export as.

Expected Result:

Vendor bill should be present in the list as it is selected.

Actual Result:

Vendor bill is missing in Export company card expenses when Vendor bill is selected and import locations is enabled.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~022044010527197082814
  • Upwork Job ID: 2044010527197082814
  • Last Price Increase: 2026-04-21
Issue OwnerCurrent Issue Owner: @dmkt9

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    and removed on Apr 14, 2026
  2. MelvinBot commented on Apr 14, 2026

    @MelvinBot
    Contributor

    Proposal

    What is the root cause of that problem?

    When the user enables "Import Locations" on QuickbooksLocationsPage.tsx, the toggle handler calls updateQuickbooksOnlineSyncLocations, which only updates the syncLocations config key. It does not check or reset nonReimbursableExpensesExportDestination.

    Meanwhile, QuickbooksCompanyCardExpenseAccountSelectCardPage.tsx:59 hides the Vendor Bill option from the picker when locations are enabled (because QBO doesn't support locations on vendor bill exports). This creates a stale state: the config still says VENDOR_BILL, but the UI no longer shows it as a selectable option.

    The incompatibility is already known — utils.ts:4-9 (canImportLocationsAsTags) explicitly checks that the non-reimbursable export destination is credit card or debit card (not vendor bill) to determine if locations can be imported as tags. But nothing acts on this check when toggling locations on.

    What changes do you think we should make in order to solve the problem?

    In QuickbooksLocationsPage.tsx, when the user enables locations and the current nonReimbursableExpensesExportDestination is VENDOR_BILL, automatically reset it to CREDIT_CARD (the first valid option). This should use updateManyPolicyConnectionConfigs to update both syncLocations and nonReimbursableExpensesExportDestination atomically, along with the related account fields (nonReimbursableExpensesAccount and nonReimbursableBillDefaultVendor).

    The updateQuickbooksOnlineSyncLocations callback should check qboConfig?.nonReimbursableExpensesExportDestination === CONST.QUICKBOOKS_NON_REIMBURSABLE_EXPORT_ACCOUNT_TYPE.VENDOR_BILL before dispatching the update, and if true, bundle the export destination reset into the same API call.

    What alternative solutions did you explore? (Optional)

    An alternative would be to reset the export destination reactively — e.g., adding a useEffect in QuickbooksCompanyCardExpenseAccountSelectCardPage that detects the incompatible state and auto-corrects. However, this is worse because the stale config would persist until the user navigates to the export page, and the backend could attempt to use the invalid VENDOR_BILL setting during a sync in the meantime.


    Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.

  3. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Apr 14, 2026
  4. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Apr 14, 2026
  5. melvin-bot commented on Apr 14, 2026

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @dmkt9 (External)

  6. changed the title [-]QBO - Selected vendor bill is missing when import locations is enabled[/-] [+][$250] QBO - Selected vendor bill is missing when import locations is enabled[/+] on Apr 14, 2026
  7. melvin-bot commented on Apr 14, 2026

    @melvin-bot
  8. 83 remaining items

  9. mallenexpensify commented on Jun 11, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor: @yichensunjoe paid $250 via Upwork
    Contributor+: @dmkt9 paid $250 via Upwork

    @yichensunjoe can you please accept the job below? Please reply here and tag me once you have.
    If you're not sent an offer in Upwork when you're assigned to an issue, please tag me. If an Upwork job exists, please submit a proposal.
    https://www.upwork.com/jobs/~022065199651067808422

    ^ Test case created. Thx

  10. yichensunjoe commented on Jun 12, 2026

    @yichensunjoe
    Contributor

    @mallenexpensify I've accepted the Upwork job and submitted the work for payment. Thank you!

  11. dmkt9 commented on Jun 12, 2026

    @dmkt9
    Contributor

    Contributor+: @dmkt9 due $250 via NewDot

    @mallenexpensify I am still receiving payment through Upwork. Thank you.

  12. yichensunjoe commented on Jun 18, 2026

    @yichensunjoe
    Contributor

    Hi @mallenexpensify, just following up on the $250 Upwork payment for this issue, as the payment date was June 17. The milestone is still showing as “Payment requested” and has not been released yet. Could you please take a look when you have a chance? Thank you!

  13. melvin-bot commented on Jun 18, 2026

    @melvin-bot

    @dmkt9 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  14. mallenexpensify commented on Jun 18, 2026

    @mallenexpensify
    Contributor

    @yichensunjoe paid, summary updated above. Thx.

    @dmkt9 can you please accept the job below? Please reply here and tag me once you have.
    If you're not sent an offer in Upwork when you're assigned to an issue, please tag me. If an Upwork job exists, please submit a proposal.
    https://www.upwork.com/jobs/~022065199651067808422

  15. dmkt9 commented on Jun 19, 2026

    @dmkt9
    Contributor

    @dmkt9 can you please accept the job below? Please reply here and tag me once you have.

    @mallenexpensify Thanks. I've accepted the offer

  16. mallenexpensify commented on Jun 19, 2026

    @mallenexpensify
    Contributor

    @dmkt9 paid, summary updated above. Thx. :meowsweat:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2EngineeringImprovementItem broken or needs improvement.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions