You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-06-17] [Due for payment 2026-06-10] [$250] QBO - Selected vendor bill is missing when import locations is enabled #83788
Version Number: 9.3.27-2 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from BrowserStack:#83416 Email or phone of affected tester (no customers):applausetester+270204abc@applause.expensifail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.2 / Chrome App Component: Workspace Settings
Action Performed:
Precondition:
Workspace is connected to QBO.
Go to staging.new.expensify.com
Go to workspace settings > Accounting.
Click Export > Export out-of-pocket expenses as > Export as > Journal entry.
Click RHP back button.
Click Export company card expenses as > Export as > Vendor bill.
Close the RHP.
Click Import.
Click Locations.
Enable Import.
Close the RHP.
Click Export > Export company card expenses as > Export as.
Expected Result:
Vendor bill should be present in the list as it is selected.
Actual Result:
Vendor bill is missing in Export company card expenses when Vendor bill is selected and import locations is enabled.
When the user enables "Import Locations" on QuickbooksLocationsPage.tsx, the toggle handler calls updateQuickbooksOnlineSyncLocations, which only updates the syncLocations config key. It does not check or reset nonReimbursableExpensesExportDestination.
Meanwhile, QuickbooksCompanyCardExpenseAccountSelectCardPage.tsx:59 hides the Vendor Bill option from the picker when locations are enabled (because QBO doesn't support locations on vendor bill exports). This creates a stale state: the config still says VENDOR_BILL, but the UI no longer shows it as a selectable option.
The incompatibility is already known — utils.ts:4-9 (canImportLocationsAsTags) explicitly checks that the non-reimbursable export destination is credit card or debit card (not vendor bill) to determine if locations can be imported as tags. But nothing acts on this check when toggling locations on.
What changes do you think we should make in order to solve the problem?
In QuickbooksLocationsPage.tsx, when the user enables locations and the current nonReimbursableExpensesExportDestination is VENDOR_BILL, automatically reset it to CREDIT_CARD (the first valid option). This should use updateManyPolicyConnectionConfigs to update both syncLocations and nonReimbursableExpensesExportDestination atomically, along with the related account fields (nonReimbursableExpensesAccount and nonReimbursableBillDefaultVendor).
The updateQuickbooksOnlineSyncLocations callback should check qboConfig?.nonReimbursableExpensesExportDestination === CONST.QUICKBOOKS_NON_REIMBURSABLE_EXPORT_ACCOUNT_TYPE.VENDOR_BILL before dispatching the update, and if true, bundle the export destination reset into the same API call.
What alternative solutions did you explore? (Optional)
An alternative would be to reset the export destination reactively — e.g., adding a useEffect in QuickbooksCompanyCardExpenseAccountSelectCardPage that detects the incompatible state and auto-corrects. However, this is worse because the stale config would persist until the user navigates to the export page, and the backend could attempt to use the invalid VENDOR_BILL setting during a sync in the meantime.
Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.
changed the title [-]QBO - Selected vendor bill is missing when import locations is enabled[/-][+][$250] QBO - Selected vendor bill is missing when import locations is enabled[/+]on Apr 14, 2026
Contributor: @yichensunjoe paid $250 via Upwork
Contributor+: @dmkt9 paid $250 via Upwork
@yichensunjoe can you please accept the job below? Please reply here and tag me once you have.
If you're not sent an offer in Upwork when you're assigned to an issue, please tag me. If an Upwork job exists, please submit a proposal. https://www.upwork.com/jobs/~022065199651067808422
Hi @mallenexpensify, just following up on the $250 Upwork payment for this issue, as the payment date was June 17. The milestone is still showing as “Payment requested” and has not been released yet. Could you please take a look when you have a chance? Thank you!
@dmkt9 can you please accept the job below? Please reply here and tag me once you have.
If you're not sent an offer in Upwork when you're assigned to an issue, please tag me. If an Upwork job exists, please submit a proposal. https://www.upwork.com/jobs/~022065199651067808422
Activity
MelvinBot commentedon Apr 14, 2026
Proposal
What is the root cause of that problem?
When the user enables "Import Locations" on
QuickbooksLocationsPage.tsx, the toggle handler callsupdateQuickbooksOnlineSyncLocations, which only updates thesyncLocationsconfig key. It does not check or resetnonReimbursableExpensesExportDestination.Meanwhile,
QuickbooksCompanyCardExpenseAccountSelectCardPage.tsx:59hides the Vendor Bill option from the picker when locations are enabled (because QBO doesn't support locations on vendor bill exports). This creates a stale state: the config still saysVENDOR_BILL, but the UI no longer shows it as a selectable option.The incompatibility is already known —
utils.ts:4-9(canImportLocationsAsTags) explicitly checks that the non-reimbursable export destination is credit card or debit card (not vendor bill) to determine if locations can be imported as tags. But nothing acts on this check when toggling locations on.What changes do you think we should make in order to solve the problem?
In
QuickbooksLocationsPage.tsx, when the user enables locations and the currentnonReimbursableExpensesExportDestinationisVENDOR_BILL, automatically reset it toCREDIT_CARD(the first valid option). This should useupdateManyPolicyConnectionConfigsto update bothsyncLocationsandnonReimbursableExpensesExportDestinationatomically, along with the related account fields (nonReimbursableExpensesAccountandnonReimbursableBillDefaultVendor).The
updateQuickbooksOnlineSyncLocationscallback should checkqboConfig?.nonReimbursableExpensesExportDestination === CONST.QUICKBOOKS_NON_REIMBURSABLE_EXPORT_ACCOUNT_TYPE.VENDOR_BILLbefore dispatching the update, and if true, bundle the export destination reset into the same API call.What alternative solutions did you explore? (Optional)
An alternative would be to reset the export destination reactively — e.g., adding a
useEffectinQuickbooksCompanyCardExpenseAccountSelectCardPagethat detects the incompatible state and auto-corrects. However, this is worse because the stale config would persist until the user navigates to the export page, and the backend could attempt to use the invalid VENDOR_BILL setting during a sync in the meantime.Next Steps for Contributor+ team: Reply with
@MelvinBot implement thisto create a draft PR,@MelvinBot <your feedback>to refine this analysis, or explain why you are rejecting Melvin's proposal.melvin-bot commentedon Apr 14, 2026
Triggered auto assignment to Contributor-plus team member for initial proposal review - @dmkt9 (
External)[-]QBO - Selected vendor bill is missing when import locations is enabled[/-][+][$250] QBO - Selected vendor bill is missing when import locations is enabled[/+]melvin-bot commentedon Apr 14, 2026
Job added to Upwork: https://www.upwork.com/jobs/~022044010527197082814
83 remaining items
mallenexpensify commentedon Jun 11, 2026
Payment Summary
Contributor: @yichensunjoe paid $250 via Upwork
Contributor+: @dmkt9 paid $250 via Upwork
@yichensunjoe can you please accept the job below? Please reply here and tag me once you have.
If you're not sent an offer in Upwork when you're assigned to an issue, please tag me. If an Upwork job exists, please submit a proposal.
https://www.upwork.com/jobs/~022065199651067808422
^ Test case created. Thx
yichensunjoe commentedon Jun 12, 2026
@mallenexpensify I've accepted the Upwork job and submitted the work for payment. Thank you!
dmkt9 commentedon Jun 12, 2026
@mallenexpensify I am still receiving payment through Upwork. Thank you.
yichensunjoe commentedon Jun 18, 2026
Hi @mallenexpensify, just following up on the $250 Upwork payment for this issue, as the payment date was June 17. The milestone is still showing as “Payment requested” and has not been released yet. Could you please take a look when you have a chance? Thank you!
melvin-bot commentedon Jun 18, 2026
@dmkt9 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
mallenexpensify commentedon Jun 18, 2026
@yichensunjoe paid, summary updated above. Thx.
@dmkt9 can you please accept the job below? Please reply here and tag me once you have.
If you're not sent an offer in Upwork when you're assigned to an issue, please tag me. If an Upwork job exists, please submit a proposal.
https://www.upwork.com/jobs/~022065199651067808422
dmkt9 commentedon Jun 19, 2026
@mallenexpensify Thanks. I've accepted the offer
mallenexpensify commentedon Jun 19, 2026
@dmkt9 paid, summary updated above. Thx. :meowsweat: