Skip to content

[BT-141] Migrate Workspace - Company Cards #83863

Closed

Description

@mjasikowski

Description

Current State:

  • 5 routes for workspace company card management
  • These routes use backTo parameter for return navigation

Implementation:

  • Replace getRoute(..., backTo) with createDynamicRoute()
  • Add source screens to entryScreens array
  • Remove backTo parameter from route definitions
  • Test forward/back navigation

Scope

Routes (5):

Route Constant Path
WORKSPACE_COMPANY_CARD_DETAILS workspaces/:policyID/company-cards/:feed/:cardID
WORKSPACE_COMPANY_CARD_EXPORT workspaces/:policyID/company-cards/:feed/:cardID/edit/export
WORKSPACE_COMPANY_CARDS_ASSIGN_CARD_ASSIGNEE workspaces/:policyID/company-cards/:feed/assign-card/:cardID/assignee
WORKSPACE_COMPANY_CARDS_ASSIGN_CARD_CONFIRMATION workspaces/:policyID/company-cards/:feed/assign-card/:cardID/confirmation
WORKSPACE_COMPANY_CARDS_BANK_CONNECTION workspaces/:policyID/company-cards/:feed/bank-connection

Usages

WORKSPACE_COMPANY_CARD_DETAILS:

  • src/pages/workspace/companyCards/WorkspaceCompanyCardsTable/WorkspaceCompanyCardsTableItem.tsx:155
  • src/pages/workspace/companyCards/WorkspaceCompanyCardEditTransactionStartDatePage.tsx:83,112
  • src/pages/workspace/companyCards/WorkspaceCompanyCardAccountSelectCardPage.tsx:82,117

WORKSPACE_COMPANY_CARD_EXPORT:

  • Search for usages in company card export flow

WORKSPACE_COMPANY_CARDS_ASSIGN_CARD_ASSIGNEE:

  • Search for usages in card assign assignee flow

WORKSPACE_COMPANY_CARDS_ASSIGN_CARD_CONFIRMATION:

  • Search for usages in card assign confirmation flow

WORKSPACE_COMPANY_CARDS_BANK_CONNECTION:

  • Search for usages in bank connection flow

Files to modify:

  • src/ROUTES.ts - Update route definitions
  • src/libs/Navigation/types.ts - Remove backTo from params
  • Components listed above

Migration Progress

  • WORKSPACE_COMPANY_CARD_DETAILS
  • WORKSPACE_COMPANY_CARD_EXPORT
  • WORKSPACE_COMPANY_CARDS_ASSIGN_CARD_ASSIGNEE
  • WORKSPACE_COMPANY_CARDS_ASSIGN_CARD_CONFIRMATION
  • WORKSPACE_COMPANY_CARDS_BANK_CONNECTION
Issue OwnerCurrent Issue Owner: @suneox

Activity

  1. added
    InternalRequires API changes or must be handled by Expensify staff
    on Mar 2, 2026
  2. melvin-bot commented on Jun 8, 2026

    @melvin-bot

    This issue has not been updated in over 15 days. @mananjadhav, @mjasikowski, @huult eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

  3. 11 remaining items

  4. melvin-bot commented on Jul 6, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  5. huult commented on Jul 6, 2026

    @huult
    Contributor

    I believe it’s related to updating the old routes as part of the migration task. I’m checking.

  6. jponikarchuk commented on Jul 6, 2026

    @jponikarchuk

    Deploy Blocker #95361 was identified to be related to the PR #94280 that attempted to fix this issue.

  7. melvin-bot commented on Jul 6, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  8. changed the title [-][BT-141] Migrate Workspace - Company Cards[/-] [+][Due for payment 2026-07-13] [BT-141] Migrate Workspace - Company Cards[/+] on Jul 6, 2026
  9. melvin-bot commented on Jul 6, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  10. melvin-bot commented on Jul 6, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.27-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-07-13. 🎊

    For reference, here are some details about the assignees on this issue:

    • @suneox requires payment through NewDot Manual Requests
    • @huult requires payment through NewDot Manual Requests
  11. changed the title [-][Due for payment 2026-07-13] [BT-141] Migrate Workspace - Company Cards[/-] [+][BT-141] Migrate Workspace - Company Cards[/+] on Jul 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

DailyKSv2InternalRequires API changes or must be handled by Expensify staffSkip PaymentSkips all the payment process steps for an issue. Use it for fixed-price projects.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions