Skip to content

[BT-146] Migrate Transaction Duplicate (Part 1) #83868

Closed

Description

@mjasikowski

Description

Current State:

  • 5 routes for transaction duplicate review
  • These routes use backTo parameter for return navigation

Implementation:

  • Replace getRoute(..., backTo) with createDynamicRoute()
  • Add source screens to entryScreens array
  • Remove backTo parameter from route definitions
  • Test forward/back navigation

Scope

Routes (5):

Route Constant Path
TRANSACTION_DUPLICATE_REVIEW_PAGE r/:threadReportID/duplicates/review
TRANSACTION_DUPLICATE_REVIEW_MERCHANT_PAGE r/:threadReportID/duplicates/review/merchant
TRANSACTION_DUPLICATE_REVIEW_CATEGORY_PAGE r/:threadReportID/duplicates/review/category
TRANSACTION_DUPLICATE_REVIEW_TAG_PAGE r/:threadReportID/duplicates/review/tag
TRANSACTION_DUPLICATE_REVIEW_TAX_CODE_PAGE r/:threadReportID/duplicates/review/tax-code

Usages

TRANSACTION_DUPLICATE_REVIEW_PAGE:

  • src/components/MoneyRequestHeader.tsx:291
  • src/components/MoneyReportHeader.tsx:1062
  • src/hooks/useReviewDuplicatesNavigation.tsx:56

TRANSACTION_DUPLICATE_REVIEW_MERCHANT_PAGE:

  • Search for usages in duplicate merchant review flow

TRANSACTION_DUPLICATE_REVIEW_CATEGORY_PAGE:

  • Search for usages in duplicate category review flow

TRANSACTION_DUPLICATE_REVIEW_TAG_PAGE:

  • Search for usages in duplicate tag review flow

TRANSACTION_DUPLICATE_REVIEW_TAX_CODE_PAGE:

  • Search for usages in duplicate tax code review flow

Files to modify:

  • src/ROUTES.ts - Update route definitions
  • src/libs/Navigation/types.ts - Remove backTo from params
  • Components listed above

Migration Progress

  • TRANSACTION_DUPLICATE_REVIEW_PAGE
  • TRANSACTION_DUPLICATE_REVIEW_MERCHANT_PAGE
  • TRANSACTION_DUPLICATE_REVIEW_CATEGORY_PAGE
  • TRANSACTION_DUPLICATE_REVIEW_TAG_PAGE
  • TRANSACTION_DUPLICATE_REVIEW_TAX_CODE_PAGE
Issue OwnerCurrent Issue Owner: @suneox

Activity

  1. added
    InternalRequires API changes or must be handled by Expensify staff
    on Mar 2, 2026
  2. mananjadhav commented on May 10, 2026

    @mananjadhav
    Collaborator

    @mjasikowski @huult I ended up migrating TRANSACTION_DUPLICATE_REVIEW_TAX_CODE_PAGE in this issue #83869. Can we remove it from here?

    Also if @huult doesn't mind may be I can pick the implementation for this one as I've already done for the other pages in the flow.

  3. huult commented on May 11, 2026

    @huult
    Contributor

    Sounds good to me. Feel free to pick this one as well 👍

  4. mananjadhav commented on May 13, 2026

    @mananjadhav
    Collaborator

    PR is common for both the issues. @mjasikowski

    I found it easier to migrate all routes at once to try and avoid backTo dependency.

  5. added
    ReviewingHas a PR in review
    and removed on May 13, 2026
  6. 11 remaining items

  7. melvin-bot commented on Jul 31, 2026

    @melvin-bot

    @suneox / @huult

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.46-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-08-07. 🎊

    The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

  8. melvin-bot commented on Aug 3, 2026

    @melvin-bot

    @suneox Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  9. melvin-bot commented on Aug 5, 2026

    @melvin-bot

    @suneox Eep! 4 days overdue now. Issues have feelings too...

  10. melvin-bot commented on Aug 7, 2026

    @melvin-bot

    @suneox Still overdue 6 days?! Let's take care of this!

  11. huult commented on Aug 10, 2026

    @huult
    Contributor

    @mjasikowski #96738 (comment) we can close this ticket

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

DailyKSv2InternalRequires API changes or must be handled by Expensify staffSkip PaymentSkips all the payment process steps for an issue. Use it for fixed-price projects.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions