Skip to content

[Due for payment 2026-03-19] [$250] Log in page - User can’t select the footer via Tab key on Safari #83874

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.27-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @daledah
Slack conversation (hyperlinked to channel name): #expensify_open_source

Action Performed:

  1. Open the app on Safari
  2. In Login page, try to select the footer via Tab key

Expected Result:

On safari, we can select the footer via Tab key

Actual Result:

On safari, we can’t select the footer via Tab key

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Safari

Screenshots/Videos

web-resize.mp4
Image
Screen.Recording.2026-03-01.at.16.34.33.1.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @mallenexpensify
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~022028422103332434766
  • Upwork Job ID: 2028422103332434766
  • Last Price Increase: 2026-03-02
  • Automatic offers:
    • aimane-chnaif | Reviewer | 110664233

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 2, 2026
  2. melvin-bot commented on Mar 2, 2026

    @melvin-bot

    Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. MelvinBot commented on Mar 2, 2026

    @MelvinBot
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    On Safari (macOS), pressing the Tab key on the login page does not cycle focus to the footer links (Features, Resources, Learn More, Get Started columns, social icons, or license links). Other browsers like Chrome and Firefox allow Tab to reach these elements.

    What is the root cause of that problem?

    The root cause is Safari's default keyboard navigation behavior combined with how the footer elements are rendered.

    Safari's Tab key restriction: Unlike Chrome and Firefox, Safari on macOS only cycles Tab focus through form controls (<input>, <select>, <textarea>, <button>) by default. It skips <a> elements and any <div tabindex="0"> elements. This is a deliberate Safari/WebKit design choice. Users can opt in to full Tab navigation via macOS System Preferences > Keyboard > "Keyboard navigation" (Ventura+) or Safari Settings > Advanced > Accessibility > "Press Tab to highlight each item on a webpage", but this is OFF by default.

    How footer links render on web:

    1. External links (most footer items with href like Expense Management, Invoicing, etc.) — TextLink passes href to React Native Web's Text component, which renders an <a href="..."> tag (src/components/TextLink.tsx:65-81 → RNW Text/index.js:158). Safari skips <a> tags during Tab navigation by default.

    2. Action links ("Create Account", "Log In" with only onPress, no href) — TextLink renders as <div role="link" tabindex="0"> because RNW's Text component only switches to <a> when href is provided (src/pages/signin/SignInPageLayout/Footer.tsx:186-205). Safari also skips <div tabindex="0"> during Tab navigation by default.

    3. Social icons — PressableWithoutFeedback with href renders as <a> tags via RNW's View (src/pages/signin/Socials.tsx:58-80). Same Safari Tab limitation applies.

    What changes do you think we should make in order to solve the problem?

    Option A (Recommended): Modify the TextLink component (or specifically the footer's usage of it) to render as a <button> element on web instead of <a> or <div>. Safari does include <button> elements in its default Tab order. The TextLink could accept a prop like renderAsButton or the component could automatically detect when no href is provided and render as a semantically appropriate <button> styled as a link.

    For the onPress-only links ("Create Account", "Log In"), this means changing the underlying element from <div role="link" tabindex="0"> to <button> styled as a link.

    For the href-based links (external URLs), the approach would be to render them as <a href="..."> (as they currently are) since those are the semantically correct element — and accept that Safari's default Tab behavior skips <a> tags unless the user enables keyboard navigation at the OS level.

    Alternatively (Option B): Add role="button" to the footer link elements. In React Native Web, role="button" maps to a native <button> element via the propsToAccessibilityComponent function (unlike role="link" which has no native element mapping). This would make them tabbable in Safari by default, though it changes the semantic role from "link" to "button".

    What alternative solutions did you explore? (Optional)

    • Adding tabIndex={0} explicitly — Already present (set automatically by RNW's createDOMProps for role="link" elements at node_modules/react-native-web/src/modules/createDOMProps/index.js:862-873), but Safari ignores tabindex="0" on non-form elements under default Tab settings.
    • Using focusable={true} — Same effect as tabIndex={0}, does not change Safari's Tab behavior.
    • Documenting as a Safari limitation — Not recommended, as this impacts keyboard-only users on Safari who may not know about the system preference.

    Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, or @MelvinBot <your feedback> to refine this analysis.

  4. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Mar 2, 2026
  5. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Mar 2, 2026
  6. melvin-bot commented on Mar 2, 2026

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

  7. changed the title [-]Log in page - User can’t select the footer via Tab key on Safari[/-] [+][$250] Log in page - User can’t select the footer via Tab key on Safari[/+] on Mar 2, 2026
  8. melvin-bot commented on Mar 2, 2026

    @melvin-bot
  9. workmshaheen commented on Mar 2, 2026

    @workmshaheen

    Proposal
    Please re-state the problem that we are trying to solve in this issue.

    On Safari macOS, pressing Tab on the login page skips all footer links. Users cannot reach "Create Account," "Log In," or any external footer links via keyboard navigation. This works correctly in Chrome and Firefox.

    What is the root cause of that problem?

    Safari's default Tab behavior only cycles through form controls: button, input, select, textarea. It skips anchor tags and divs with tabindex="0" unless the user has enabled "Press Tab to highlight each item on a webpage" in Safari > Settings > Advanced, which is disabled by default.

    The login footer renders action links as div elements with role="link" and tabindex="0", and external links as anchor tags. Both element types are excluded from Safari's default Tab order.

    What changes do you think we should make in order to solve the problem?

    Rather than changing individual footer elements, I'd fix this at the component level in TextLink so it applies consistently wherever TextLink is used, not just the login footer.

    On web, TextLink should render interactive items (those with onPress but no href) using PressableWithoutFeedback wrapped in a button-styled element. Safari always includes button elements in its Tab order. The button would carry reset styles (background: none, border: none, padding: 0, font: inherit, cursor: pointer) so it visually matches the current link appearance.

    For href-based links, the approach is different. Changing these to buttons would break semantics and right-click "Open in new tab" behavior. Instead, apply a -webkit-user-modify: read-write CSS property on the anchor element for Safari only. This is a known Safari-specific workaround that forces anchor elements into the Tab order without requiring the user to change their system preferences. Scope it with a @supports (-webkit-touch-callout: none) media query so it only applies to Safari/WebKit browsers.

    This keeps href links as proper anchor tags (preserving semantics, accessibility tree correctness, and native browser behaviors like cmd+click) while still making them tabbable in Safari.

    Testing plan: verify Tab navigation reaches all footer elements on Safari, Chrome, and Firefox on macOS. Verify mobile platforms (iOS, Android) are unaffected. Verify the visual appearance of footer links is unchanged. Verify right-click "Open in new tab" still works on href-based links.

    What alternative solutions did you explore?

    Changing all footer links to button elements (Option A in the existing proposal) would work for Tab navigation but breaks semantics on href-based external links. Buttons that navigate to external URLs are not standard HTML semantics, and users lose native anchor behaviors like cmd+click to open in new tab, right-click context menu with "Copy Link Address," and browser status bar showing the destination URL on hover.

    Adding role="button" (Option B in the existing proposal) has the same semantic trade-off and additionally changes the accessibility tree announcement from "link" to "button" for screen readers, which could confuse users expecting a link to navigate them to an external page.

  10. melvin-bot commented on Mar 2, 2026

    @melvin-bot

    📣 @workmshaheen! 📣
    Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
    Please follow these steps:

    1. Make sure you've read and understood the contributing guidelines.
    2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
    3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
    4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
      Screen Shot 2022-11-16 at 4 42 54 PM
      Format:
    Contributor details
    Your Expensify account email: <REPLACE EMAIL HERE>
    Upwork Profile Link: <REPLACE LINK HERE>
    
  11. nyomanjyotisa commented on Mar 2, 2026

    @nyomanjyotisa
    Member

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Log in page - User can't select the footer via Tab key on Safari

    What is the root cause of that problem?

    TextLink renders a Text component (which becomes a <div> on web) with role="link", but does not set a tabIndex on it. Safari only includes natively interactive elements (<a>, <button>, <input>) in its tab order by default — unlike Chrome and Firefox which respect role="link" on non-native elements. Without an explicit tabIndex={0}, Safari skips these elements entirely when tabbing.

    return (
    <Text
    style={suppressDefaultStyle ? style : [styles.link, style]}
    role={CONST.ROLE.LINK}
    href={href}
    onPress={openLinkOnTap}
    onKeyDown={openLinkOnEnterKey}
    onMouseDown={onMouseDown}
    ref={ref}
    suppressHighlighting
    accessible
    // eslint-disable-next-line react/jsx-props-no-spreading
    {...rest}
    >
    {children}
    </Text>
    );

    The "Get Started" section are working correctly because they use onPress without href, so React Native Web renders them as <div role="link">

    What changes do you think we should make in order to solve the problem?

    Add tabIndex={0} to the Text inside TextLink so Safari includes it in the tab order:

        return (
            <Text
                ...
                tabIndex={0}
                ...
            >

    return (
    <Text
    style={suppressDefaultStyle ? style : [styles.link, style]}
    role={CONST.ROLE.LINK}
    href={href}
    onPress={openLinkOnTap}
    onKeyDown={openLinkOnEnterKey}
    onMouseDown={onMouseDown}
    ref={ref}
    suppressHighlighting
    accessible
    // eslint-disable-next-line react/jsx-props-no-spreading
    {...rest}
    >
    {children}
    </Text>

    What alternative solutions did you explore? (Optional)

    Add tabIndex={0} directly to the TextLink usages in the footer to scope the fix only to the login page:

                                        {onPress ? (
                                            <TextLink
                                                style={getTextLinkStyle(hovered)}
                                                onPress={onPress}
                                                tabIndex={0}
                                            >
                                                {translate(translationPath)}
                                            </TextLink>
                                        ) : (
                                            <TextLink
                                                style={getTextLinkStyle(hovered)}
                                                href={href}
                                                tabIndex={0}
                                            >
                                                {translate(translationPath)}
                                            </TextLink>
                                        )}

    {onPress ? (
    <TextLink
    style={getTextLinkStyle(hovered)}
    onPress={onPress}
    >
    {translate(translationPath)}
    </TextLink>
    ) : (
    <TextLink
    style={getTextLinkStyle(hovered)}
    href={href}
    >
    {translate(translationPath)}
    </TextLink>
    )}

  12. 38 remaining items

  13. aimane-chnaif commented on Mar 23, 2026

    @aimane-chnaif
    Contributor

    I am still not able to reproduce. Safari version: Version 26.0.1 (21622.1.22.11.15)

    not.repro.mov
  14. melvin-bot commented on Mar 26, 2026

    @melvin-bot

    @mallenexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  15. m-natarajan commented on Mar 27, 2026

    @m-natarajan

    @aimane-chnaif @nyomanjyotisa Unable to reproduce this in Mac/Safari 18.6

    Recording.289.mp4
  16. melvin-bot commented on Mar 30, 2026

    @melvin-bot

    @mallenexpensify Still overdue 6 days?! Let's take care of this!

  17. melvin-bot commented on Mar 30, 2026

    @melvin-bot

    @mallenexpensify Still overdue 6 days?! Let's take care of this!

  18. melvin-bot commented on Mar 30, 2026

    @melvin-bot

    @mallenexpensify Still overdue 6 days?! Let's take care of this!

  19. mallenexpensify commented on Apr 1, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor: @nyomanjyotisa due $250 via NewDot
    Contributor+: @aimane-chnaif paid $250 via Upwork

    @aimane-chnaif plz complete the BZ checklist and tag me in a post once you have. Thx

  20. aimane-chnaif commented on Apr 1, 2026

    @aimane-chnaif
    Contributor

    BugZero Checklist:

    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: This is not a regression. The bug existed from the beginning.

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    This is accessibility project. Still requires regression test?

    Test:

    1. Open the app on Safari
    2. In Login page, try to select the footer via Tab key
    3. Verify that user can select the footer via Tab key

    Do we agree 👍 or 👎

  21. mallenexpensify commented on Apr 1, 2026

    @mallenexpensify
    Contributor

    oh, sorry @aimane-chnaif . For the regression tests, we'll do those all at the end. Thx

  22. trjExpensify commented on May 29, 2026

    @trjExpensify
    Contributor

    approved $250 for @nyomanjyotisa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions