You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-03-13] [$250] Expense - Tax rate column only shows tha rate without tax rate name #83963
Version Number: 9.3.28-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#82904 Email or phone of affected tester (no customers):isodjnosidjiojiojiso@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.2 / Chrome App Component: Money Requests
Action Performed:
Precondition:
Taxes are enabled.
Go to staging.new.expensify.com
Go to workspace chat.
Create two expenses with any tax.
Open the expense report.
Click Columns.
Select Tax rate and click Save.
Scroll the table to Tax rate.
Expected Result:
Tax rate column will show tax rate name (similar to Reports > Expenses when the same Tax column is applied).
Actual Result:
Tax rate column only shows tha rate without tax rate name.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
PR #82904 introduced a new feature allowing users to customize columns in the report details view, including the Tax Rate column. However, when the Tax Rate column is displayed, it only shows the rate percentage (e.g., "10%") instead of the full tax name (e.g., "GST 10%") because the transaction objects lack the necessary policy property.
Labels: Removing DeployBlocker label (this is a frontend bug affecting the App). Keeping DeployBlockerCash (blocks App deploy).
getTaxName() requires the policy object to look up the full tax name (e.g., "GST 10%") from the tax code. However:
In Search results (src/libs/SearchUIUtils.ts line 1720-1748): The policy is explicitly added to each transaction item
In MoneyRequestReportTransactionList (src/components/MoneyRequestReportView/MoneyRequestReportTransactionList.tsx lines 540-581): The transaction is passed directly to MoneyRequestReportTransactionItem WITHOUT the policy property
The MoneyRequestReportTransactionList component receives the policy as a prop (line 84) but does not pass it to MoneyRequestReportTransactionItem, which then passes the incomplete transaction object to TransactionItemRow.
Root Cause
When getTaxName(transactionItem.policy, transactionItem) is called with transactionItem.policy === undefined, it cannot look up the tax name and returns undefined. The code then falls back to transactionItem.taxValue, which contains only the numeric rate (e.g., "0.10" displayed as "10%") without the descriptive name.
This issue exists specifically in the report details view (newly affected by PR #82904) but works correctly in the Search/Reports page where transactions include the policy property.
changed the title [-][$250] Expense - Tax rate column only shows tha rate without tax rate name[/-][+][Due for payment 2026-03-13] [$250] Expense - Tax rate column only shows tha rate without tax rate name[/+]on Mar 6, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.31-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@QichenZhu@trjExpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon Mar 3, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #82904
melvin-bot commentedon Mar 3, 2026
💬 A slack conversation has been started in #expensify-open-source
melvin-bot commentedon Mar 3, 2026
Triggered auto assignment to @brianlee-expensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.github-actions commentedon Mar 3, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon Mar 3, 2026
Investigation Summary
Classification: Frontend bug
Causing PR: #82904 - "Feat/82252 custom report layout columns" by @mukhrr (High confidence)
Related Issues: #82252 (original feature request)
Recommendation: REVERT
PR #82904 introduced a new feature allowing users to customize columns in the report details view, including the Tax Rate column. However, when the Tax Rate column is displayed, it only shows the rate percentage (e.g., "10%") instead of the full tax name (e.g., "GST 10%") because the transaction objects lack the necessary
policyproperty.Labels: Removing
DeployBlockerlabel (this is a frontend bug affecting the App). KeepingDeployBlockerCash(blocks App deploy).Detailed Analysis
Evidence
REPORT_DETAILS_CUSTOM_COLUMNSwhich includesTAX_RATEfor the first timeVerification
The tax rate display logic is in
src/components/TransactionItemRow/index.tsxline 567:getTaxName()requires thepolicyobject to look up the full tax name (e.g., "GST 10%") from the tax code. However:src/libs/SearchUIUtils.tsline 1720-1748): The policy is explicitly added to each transaction itemsrc/components/MoneyRequestReportView/MoneyRequestReportTransactionList.tsxlines 540-581): The transaction is passed directly toMoneyRequestReportTransactionItemWITHOUT the policy propertyThe
MoneyRequestReportTransactionListcomponent receives thepolicyas a prop (line 84) but does not pass it toMoneyRequestReportTransactionItem, which then passes the incomplete transaction object toTransactionItemRow.Root Cause
When
getTaxName(transactionItem.policy, transactionItem)is called withtransactionItem.policy === undefined, it cannot look up the tax name and returnsundefined. The code then falls back totransactionItem.taxValue, which contains only the numeric rate (e.g., "0.10" displayed as "10%") without the descriptive name.This issue exists specifically in the report details view (newly affected by PR #82904) but works correctly in the Search/Reports page where transactions include the policy property.
22 remaining items
IuliiaHerets commentedon Mar 3, 2026
Chrome / v9.3.28-4
No Columns in report. No Tax column in report table
Screen.Recording.2026-03-03.at.20.34.53.mp4
[-][$250] Expense - Tax rate column only shows tha rate without tax rate name[/-][+][Due for payment 2026-03-13] [$250] Expense - Tax rate column only shows tha rate without tax rate name[/+]melvin-bot commentedon Mar 6, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Mar 6, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.31-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-03-13. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Mar 6, 2026
@QichenZhu @trjExpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
melvin-bot commentedon Mar 31, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
melvin-bot commentedon Mar 31, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
melvin-bot commentedon Apr 1, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.