Skip to content

[Due for payment 2026-03-13] [$250] Expense - Tax rate column only shows tha rate without tax rate name #83963

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.28-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #82904
Email or phone of affected tester (no customers): isodjnosidjiojiojiso@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.2 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • Taxes are enabled.
  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Create two expenses with any tax.
  4. Open the expense report.
  5. Click Columns.
  6. Select Tax rate and click Save.
  7. Scroll the table to Tax rate.

Expected Result:

Tax rate column will show tax rate name (similar to Reports > Expenses when the same Tax column is applied).

Actual Result:

Tax rate column only shows tha rate without tax rate name.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Bug7092375_1772492552534.9.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @trjExpensify
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~022028623137589452607
  • Upwork Job ID: 2028623137589452607
  • Last Price Increase: 2026-03-03

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Mar 3, 2026
  2. melvin-bot commented on Mar 3, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #82904

  3. melvin-bot commented on Mar 3, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  4. melvin-bot commented on Mar 3, 2026

    @melvin-bot

    Triggered auto assignment to @brianlee-expensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. github-actions commented on Mar 3, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. OSBotify commented on Mar 3, 2026

    @OSBotify
    Contributor

    Investigation Summary

    Classification: Frontend bug
    Causing PR: #82904 - "Feat/82252 custom report layout columns" by @mukhrr (High confidence)
    Related Issues: #82252 (original feature request)

    Recommendation: REVERT

    PR #82904 introduced a new feature allowing users to customize columns in the report details view, including the Tax Rate column. However, when the Tax Rate column is displayed, it only shows the rate percentage (e.g., "10%") instead of the full tax name (e.g., "GST 10%") because the transaction objects lack the necessary policy property.

    Labels: Removing DeployBlocker label (this is a frontend bug affecting the App). Keeping DeployBlockerCash (blocks App deploy).

    Detailed Analysis

    Evidence

    Verification

    The tax rate display logic is in src/components/TransactionItemRow/index.tsx line 567:

    <TextCell text={isTimeRequest(transactionItem) ? '' : (getTaxName(transactionItem.policy, transactionItem) ?? transactionItem.taxValue ?? '')} />

    getTaxName() requires the policy object to look up the full tax name (e.g., "GST 10%") from the tax code. However:

    1. In Search results (src/libs/SearchUIUtils.ts line 1720-1748): The policy is explicitly added to each transaction item
    2. In MoneyRequestReportTransactionList (src/components/MoneyRequestReportView/MoneyRequestReportTransactionList.tsx lines 540-581): The transaction is passed directly to MoneyRequestReportTransactionItem WITHOUT the policy property

    The MoneyRequestReportTransactionList component receives the policy as a prop (line 84) but does not pass it to MoneyRequestReportTransactionItem, which then passes the incomplete transaction object to TransactionItemRow.

    Root Cause

    When getTaxName(transactionItem.policy, transactionItem) is called with transactionItem.policy === undefined, it cannot look up the tax name and returns undefined. The code then falls back to transactionItem.taxValue, which contains only the numeric rate (e.g., "0.10" displayed as "10%") without the descriptive name.

    This issue exists specifically in the report details view (newly affected by PR #82904) but works correctly in the Search/Reports page where transactions include the policy property.

  7. 22 remaining items

  8. IuliiaHerets commented on Mar 3, 2026

    @IuliiaHerets

    Chrome / v9.3.28-4
    No Columns in report. No Tax column in report table

    Screen.Recording.2026-03-03.at.20.34.53.mp4
  9. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Mar 6, 2026
  10. changed the title [-][$250] Expense - Tax rate column only shows tha rate without tax rate name[/-] [+][Due for payment 2026-03-13] [$250] Expense - Tax rate column only shows tha rate without tax rate name[/+] on Mar 6, 2026
  11. melvin-bot commented on Mar 6, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  12. melvin-bot commented on Mar 6, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.31-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-03-13. 🎊

    For reference, here are some details about the assignees on this issue:

    • @QichenZhu requires payment through NewDot Manual Requests
    • @mukhrr requires payment (Needs manual offer from BZ)
  13. melvin-bot commented on Mar 6, 2026

    @melvin-bot

    @QichenZhu @trjExpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  14. melvin-bot commented on Mar 31, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  15. melvin-bot commented on Mar 31, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  16. melvin-bot commented on Apr 1, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions