You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-03-16] [$250] Add BA - Browser back button is redirecting to confirmation page from success page #83978
Version Number: 9.3.28-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack:#81333 Email or phone of affected tester (no customers):rogerjesusrosarioh+577@gmail.com Issue reported by: Applause Internal Team Bug source: Pull Request QA execution Device used: Web App Component: User Settings
Action Performed:
Go to Account > Wallet > Add bank account
Complete the flow and reach the confirmation page
Accept the terms and click on "Confirm"
In the success page, click on the browsers back button
Expected Result:
Page should close the success RHP and open the "Add bank account" RHP.
Actual Result:
When clicking on the browsers back button in the success page, it is redirecting back to the confirmation page.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #81333 - "Refactor add personal bank account to use useSubPage" by @bernhardoj (High confidence) Related Issues: None
Recommendation: REVERT
The PR refactored the add bank account flow from a single-page modal to a multi-page flow with URL-based navigation (using useSubPage hook). This introduced browser history entries for each sub-page, causing the browser back button to navigate through the history stack instead of closing the modal.
Labels: Keeping DeployBlockerCash (App PR caused the issue); Removing DeployBlocker (not a backend issue)
📋 Detailed Analysis
Evidence
The issue is marked as staging-only (reproducible in 9.3.28-0, not in production)
The bug occurs in the "Add bank account" flow which was refactored in this PR
Verification
PR #81333 modified the following key files that relate to the bug:
src/ROUTES.ts - Changed route from settings/wallet/add-bank-account to settings/wallet/add-bank-account/:subPage?/:action?
src/pages/settings/Wallet/InternationalDepositAccount/InternationalDepositAccountContent.tsx - Refactored from useSubStep to useSubPage hook
All sub-pages (CountrySelection, BankAccountDetails, AccountType, BankInformation, AccountHolderInformation, Confirmation, Success) were updated
Root Cause
The refactor introduced URL-based navigation for the bank account flow. Each step now has its own URL:
settings/wallet/add-bank-account/country
settings/wallet/add-bank-account/account-details
settings/wallet/add-bank-account/confirm
settings/wallet/add-bank-account/success
When users complete the flow and reach the success page, their browser history contains all these URLs. Clicking the browser back button navigates to the previous URL (/confirm) instead of closing the modal entirely.
The app has a handleBackButtonPress function that correctly handles the Android back button and header back button to dismiss the modal on the success page, but this handler does not intercept the browser back button, which operates directly on the browser history stack.
Technical Details:
In InternationalDepositAccountContent.tsx, lines 219-226 (after changes):
// Clicking back on the success screen should dismiss the modalif(pageIndex===CONST.CORPAY_FIELDS.INDEXES.MAPPING.SUCCESS){clearDraftValues(ONYXKEYS.FORMS.INTERNATIONAL_BANK_ACCOUNT_FORM);goBack();returntrue;}
This code handles Android/header back buttons but not browser navigation events.
changed the title [-][$250] Add BA - Browser back button is redirecting to confirmation page from success page[/-][+][Due for payment 2026-03-16] [$250] Add BA - Browser back button is redirecting to confirmation page from success page[/+]on Mar 9, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.33-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@arosiclair The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon Mar 3, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #81333
melvin-bot commentedon Mar 3, 2026
💬 A slack conversation has been started in #expensify-open-source
melvin-bot commentedon Mar 3, 2026
Triggered auto assignment to @heyjennahay (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.github-actions commentedon Mar 3, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon Mar 3, 2026
🔍 Investigation Summary
Classification: Frontend bug
Causing PR: #81333 - "Refactor add personal bank account to use useSubPage" by @bernhardoj (High confidence)
Related Issues: None
Recommendation: REVERT
The PR refactored the add bank account flow from a single-page modal to a multi-page flow with URL-based navigation (using
useSubPagehook). This introduced browser history entries for each sub-page, causing the browser back button to navigate through the history stack instead of closing the modal.Labels: Keeping
DeployBlockerCash(App PR caused the issue); RemovingDeployBlocker(not a backend issue)📋 Detailed Analysis
Evidence
Verification
PR #81333 modified the following key files that relate to the bug:
src/ROUTES.ts- Changed route fromsettings/wallet/add-bank-accounttosettings/wallet/add-bank-account/:subPage?/:action?src/pages/settings/Wallet/InternationalDepositAccount/InternationalDepositAccountContent.tsx- Refactored fromuseSubSteptouseSubPagehookRoot Cause
The refactor introduced URL-based navigation for the bank account flow. Each step now has its own URL:
settings/wallet/add-bank-account/countrysettings/wallet/add-bank-account/account-detailssettings/wallet/add-bank-account/confirmsettings/wallet/add-bank-account/successWhen users complete the flow and reach the success page, their browser history contains all these URLs. Clicking the browser back button navigates to the previous URL (
/confirm) instead of closing the modal entirely.The app has a
handleBackButtonPressfunction that correctly handles the Android back button and header back button to dismiss the modal on the success page, but this handler does not intercept the browser back button, which operates directly on the browser history stack.Technical Details:
In
InternationalDepositAccountContent.tsx, lines 219-226 (after changes):This code handles Android/header back buttons but not browser navigation events.
28 remaining items
bernhardoj commentedon Mar 5, 2026
Sure, here is the PR: #84236
[-][$250] Add BA - Browser back button is redirecting to confirmation page from success page[/-][+][Due for payment 2026-03-16] [$250] Add BA - Browser back button is redirecting to confirmation page from success page[/+]melvin-bot commentedon Mar 9, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Mar 9, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.33-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-03-16. 🎊
melvin-bot commentedon Mar 9, 2026
@arosiclair The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
melvin-bot commentedon Mar 9, 2026
Triggered auto assignment to @CortneyOfstad (
Awaiting Payment)bernhardoj commentedon Mar 10, 2026
No need for a payment here