Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.3.31-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #82982
Email or phone of affected tester (no customers): josidjnosidjoidjiosj@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.2 / Chrome
App Component: Search
Action Performed:
- Go to staging.new.expensify.com
- Go to Reports > Expenses.
- Click Filters.
- Click Has.
- Click on the Receipt row.
- Click Save.
- Click Has.
Expected Result:
Tooltip will dismiss after selecting Receipt filter (same way tooltip is dismissed after clicking 3-dot menu on saved search).
Actual Result:
Tooltip does not dismiss after selecting Receipt filter.
Workaround:
Unknown
Platforms:
- Android: App
- Android: mWeb Chrome
- iOS: App
- iOS: mWeb Safari
- iOS: mWeb Chrome
- Windows: Chrome
- MacOS: Chrome / Safari
Screenshots/Videos
1.mp4
Metadata
Metadata
Assignees
Labels
Type
Projects
- StatusShow more project fieldsDone
Activity
melvin-bot commentedon Mar 4, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #82982
melvin-bot commentedon Mar 4, 2026
💬 A slack conversation has been started in #expensify-open-source
melvin-bot commentedon Mar 4, 2026
Triggered auto assignment to @laurenreidexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.github-actions commentedon Mar 4, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon Mar 4, 2026
🔍 Investigation Summary
Classification: Frontend bug
Causing PR: #82982 - "fix: add a tooltip to train users" by @daledah (High confidence)
Related Issues: None
Recommendation: REVERT
PR #82982 added a product training tooltip to the Has filter page to educate users about the
-has:receiptnegation syntax. However, the tooltip does not automatically dismiss when users interact with the filter options (e.g., clicking on "Receipt"). The tooltip only dismisses when the user explicitly clicks the close button or navigates away from the page, creating a poor user experience.Labels: Keeping
DeployBlockerCash(frontend bug blocks App deploy). NoDeployBlockerlabel present to remove.📋 Detailed Analysis
Evidence
Verification
PR #82982 modified
src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersHasPage.tsxto:useProductTrainingContexthook to get tooltip rendering functionsHeaderWithBackButtonwithEducationalTooltipcomponentThe PR introduced these changes:
And wrapped the header:
Root Cause
The
useProductTrainingContexthook returns three values:renderProductTrainingTooltip- renders the tooltip UIhideProductTrainingTooltip- function to dismiss the tooltipshouldShowProductTrainingTooltip- boolean to control visibilityWhile the implementation correctly uses
renderProductTrainingTooltipandshouldShowProductTrainingTooltip, it never callshideProductTrainingTooltipwhen the user interacts with the SelectionList items.The tooltip should be automatically dismissed when users click on filter options (via the
onSelectRowcallback in the SelectionList), similar to how tooltips are dismissed on other pages when users complete the relevant action. Currently, theupdateSelectedItemscallback only updates state but doesn't hide the tooltip:This creates a confusing UX where the tooltip continues to overlay the interface even after the user has engaged with the feature the tooltip is teaching them about.
MelvinBot commentedon Mar 4, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
On the Search > Reports > Expenses > Filters > Has page, the educational tooltip (added by PR #82982) does not dismiss when the user selects a filter option (e.g., Receipt). The tooltip persists on screen until the user manually closes it via the (X) button or navigates away.
What is the root cause of that problem?
In
SearchFiltersHasPage.tsx:29, the component destructuresuseProductTrainingContextbut only takesrenderProductTrainingTooltipandshouldShowProductTrainingTooltip— it omitshideProductTrainingTooltip:The
updateSelectedItemscallback (lines 47-61) that fires when a user selects any filter row never callshideProductTrainingTooltip(). This contrasts with other components that correctly dismiss their tooltips on user interaction:AccountSwitcher.tsx:76— callshideProductTrainingTooltip()on pressOptionRowLHN.tsx:229— callshideProductTrainingTooltip()on row selectThreeDotsMenu/index.tsx:84— callshideProductTrainingTooltip?.()on press (the "working" example referenced in the issue)What changes do you think we should make in order to solve the problem?
In
src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersHasPage.tsx:hideProductTrainingTooltipfrom the existinguseProductTrainingContextcall on line 29hideProductTrainingTooltip()inside theupdateSelectedItemscallback, so the tooltip dismisses when the user selects any filter optionThis follows the established pattern used across the codebase (AccountSwitcher, OptionRowLHN, ThreeDotsMenu).
What alternative solutions did you explore? (Optional)
An alternative would be to add an
onSelectRowwrapper that handles both the tooltip dismissal and the existingupdateSelectedItemslogic separately, but that adds unnecessary indirection. CallinghideProductTrainingTooltip()directly insideupdateSelectedItemsis simpler and consistent with how other components handle this.Next Steps for Contributor+ team: Reply with
@MelvinBot implement thisto create a draft PR, or@MelvinBot <your feedback>to refine this analysis.1 remaining item
MelvinBot commentedon Mar 4, 2026
🤖 Draft PR created: #84171
Please mark it as "Ready for review" when it is ready for review.
puneetlath commentedon Mar 4, 2026
I don't think this needs to be a blocker.
@trjExpensify how do you think this should work? Right now it looks like it only dismisses if you click the "x". Do you think it should also dismiss if you click any checkbox on the page?
trjExpensify commentedon Mar 4, 2026
Yeah, I think you've taken an action on the page at that point and so it should be dismissed.
mkhutornyi commentedon Mar 4, 2026
Any action or only Receipt toggle action?
trjExpensify commentedon Mar 4, 2026
Any in the menu, I'd say.
puneetlath commentedon Mar 4, 2026
That makes sense to me too.
melvin-bot commentedon Mar 12, 2026
@puneetlath, @laurenreidexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!
puneetlath commentedon Mar 13, 2026
@mkhutornyi I believe this is live on production right. Is there anything left to do here or can we just close this?
mkhutornyi commentedon Mar 13, 2026
We can close this