Skip to content

Members - Column mapping list is not scrollable #84276

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.31-3
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #83823
Email or phone of affected tester (no customers): isodjnosidjiojiojiso@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Samsung Galaxy S25 FE / Android 16
App Component: Workspace Settings

Action Performed:

  1. Launch Expensify app.
  2. Go to workspace settings > Members.
  3. Tap More > Import spreadsheet.
  4. Upload a csv file.
  5. Tap on any column mapping dropdown button.
  6. Scroll the list.

Expected Result:

Column mapping list will be scrollable.

Actual Result:

Column mapping list is not scrollable.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 5, 2026
  2. melvin-bot commented on Mar 5, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #83823

  3. melvin-bot commented on Mar 5, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  4. melvin-bot commented on Mar 5, 2026

    @melvin-bot

    Triggered auto assignment to @lydiabarclay (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. github-actions commented on Mar 5, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. OSBotify commented on Mar 5, 2026

    @OSBotify
    Contributor

    🔍 Investigation Summary

    Classification: Frontend bug
    Causing PR: #83823 - "Add missing CSV member import column mapping options" by @MelvinBot (High confidence)
    Related Issues: None

    Recommendation: REVERT

    PR #83823 added 4 new column mapping options (Custom Field 1, Custom Field 2, Approval Limit, Over Limit Forward To) to the member CSV import flow, increasing the total options from 5 to 9. This caused the dropdown menu to exceed the available screen height on mobile devices. The dropdown is not scrollable because the component does not pass the shouldPopoverUseScrollView prop to enable scrolling for longer lists.

    Labels: No label changes made (keeping DeployBlockerCash as this is a frontend bug reproducible on staging but not in production)

    📋 Detailed Analysis

    Evidence

    PR #83823 modified /home/runner/_work/App/App/src/pages/workspace/members/ImportedMembersPage.tsx to add 4 new column role options to the columnRoles array (lines 48-51):

    • Custom Field 1
    • Custom Field 2
    • Approval Limit
    • Over Limit Forward To

    This increased the dropdown options from 5 to 9 items. The issue reproduces exactly as described in the bug report:

    1. Go to workspace settings > Members > Import spreadsheet
    2. Upload a CSV file
    3. Tap on any column mapping dropdown
    4. The list is not scrollable on mobile (Android/iOS native apps)

    Verification

    The dropdown menu is rendered by ButtonWithDropdownMenu component in /home/runner/_work/App/App/src/components/ImportColumn.tsx (lines 226-238). The component does not pass the shouldPopoverUseScrollView prop.

    Other components in the codebase follow this pattern for enabling scroll:

    shouldPopoverUseScrollView={options.length >= CONST.DROPDOWN_SCROLL_THRESHOLD}

    Where CONST.DROPDOWN_SCROLL_THRESHOLD = 5 (defined in /home/runner/_work/App/App/src/CONST/index.ts:254).

    Before PR #83823: 5 options (exactly at threshold)
    After PR #83823: 9 options (exceeds threshold by 4)

    The dropdown now has 9 items but lacks the scroll capability, making items beyond the visible area inaccessible on mobile devices.

    Root Cause

    The ImportColumn component does not conditionally enable scrolling based on the number of options. When PR #83823 added 4 more options, the dropdown became too long for mobile screens but remained non-scrollable, preventing users from accessing all column mapping options.

    The fix requires adding shouldPopoverUseScrollView={options.length >= CONST.DROPDOWN_SCROLL_THRESHOLD} to the ButtonWithDropdownMenu component in ImportColumn.tsx.

  7. MelvinBot commented on Mar 5, 2026

    @MelvinBot
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    The column mapping dropdown list in Workspace Settings > Members > Import spreadsheet is not scrollable on mobile (Android/iOS). After tapping a column mapping dropdown, users cannot scroll through all available options.

    What is the root cause of that problem?

    PR #83823 added 4 new column mapping options (Custom Field 1, Custom Field 2, Approval Limit, Over Limit Forward To), bringing the total from 5 to 9 items. The ImportColumn component (src/components/ImportColumn.tsx:226-238) renders a ButtonWithDropdownMenu but does not pass the shouldPopoverUseScrollView prop. This defaults to false, which causes PopoverMenu to wrap the menu items in a plain <View> instead of a <ScrollView> (src/components/PopoverMenu.tsx:186).

    On mobile, the popup renders as a BOTTOM_DOCKED modal with overflow: 'hidden' on its container and a maxHeight of 432px. Since the 9 items exceed this height and the content is in a non-scrollable <View>, the overflow is simply clipped — users cannot scroll to see all options.

    What changes do you think we should make in order to solve the problem?

    Add shouldPopoverUseScrollView to the ButtonWithDropdownMenu in src/components/ImportColumn.tsx, following the established pattern used by SettlementButton (src/components/SettlementButton/index.tsx:601), SearchBulkActionsButton (src/components/Search/SearchBulkActionsButton.tsx:118), and MoneyReportHeaderKYCDropdown (src/components/MoneyReportHeaderKYCDropdown.tsx:70):

    shouldPopoverUseScrollView={options.length >= CONST.DROPDOWN_SCROLL_THRESHOLD}
    

    The DROPDOWN_SCROLL_THRESHOLD constant is already defined as 5 in src/CONST/index.ts:254. With 9 options, this condition is true, causing PopoverMenu to wrap menu items in a <ScrollView> — making the list scrollable within the modal's maxHeight constraint.

    What alternative solutions did you explore? (Optional)

    An alternative would be to always enable shouldPopoverUseScrollView={true} unconditionally, but the threshold-based approach is the established convention in the codebase and avoids adding unnecessary scroll behavior when the list is short enough to fit on screen.


    Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, or @MelvinBot <your feedback> to refine this analysis.

  8. m-natarajan commented on Mar 5, 2026

    @m-natarajan

    Issue is reproducible, iPhone 12 mini / iOS 26.3, v9.3.31-9 (Waiting for the validation result in Android)

    Repro84276iOS.mp4
  9. m-natarajan commented on Mar 5, 2026

    @m-natarajan

    Not reproduce. Can select any value from the list, Xiaomi Redmi Note 10 / Android 12, App 9.3.31-10

    Screenrecorder-2026-03-06-01-00-16-908.mp4

    Not repro in iPhone13/26.3, v9.3.31-10

    ScreenRecording_03-05-2026.18-09-15_1.MP4
  10. mollfpr commented on Mar 6, 2026

    @mollfpr
    Contributor

    Reverted in #84301

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringHourlyKSv2ReviewingHas a PR in review

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions