Skip to content

[Duplicate Expense] Allow bulk duplication #84281

Closed

Description

@JS00001

Allow for bulk duplicating expenses on the reports page by selecting multiple, and then duplicating them. Some notes:

  • General info about duplicating expenses in ND is in this issue.
  • Users can duplicate cash, Per Diem, or Distance expense in any state (Unreported, Draft, Processing, Approved, Paid).
  • Users cannot duplicate card expenses - so if the selection includes card expenses, we shouldn't show the Duplicate option.

Activity

  1. self-assigned this
    on Mar 5, 2026
  2. changed the title [-]Duplicate Expenses - Allow bulk duplication[/-] [+][Duplicate Expense] Allow bulk duplication[/+] on Mar 5, 2026
  3. trjExpensify commented on Mar 5, 2026

    @trjExpensify
    Contributor

    Just noting that even selecting one expense here in the menu doesn't work now either, but should as well. 👍

    Image
  4. trjExpensify commented on Mar 9, 2026

    @trjExpensify
    Contributor

    @jjcoffee are you prioritising this one, or what's the next step for it? @garrettmknight @JS00001 I suspect this feature request feedback is driven by the lack of the Duplicate option in the Expenses page bulk select menu.

  5. jjcoffee commented on Mar 9, 2026

    @jjcoffee
    Contributor

    @trjExpensify I'm good with opening it up to the community to speed things along. I'm prioritising fixes for the distance PR at the moment (as well as other work).

  6. 62 remaining items

  7. JS00001 commented on Apr 28, 2026

    @JS00001
    ContributorAuthor

    This one is on production, so should be ready for payment soon

  8. JS00001 commented on Apr 28, 2026

    @JS00001
    ContributorAuthor

    Lets increase the bounty to $750 here to reflect the increased effort required to get this one over the line (while acknowledging that some regressions came up that had to be fixed)

  9. Krishna2323 commented on Apr 29, 2026

    @Krishna2323
    Contributor

    Hi @JS00001, thanks for the price bump. I'd like to request a further increase given the complexity involved. I'm comparing against the single-expense duplication PR (#75323), which was valued at $1,500, as a baseline to justify the ask. With the increase to $750, I’m proposing $1,250 as a balanced adjustment rather than pushing for the full $1,500 baseline.

    Proposed amount: $1,250

    Multiple PRs

    Scope expansion

    • Cross-policy handling — the main complexity driver. The bulk flow required threading existingIOUReport, optimisticReportPreviewActionID, and shouldDeferAutoSubmit across a loop, handling Onyx deferred-callback race conditions, and implementing policy-aware report splitting (policyWillSplitReport). This does not exist in the single-duplicate flow.
    • Per diem and distance expense support — Comparing to the single expense PR, these were handled as separate paid follow-ups in the single-duplicate feature. The core implementation was already done but including these cases added some complexity.
    • Shared bug fix — hold violation not shown for duplicated split expenses (#88300), fixed as part of this work but it should have been covered in single duplicate PR.
    • Performance safeguard — 50-item cap to prevent UI unresponsiveness ([Due for payment 2026-04-30] Duplicate expense - Page become unresponsive when duplicating bulk expenses #87604).

    Deploy blockers audited

    Test coverage

    • 20+ QA scenarios documented in the PR checklist to reduce regressions.

    For context, the single-expense duplication feature totaled ~$3,250 across multiple PRs. I believe $1,250 for the bulk feature and its follow-ups is fair given the added complexity. #65948 (comment)

    cc: @situchan

  10. garrettmknight commented on Apr 29, 2026

    @garrettmknight
    Contributor

    Thanks for the thorough layout for an increase. I'm good with $1250 for the complexity. To break that down a bit differently:

    Main: #84657
    Follow-up 1: #87697 (6 deploy blockers)
    Follow-up 2: #88442 (2 fixes)

    The deploy blockers are actually a detractor from the main PR. If they counted against that price and would have halved it down to $.97, but that's a bit ridiculous. So I think I'd set the initial PR standard at $250, and the quick work on DBs and fixes merits a partial payment of $125 per issue fixed. So $250 + 8 x $125 = $1250

  11. JS00001 commented on Apr 29, 2026

    @JS00001
    ContributorAuthor

    I agree, with the additional details above, that sounds good to me. Thank you for writing that up!

  12. garrettmknight commented on Apr 29, 2026

    @garrettmknight
    Contributor

    Payment summary:

  13. laurenreidexpensify commented on May 11, 2026

    @laurenreidexpensify
    Contributor

    $1250 approved for @situchan

  14. Krishna2323 commented on May 15, 2026

    @Krishna2323
    Contributor

    Requested in ND.

  15. laurenreidexpensify commented on May 19, 2026

    @laurenreidexpensify
    Contributor

    $1250 approved for @Krishna2323

  16. Krishna2323 commented on Jun 4, 2026

    @Krishna2323
    Contributor

    The PR for this feature (#84657) introduced a regression (#89872) — the bulk duplicate option was hidden in group-by search view. Fixed in #91008. 🥲

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2NewFeatureSomething to build that is a new item.

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions