You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-03-16] Workflows - Badge outline is not visible when user is selected #84358
Version Number: 9.3.32-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack:#82210 Email or phone of affected tester (no customers):sjodijsoijosjoidsji@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.2 / Chrome App Component: Workspace Settings
Action Performed:
Go to staging.new.expensify.com
Go to workspace settings > Workflows.
Click on the default workflow.
Click Approver > Approver.
Expected Result:
Badge outline should be visible when user is selected.
Actual Result:
Badge outline blends with the selection highlight and becomes not visible when user is selected.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #82210 - "Update badge styles" by @abzokhattab (High confidence) Related Issues: None
Recommendation: REVERT
PR #82210 introduced a visual regression where the badge outline blends with the selection highlight, making it invisible when a user is selected. This affects user experience in the Workflows > Approver selection screen.
Labels: Keeping DeployBlockerCash (this is a Frontend bug affecting the App), no label changes needed.
📋 Detailed Analysis
Evidence
PR #82210 updated badge styles and introduced new badge theme colors. The issue manifests specifically when:
User navigates to Workspace Settings > Workflows > Default workflow > Approver
Selects a user from the list
The badge (showing "Owner", "Admin", or "Auditor" role) outline becomes invisible against the selection highlight
Both use the same color value, causing the badge border (which uses borderColor: theme.badgeDefaultBG) to have the same color as the selected row background.
The badge is rendered via:
WorkspaceWorkflowsApprovalsApproverPage.tsx renders approvers with MemberRightIcon in rightElement
MemberRightIcon.tsx renders a Badge component for Owner/Admin/Auditor roles
When the row is selected, InviteMemberListItem applies sidebarLinkActive background color
The badge outline becomes invisible due to the color match
Root Cause
The Badge component in PR #82210 was updated with new theme colors, but the default badge background color (badgeDefaultBG) was set to the same value as the active/selected component background (activeComponentBG), both using colors.productLight400. This creates a visual accessibility issue where badges with borders are not distinguishable when rendered on selected list items.
Please re-state the problem that we are trying to solve in this issue.
When selecting an approver in Workspace Settings > Workflows > Approver, the default Badge (e.g. "Admin", "Owner") becomes invisible on the selected/focused row because the badge's background and border color are identical to the row's selection highlight color.
What is the root cause of that problem?
PR #82210 ("Update badge styles") changed the default Badge from an outlined style (transparent background with a visible border) to a filled style where both backgroundColor and borderColor are set to theme.badgeDefaultBG.
In both light and dark themes, badgeDefaultBG maps to the exact same color value as activeComponentBG (the selection highlight color):
Theme
activeComponentBG
badgeDefaultBG
Color
Light
colors.productLight400
colors.productLight400
#E6E1DA
Dark
colors.productDark400
colors.productDark400
#1A3D32
The rendering chain is:
WorkspaceWorkflowsApprovalsApproverPage (:89-103) builds each approver item with isSelected: true and rightElement: <MemberRightIcon>.
MemberRightIcon (:28-32) renders a <Badge> with no success/error props, so it uses styles.defaultBadge.
BaseListItem (:132-137) applies {backgroundColor: theme.activeComponentBG} to the selected row.
Badge applies {backgroundColor: theme.badgeDefaultBG, borderColor: theme.badgeDefaultBG} — the same color as the row, making it invisible.
PR #82210 did add a badgeDefaultActive style (using theme.buttonHoveredBG) for badges rendered within MenuItem when focused. However, the approver list renders badges via rightElement in InviteMemberListItem, which bypasses MenuItem entirely, so the active-state override never applies.
What changes do you think we should make in order to solve the problem?
The fix should pass the isFocused/isSelected state down to the Badge so it can switch to the badgeDefaultActive style when rendered on a highlighted row, similar to what MenuItem already does.
Specifically, in InviteMemberListItem (or BaseListItem), when rendering item.rightElement, the focused/selected state should be propagated so that the Badge can apply styles.badgeDefaultActive (backgroundColor: theme.buttonHoveredBG) when the parent row is highlighted. This could be done by:
Wrapping rightElement in a context or passing isFocused/isSelected to it via cloneElement or a render-prop pattern, OR
Updating MemberRightIcon to accept an isHighlighted prop and conditionally apply styles.badgeDefaultActive as badgeStyles.
The second approach is simpler and more targeted — MemberRightIcon already accepts a badgeStyles prop, so the parent list item component can pass the appropriate active style when the row is selected.
What alternative solutions did you explore? (Optional)
Change badgeDefaultBG to a different color — This would fix the collision but would change the badge appearance globally across the app, potentially causing other visual regressions.
Always render a distinct border color on the default badge — Possible, but doesn't match the design intent of PR Update badge styles #82210 which deliberately made the badge filled.
Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.
changed the title [-]Workflows - Badge outline is not visible when user is selected[/-][+][Due for payment 2026-03-16] Workflows - Badge outline is not visible when user is selected[/+]on Mar 9, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.33-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@puneetlath@heyjennahay The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon Mar 6, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #82210
melvin-bot commentedon Mar 6, 2026
💬 A slack conversation has been started in #expensify-open-source
melvin-bot commentedon Mar 6, 2026
Triggered auto assignment to @heyjennahay (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.github-actions commentedon Mar 6, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon Mar 6, 2026
🔍 Investigation Summary
Classification: Frontend bug
Causing PR: #82210 - "Update badge styles" by @abzokhattab (High confidence)
Related Issues: None
Recommendation: REVERT
PR #82210 introduced a visual regression where the badge outline blends with the selection highlight, making it invisible when a user is selected. This affects user experience in the Workflows > Approver selection screen.
Labels: Keeping
DeployBlockerCash(this is a Frontend bug affecting the App), no label changes needed.📋 Detailed Analysis
Evidence
PR #82210 updated badge styles and introduced new badge theme colors. The issue manifests specifically when:
Verification
Affected files:
src/styles/theme/themes/light.ts- IntroducedbadgeDefaultBG: colors.productLight400src/components/Badge.tsx- Modified badge styling logic with newisStrongpropsrc/styles/index.ts- Added new badge style definitionsThe root cause:
In
src/styles/theme/themes/light.ts, PR #82210 set:badgeDefaultBG: colors.productLight400(default badge background)activeComponentBG: colors.productLight400(selected row background)Both use the same color value, causing the badge border (which uses
borderColor: theme.badgeDefaultBG) to have the same color as the selected row background.The badge is rendered via:
WorkspaceWorkflowsApprovalsApproverPage.tsxrenders approvers withMemberRightIconinrightElementMemberRightIcon.tsxrenders aBadgecomponent for Owner/Admin/Auditor rolesInviteMemberListItemappliessidebarLinkActivebackground colorRoot Cause
The Badge component in PR #82210 was updated with new theme colors, but the default badge background color (
badgeDefaultBG) was set to the same value as the active/selected component background (activeComponentBG), both usingcolors.productLight400. This creates a visual accessibility issue where badges with borders are not distinguishable when rendered on selected list items.Timeline verification:
MelvinBot commentedon Mar 6, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
When selecting an approver in Workspace Settings > Workflows > Approver, the default Badge (e.g. "Admin", "Owner") becomes invisible on the selected/focused row because the badge's background and border color are identical to the row's selection highlight color.
What is the root cause of that problem?
PR #82210 ("Update badge styles") changed the default Badge from an outlined style (transparent background with a visible border) to a filled style where both
backgroundColorandborderColorare set totheme.badgeDefaultBG.In both light and dark themes,
badgeDefaultBGmaps to the exact same color value asactiveComponentBG(the selection highlight color):activeComponentBGbadgeDefaultBGcolors.productLight400colors.productLight400#E6E1DAcolors.productDark400colors.productDark400#1A3D32The rendering chain is:
WorkspaceWorkflowsApprovalsApproverPage(:89-103) builds each approver item withisSelected: trueandrightElement: <MemberRightIcon>.MemberRightIcon(:28-32) renders a<Badge>with nosuccess/errorprops, so it usesstyles.defaultBadge.BaseListItem(:132-137) applies{backgroundColor: theme.activeComponentBG}to the selected row.Badgeapplies{backgroundColor: theme.badgeDefaultBG, borderColor: theme.badgeDefaultBG}— the same color as the row, making it invisible.PR #82210 did add a
badgeDefaultActivestyle (usingtheme.buttonHoveredBG) for badges rendered withinMenuItemwhen focused. However, the approver list renders badges viarightElementinInviteMemberListItem, which bypassesMenuItementirely, so the active-state override never applies.What changes do you think we should make in order to solve the problem?
The fix should pass the
isFocused/isSelectedstate down to the Badge so it can switch to thebadgeDefaultActivestyle when rendered on a highlighted row, similar to whatMenuItemalready does.Specifically, in
InviteMemberListItem(orBaseListItem), when renderingitem.rightElement, the focused/selected state should be propagated so that the Badge can applystyles.badgeDefaultActive(backgroundColor: theme.buttonHoveredBG) when the parent row is highlighted. This could be done by:rightElementin a context or passingisFocused/isSelectedto it viacloneElementor a render-prop pattern, ORMemberRightIconto accept anisHighlightedprop and conditionally applystyles.badgeDefaultActiveasbadgeStyles.The second approach is simpler and more targeted —
MemberRightIconalready accepts abadgeStylesprop, so the parent list item component can pass the appropriate active style when the row is selected.What alternative solutions did you explore? (Optional)
badgeDefaultBGto a different color — This would fix the collision but would change the badge appearance globally across the app, potentially causing other visual regressions.Next Steps for Contributor+ team: Reply with
@MelvinBot implement thisto create a draft PR,@MelvinBot <your feedback>to refine this analysis, or explain why you are rejecting Melvin's proposal.1 remaining item
puneetlath commentedon Mar 6, 2026
Fix CPd.
[-]Workflows - Badge outline is not visible when user is selected[/-][+][Due for payment 2026-03-16] Workflows - Badge outline is not visible when user is selected[/+]melvin-bot commentedon Mar 9, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Mar 9, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.33-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-03-16. 🎊
melvin-bot commentedon Mar 9, 2026
@puneetlath @heyjennahay The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
melvin-bot commentedon Mar 9, 2026
Triggered auto assignment to @joekaufmanexpensify (
Awaiting Payment)